Bug 123840

Summary:

[mac] PDFDocumentImage is too big if PDF has a crop box smaller than the media box

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

Images

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	ap: review+

Tim Horton

Reported 2013-11-05 16:54:26 PST

PDFDocumentImage uses the media box unconditionally when determining the size of the image, which is wrong. It does the right thing (use crop box and fall back to media box if it's not there) in other places, though... so, make this consistent. Also, if the crop box origin is not 0,0, we double-translate by it, because PDFKit applies translation for us. <rdar://problem/15308765>

Attachments
patch (15.56 KB, patch) 2013-11-05 16:59 PST, Tim Horton	ap: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Tim Horton

Comment 1 2013-11-05 16:59:36 PST

Created attachment 216099 [details] patch

Tim Horton

Comment 2 2013-11-05 17:11:31 PST

http://trac.webkit.org/changeset/158701

Alexey Proskuryakov

Comment 3 2013-11-05 23:17:31 PST

This test fails: http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r158719%20(13962)/results.html

Note You need to log in before you can comment on or make changes to this bug.