Summary: | Remote Layer Tree: Apply layer changes to LayerTypeCustom layers to the custom layer in the Web process, not to the CALayerHost | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
Component: | WebKit2 | Assignee: | Tim Horton <thorton> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, eric.carlson, jer.noble, simon.fraser | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Tim Horton
2013-11-05 12:59:28 PST
Created attachment 216062 [details]
patch
Comment on attachment 216062 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=216062&action=review > Source/WebKit2/Shared/mac/RemoteLayerTreePropertyApplier.h:39 > + typedef HashMap<RemoteLayerTreeTransaction::LayerID, PlatformLayer *> RelatedLayerMap; > + static void applyPropertiesToLayer(PlatformLayer *, RemoteLayerTreeTransaction::LayerProperties, RelatedLayerMap); > + static void disableActionsForLayer(PlatformLayer *); Please use CALayer instead of PlatformLayer. > Source/WebKit2/Shared/mac/RemoteLayerTreePropertyApplier.mm:43 > + RetainPtr<CGColorRef> cgColor = adoptCF(CGColorCreate(colorSpace.get(), components)); > + return cgColor; Can just return adoptCF > Source/WebKit2/Shared/mac/RemoteLayerTreePropertyApplier.mm:158 > +void RemoteLayerTreePropertyApplier::disableActionsForLayer(PlatformLayer *layer) Again, CALayer! > Source/WebKit2/Shared/mac/RemoteLayerTreePropertyApplier.mm:162 > + [layer setStyle:@{ @"actions" : @{ > + @"anchorPoint" : nullValue, Please put @“actions” on a new line. Can also use layr.style = here I think. > Source/WebKit2/Shared/mac/RemoteLayerTreePropertyApplier.mm:173 > + @"zPosition" : nullValue } }]; } should be on a separate line. |