Summary: | Avoid invalid cairo matrix when drawing surfaces too small | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Cidorvan Leite <cidorvan.leite> | ||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, d-r, mrobinson, noam, sergio | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Cidorvan Leite
2013-11-05 10:33:06 PST
Created attachment 216184 [details]
Patch
Comment on attachment 216184 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216184&action=review Thanks! One small nit in the patch. > Source/WebCore/platform/graphics/cairo/PlatformContextCairo.cpp:164 > FloatRect srcRect = originalSrcRect; > > + // Avoid invalid cairo matrix with small values. > + if (std::fabs(destRect.width()) < 0.5f || std::fabs(destRect.height()) < 0.5f) > + return; > + Please move this above the definition of srcRect, as srcRect is only used afterward. Created attachment 216314 [details]
Patch
Comment on attachment 216314 [details] Patch Clearing flags on attachment: 216314 Committed r158861: <http://trac.webkit.org/changeset/158861> All reviewed patches have been landed. Closing bug. |