| Summary: | [CSS Shapes][CSS Regions] Simplify shape-inside-on-multiple-regions-with-negative-shape-top.html | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zoltan Horvath <zoltan> | ||||||
| Component: | Tools / Tests | Assignee: | Zoltan Horvath <zoltan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, WebkitBugTracker | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Zoltan Horvath
2013-11-05 09:41:20 PST
Created attachment 216049 [details]
Patch
Comment on attachment 216049 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216049&action=review r=me with some nits, please take them into account before committing. > LayoutTests/fast/regions/shape-inside/shape-inside-on-multiple-regions-with-negative-shape-top-expected.html:35 > <p>Bug <a href="http://webkit.org/b/123103">123103</a>: [CSS Shapes][CSS Regions] Don't apply shape-inside when we have multiple auto-height regions and the height is not resolved</p> This is a wrong link to the original bug -> i think you mean 123346 > LayoutTests/fast/regions/shape-inside/shape-inside-on-multiple-regions-with-negative-shape-top.html:32 > <p>Bug <a href="http://webkit.org/b/123103">123103</a>: [CSS Shapes][CSS Regions] Don't apply shape-inside when we have multiple auto-height regions and the height is not resolved</p> Again, change the link to the bug please: 123346 Created attachment 217057 [details]
patch for land
Thanks for the review Mihnea!
Comment on attachment 217057 [details] patch for land Clearing flags on attachment: 217057 Committed r159344: <http://trac.webkit.org/changeset/159344> All reviewed patches have been landed. Closing bug. |