Bug 123808

Summary: [CSS Shapes][CSS Regions] Simplify shape-inside-on-multiple-regions-with-negative-shape-top.html
Product: WebKit Reporter: Zoltan Horvath <zoltan>
Component: Tools / TestsAssignee: Zoltan Horvath <zoltan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
mihnea: review+
patch for land none

Zoltan Horvath
Reported 2013-11-05 09:41:20 PST
Use a rectangle instead of a complex polygon in the test.
Attachments
Patch (6.23 KB, patch)
2013-11-05 09:42 PST, Zoltan Horvath 		mihnea: review+
DetailsFormatted DiffDiff
patch for land (6.37 KB, patch)
2013-11-15 09:34 PST, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zoltan Horvath
Comment 1 2013-11-05 09:42:52 PST
Created attachment 216049 [details] Patch
Mihnea Ovidenie
Comment 2 2013-11-05 23:46:24 PST
Comment on attachment 216049 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216049&action=review r=me with some nits, please take them into account before committing. > LayoutTests/fast/regions/shape-inside/shape-inside-on-multiple-regions-with-negative-shape-top-expected.html:35 > <p>Bug <a href="http://webkit.org/b/123103">123103</a>: [CSS Shapes][CSS Regions] Don't apply shape-inside when we have multiple auto-height regions and the height is not resolved</p> This is a wrong link to the original bug -> i think you mean 123346 > LayoutTests/fast/regions/shape-inside/shape-inside-on-multiple-regions-with-negative-shape-top.html:32 > <p>Bug <a href="http://webkit.org/b/123103">123103</a>: [CSS Shapes][CSS Regions] Don't apply shape-inside when we have multiple auto-height regions and the height is not resolved</p> Again, change the link to the bug please: 123346
Zoltan Horvath
Comment 3 2013-11-15 09:34:24 PST
Created attachment 217057 [details] patch for land Thanks for the review Mihnea!
WebKit Commit Bot
Comment 4 2013-11-15 10:03:57 PST
Comment on attachment 217057 [details] patch for land Clearing flags on attachment: 217057 Committed r159344: <http://trac.webkit.org/changeset/159344>
WebKit Commit Bot
Comment 5 2013-11-15 10:03:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.