Bug 123748

Summary: Add accessibility search predicate support for AXOutlines
Product: WebKit Reporter: Greg Hughes <ghughes>
Component: AccessibilityAssignee: Samuel White <samuel_white>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.9   
Attachments:
Description Flags
Patch v1 -- Added a new search key ("AXOutlineSearchKey") which will return accessibility object for any trees.
none
Patch v2
cfleizach: review-
Patch. none

Greg Hughes
Reported 2013-11-04 10:58:42 PST
Add accessibility search predicate support for AXOutlines Assistive applications can use the accessibility search predicate to return tables, but clients also need the ability to return outlines. <rdar://problem/15376043>
Attachments
Patch v1 -- Added a new search key ("AXOutlineSearchKey") which will return accessibility object for any trees. (6.96 KB, patch)
2013-11-04 11:12 PST, Greg Hughes 		no flags
DetailsFormatted DiffDiff
Patch v2 (6.98 KB, patch)
2013-11-04 12:40 PST, Greg Hughes 		cfleizach: review-
DetailsFormatted DiffDiff
Patch. (6.35 KB, patch)
2014-02-25 15:18 PST, Samuel White 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-11-04 10:59:15 PST
<rdar://problem/15384578>
Greg Hughes
Comment 2 2013-11-04 11:12:45 PST
Created attachment 215934 [details] Patch v1 -- Added a new search key ("AXOutlineSearchKey") which will return accessibility object for any trees.
WebKit Commit Bot
Comment 3 2013-11-04 11:13:51 PST
Attachment 215934 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/mac/accessibility/search-predicate-expected.txt', u'LayoutTests/platform/mac/accessibility/search-predicate.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/AccessibilityObject.cpp', u'Source/WebCore/accessibility/AccessibilityObject.h', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm']" exit_code: 1 Source/WebCore/ChangeLog:3: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Greg Hughes
Comment 4 2013-11-04 12:40:45 PST
Created attachment 215944 [details] Patch v2
chris fleizach
Comment 5 2014-02-10 08:48:07 PST
Comment on attachment 215944 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=215944&action=review some minor comments, then it will be ready to go > LayoutTests/ChangeLog:6 > + Updated the accessibility-search-predicate test to include a case for outlines Period at the end of the sentence > Source/WebCore/ChangeLog:6 > + Added a new search key ("AXOutlineSearchKey") which will return accessibility object for any trees. accessibility "objects"
Samuel White
Comment 6 2014-02-25 15:18:09 PST
Created attachment 225190 [details] Patch. This is causing some serious table searching regressions and blocking a bit of work I'm doing. Cleaning up per Chris's suggestions and simplifying a bit.
WebKit Commit Bot
Comment 7 2014-02-25 17:22:27 PST
Comment on attachment 225190 [details] Patch. Clearing flags on attachment: 225190 Committed r164685: <http://trac.webkit.org/changeset/164685>
WebKit Commit Bot
Comment 8 2014-02-25 17:22:30 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.