Bug 123740

Summary: [webcore/html] remove extra header includes from cpp files.
Product: WebKit Reporter: Santosh Mahto <santosh.ma>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
ready for Landing none

Santosh Mahto
Reported 2013-11-04 07:09:29 PST
Removing redundant header files from cpp present in WebCore/html directory.
Attachments
Patch (48.68 KB, patch)
2013-11-04 07:14 PST, Santosh Mahto 		no flags
DetailsFormatted DiffDiff
Patch (48.68 KB, patch)
2013-11-04 08:39 PST, Santosh Mahto 		no flags
DetailsFormatted DiffDiff
Patch (47.70 KB, patch)
2013-11-04 09:15 PST, Santosh Mahto 		no flags
DetailsFormatted DiffDiff
ready for Landing (47.79 KB, patch)
2013-11-04 20:36 PST, Santosh Mahto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Santosh Mahto
Comment 1 2013-11-04 07:14:02 PST
Created attachment 215917 [details] Patch
Build Bot
Comment 2 2013-11-04 07:43:52 PST
Comment on attachment 215917 [details] Patch Attachment 215917 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/19618747
Build Bot
Comment 3 2013-11-04 07:54:09 PST
Comment on attachment 215917 [details] Patch Attachment 215917 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/19658797
Build Bot
Comment 4 2013-11-04 08:13:12 PST
Comment on attachment 215917 [details] Patch Attachment 215917 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/19628756
Santosh Mahto
Comment 5 2013-11-04 08:39:21 PST
Created attachment 215922 [details] Patch
Build Bot
Comment 6 2013-11-04 09:12:30 PST
Comment on attachment 215922 [details] Patch Attachment 215922 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/19638771
Santosh Mahto
Comment 7 2013-11-04 09:15:05 PST
Created attachment 215924 [details] Patch
Darin Adler
Comment 8 2013-11-04 15:27:41 PST
Comment on attachment 215924 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215924&action=review > Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:62 > -#include <runtime/Uint8ClampedArray.h> > We’re leaving an extra blank line here that we should delete. > Source/WebCore/html/shadow/MediaControlsApple.cpp:37 > -#if ENABLE(VIDEO_TRACK) > -#include "TextTrackCue.h" > -#endif > We’re leaving an extra blank line here that we should delete. > Source/WebCore/html/shadow/MediaControlsBlackBerry.cpp:41 > -#if ENABLE(VIDEO_TRACK) > -#include "TextTrackCue.h" > -#endif > We’re leaving an extra blank line here that we should delete. > Source/WebCore/html/shadow/MediaControlsGtk.cpp:34 > -#include "Chrome.h" > -#include "MouseEvent.h" > We’re leaving an extra blank line here that we should delete.
Santosh Mahto
Comment 9 2013-11-04 20:36:42 PST
Created attachment 215994 [details] ready for Landing
WebKit Commit Bot
Comment 10 2013-11-04 22:48:21 PST
Comment on attachment 215994 [details] ready for Landing Clearing flags on attachment: 215994 Committed r158650: <http://trac.webkit.org/changeset/158650>
WebKit Commit Bot
Comment 11 2013-11-04 22:48:23 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.