Bug 123740

Summary: [webcore/html] remove extra header includes from cpp files.
Product: WebKit Reporter: Santosh Mahto <santosh.ma>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
ready for Landing none

Description Santosh Mahto 2013-11-04 07:09:29 PST
Removing redundant header files from cpp present in WebCore/html directory.
Comment 1 Santosh Mahto 2013-11-04 07:14:02 PST
Created attachment 215917 [details]
Patch
Comment 2 Build Bot 2013-11-04 07:43:52 PST
Comment on attachment 215917 [details]
Patch

Attachment 215917 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/19618747
Comment 3 Build Bot 2013-11-04 07:54:09 PST
Comment on attachment 215917 [details]
Patch

Attachment 215917 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/19658797
Comment 4 Build Bot 2013-11-04 08:13:12 PST
Comment on attachment 215917 [details]
Patch

Attachment 215917 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/19628756
Comment 5 Santosh Mahto 2013-11-04 08:39:21 PST
Created attachment 215922 [details]
Patch
Comment 6 Build Bot 2013-11-04 09:12:30 PST
Comment on attachment 215922 [details]
Patch

Attachment 215922 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/19638771
Comment 7 Santosh Mahto 2013-11-04 09:15:05 PST
Created attachment 215924 [details]
Patch
Comment 8 Darin Adler 2013-11-04 15:27:41 PST
Comment on attachment 215924 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215924&action=review

> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:62
> -#include <runtime/Uint8ClampedArray.h>
>  

We’re leaving an extra blank line here that we should delete.

> Source/WebCore/html/shadow/MediaControlsApple.cpp:37
> -#if ENABLE(VIDEO_TRACK)
> -#include "TextTrackCue.h"
> -#endif
>  

We’re leaving an extra blank line here that we should delete.

> Source/WebCore/html/shadow/MediaControlsBlackBerry.cpp:41
> -#if ENABLE(VIDEO_TRACK)
> -#include "TextTrackCue.h"
> -#endif
>  

We’re leaving an extra blank line here that we should delete.

> Source/WebCore/html/shadow/MediaControlsGtk.cpp:34
> -#include "Chrome.h"
> -#include "MouseEvent.h"
>  

We’re leaving an extra blank line here that we should delete.
Comment 9 Santosh Mahto 2013-11-04 20:36:42 PST
Created attachment 215994 [details]
ready for Landing
Comment 10 WebKit Commit Bot 2013-11-04 22:48:21 PST
Comment on attachment 215994 [details]
ready for Landing

Clearing flags on attachment: 215994

Committed r158650: <http://trac.webkit.org/changeset/158650>
Comment 11 WebKit Commit Bot 2013-11-04 22:48:23 PST
All reviewed patches have been landed.  Closing bug.