Bug 123734

Summary: [sh4] Jumps in baseline JIT should return label after the jump
Product: WebKit Reporter: Julien Brianceau <jbriance>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, mark.lam, msaboff, oliver, yannick.poirier
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Refactor jumps in sh4 baseline JIT to return label after the jump. none

Description Julien Brianceau 2013-11-04 03:17:47 PST
Current implementation of jumps in sh4 baseline JIT returns a label on the jump itself and not after it.
This is not correct and leads to issues like https://bugs.webkit.org/show_bug.cgi?id=122597

Jumps for sh4 must be refactored to return labels after the jump, like other ports do (x86, arm, mips ...).
Comment 1 Julien Brianceau 2013-11-04 03:19:26 PST
*** Bug 122597 has been marked as a duplicate of this bug. ***
Comment 2 Julien Brianceau 2013-11-04 04:49:46 PST
Created attachment 215913 [details]
Refactor jumps in sh4 baseline JIT to return label after the jump.
Comment 3 WebKit Commit Bot 2013-11-04 10:19:42 PST
Comment on attachment 215913 [details]
Refactor jumps in sh4 baseline JIT to return label after the jump.

Clearing flags on attachment: 215913

Committed r158580: <http://trac.webkit.org/changeset/158580>
Comment 4 WebKit Commit Bot 2013-11-04 10:19:45 PST
All reviewed patches have been landed.  Closing bug.