Summary: | CSSPrimitiveValue color constructors should return PassRef. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||
Component: | CSS | Assignee: | Andreas Kling <kling> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, gyuyoung.kim, kling, koivisto, macpherson, menard | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Andreas Kling
2013-11-04 02:11:26 PST
Created attachment 215900 [details]
Patch
Comment on attachment 215900 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215900&action=review > Source/WebCore/css/CSSValuePool.cpp:82 > - // Just wipe out the cache and start rebuilding if it gets too big. > + // Remove one entry at random if the cache grows too large. > const int maximumColorCacheSize = 512; > - if (m_colorValueCache.size() > maximumColorCacheSize) > - m_colorValueCache.clear(); > + if (m_colorValueCache.size() >= maximumColorCacheSize) > + m_colorValueCache.remove(m_colorValueCache.begin()); Maybe the bug title should really be about this. Comment on attachment 215900 [details] Patch Clearing flags on attachment: 215900 Committed r158573: <http://trac.webkit.org/changeset/158573> All reviewed patches have been landed. Closing bug. |