Summary: | jsmin.py license header confusing, mentions non-free license | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Emilio Pozuelo Monfort <pochu27> | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | berto, cgarcia, changseok, gustavo, joepeck, mrobinson, timothy, zan | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Emilio Pozuelo Monfort
2013-11-02 08:28:18 PDT
Re-reading the header, it really sounds like it's just mentioning the original implementation's license and copyright, but in no way that would influence this implementation's license if it's a complete reimplementation from scratch without reusing any of the non-free code. Indeed, jsmin 2.0.7 from pypi[1] says: # This code is original from jsmin by Douglas Crockford, it was translated to # Python by Baruch Even. It was rewritten by Dave St.Germain for speed. # # The MIT License (MIT) # # Copyright (c) 2013 Dave St.Germain # # [ here follows the MIT license *without* the good not evil clause ] [1] https://pypi.python.org/pypi/jsmin So I suspect our current version of jsmin.py is just mentioning the orignal jsmin.c's license. Updating our jsmin.py so we have upstream's current header which is less confusing would be nice. Reassigning to webcore. Note we have two copies of this file, one in WebCore/inspector and another one in WebInspectorUI. (In reply to comment #1) > Re-reading the header, it really sounds like it's just mentioning > the original implementation's license and copyright, but in no way > that would influence this implementation's license if it's a > complete reimplementation from scratch without reusing any of the > non-free code. Yes, but it's indeed confusing. It seems that Timothy added this file in r151453, maybe he can clarify? Pulling in the latest upstream version is fine. Note: WebCore/inspector/Scripts should not be bundled into shipping resources. If it is that is a bug. Nothing in WebCore/inspector ships to customers anymore now that front-end has been removed. Also see: https://bitbucket.org/dcs/jsmin/commits/81fe577fe848a5406e6fbc36021510adac24abb0 https://bitbucket.org/dcs/jsmin/commits/4734e9d8473f750ae5dc5b236831190eee74bdad Created attachment 230999 [details] Patch (In reply to comment #4) > Pulling in the latest upstream version is fine. Ok, here it goes. I've done a clean build and everything seems normal. This version in published under the MIT/Expat license. You should build with COMBINE_INSPECTOR_RESOURCES defined. That will cause copy-user-interface-resources.pl in WebInspectorUI to call jsmin.py. Comment on attachment 230999 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230999&action=review > Source/JavaScriptCore/ChangeLog:27 > + (jsmin): > + (JavascriptMinify): > + (JavascriptMinify.__init__): > + (JavascriptMinify.minify): > + (JavascriptMinify.minify.write): > + (isAlphanum): Deleted. > + (UnterminatedComment): Deleted. > + (UnterminatedStringLiteral): Deleted. > + (UnterminatedRegularExpression): Deleted. > + (JavascriptMinify._outA): Deleted. > + (JavascriptMinify._outB): Deleted. > + (JavascriptMinify._get): Deleted. > + (JavascriptMinify._peek): Deleted. > + (JavascriptMinify._next): Deleted. > + (JavascriptMinify._action): Deleted. > + (JavascriptMinify._jsmin): Deleted. You shouldn’t leave this function list in the change log in a case like this. (In reply to comment #7) > You should build with COMBINE_INSPECTOR_RESOURCES defined. That will > cause copy-user-interface-resources.pl in WebInspectorUI to call > jsmin.py. copy-user-interface-resources.pl is not used in the GTK+ port, but I compared all other files minified by jsmin.py and the output from both versions only differs in a few whitespaces. (In reply to comment #8) > You shouldn’t leave this function list in the change log in a case > like this. You're right, I'll remove it, thanks! Committed r168523: <http://trac.webkit.org/changeset/168523> |