Summary: | [Cocoa] Add WKNSDictionary | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | mitz | ||||
Component: | WebKit2 | Assignee: | mitz | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
mitz
2013-11-02 00:59:42 PDT
Created attachment 215802 [details]
Add WKNSDictionary
Attachment 215802 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/Cocoa/APIObject.mm', u'Source/WebKit2/Shared/Cocoa/WKNSDictionary.h', u'Source/WebKit2/Shared/Cocoa/WKNSDictionary.mm', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj']" exit_code: 1
Source/WebKit2/Shared/Cocoa/WKNSDictionary.h:34: More than one command on the same line [whitespace/newline] [4]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 215802 [details] Add WKNSDictionary View in context: https://bugs.webkit.org/attachment.cgi?id=215802&action=review > Source/WebKit2/Shared/Cocoa/WKNSDictionary.mm:48 > +// -initWithObjects:forKeys:count: not implemented, because it should never be called. In debug builds, could you add an implementation with an ASSERT_NOT_REACHED? Comment on attachment 215802 [details] Add WKNSDictionary View in context: https://bugs.webkit.org/attachment.cgi?id=215802&action=review >> Source/WebKit2/Shared/Cocoa/WKNSDictionary.mm:48 >> +// -initWithObjects:forKeys:count: not implemented, because it should never be called. > > In debug builds, could you add an implementation with an ASSERT_NOT_REACHED? OK. I didn’t because NSDictionary has an implementation that raises an exception. Committed <http://trac.webkit.org/r158489>. |