Bug 123618 – [GTK] [WK2] Crash in webkitWebViewLoadFailedWithTLSErrors

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Brian Holt]

#0  mUSABLe (mem=0x1e8ee00) at malloc.c:4686
#1  __malloc_usable_size (m=0x1e8ee00) at malloc.c:3411
#2  0x00007fdf8fe50563 in ?? () from /usr/lib/nvidia-current/libGL.so.1
#3  0x00007fdf89768cc1 in ?? () from /usr/lib/nvidia-current/tls/libnvidia-tls.so.304.88
#4  0x00007fdf96457035 in webkitWebViewLoadFailedWithTLSErrors(_WebKitWebView*, char const*, _GError*, GTlsCertificateFlags, _GTlsCertificate*) ()
   from /home/user/git/WebKit/WebKitBuild/Release/.libs/libwebkit2gtk-3.0.so.25
#5  0x00007fdf9643fd32 in didFailProvisionalLoadWithErrorForFrame(OpaqueWKPage const*, OpaqueWKFrame const*, OpaqueWKError const*, void const*, void const*) ()
   from /home/user/git/WebKit/WebKitBuild/Release/.libs/libwebkit2gtk-3.0.so.25
#6  0x00007fdf964b01de in WebKit::WebLoaderClient::didFailProvisionalLoadWithErrorForFrame(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, WebCore::ResourceError const&, WebKit::APIObject*) ()
   from /home/user/git/WebKit/WebKitBuild/Release/.libs/libwebkit2gtk-3.0.so.25
#7  0x00007fdf964c4cfa in WebKit::WebPageProxy::didFailProvisionalLoadForFrame(unsigned long, WebCore::ResourceError const&, CoreIPC::MessageDecoder&) ()
   from /home/user/git/WebKit/WebKitBuild/Release/.libs/libwebkit2gtk-3.0.so.25
#8  0x00007fdf96585d4a in void CoreIPC::handleMessageVariadic<Messages::WebPageProxy::DidFailProvisionalLoadForFrame, WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(unsigned long, WebCore::ResourceError const&, CoreIPC::MessageDecoder&)>(CoreIPC::MessageDecoder&, WebKit::WebPageProxy*, void (WebKit::WebPageProxy::*)(unsigned long, WebCore::ResourceError const&, CoreIPC::MessageDecoder&)) ()
   from /home/user/git/WebKit/WebKitBuild/Release/.libs/libwebkit2gtk-3.0.so.25
#9  0x00007fdf965833f5 in WebKit::WebPageProxy::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageDecoder&) () from /home/user/git/WebKit/WebKitBuild/Release/.libs/libwebkit2gtk-3.0.so.25
#10 0x00007fdf97840845 in CoreIPC::MessageReceiverMap::dispatchMessage(CoreIPC::Connection*, CoreIPC::MessageDecoder&) () from /home/user/git/WebKit/WebKitBuild/Release/.libs/libwebkit2gtk-3.0.so.25
#11 0x00007fdf964da561 in WebKit::WebProcessProxy::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageDecoder&) () from /home/user/git/WebKit/WebKitBuild/Release/.libs/libwebkit2gtk-3.0.so.25
#12 0x00007fdf9783a48e in CoreIPC::Connection::dispatchMessage(std::unique_ptr<CoreIPC::MessageDecoder, std::default_delete<CoreIPC::MessageDecoder> >) ()
   from /home/user/git/WebKit/WebKitBuild/Release/.libs/libwebkit2gtk-3.0.so.25
#13 0x00007fdf9783a5eb in CoreIPC::Connection::dispatchOneMessage() () from /home/user/git/WebKit/WebKitBuild/Release/.libs/libwebkit2gtk-3.0.so.25
#14 0x00007fdf977202c7 in WebCore::RunLoop::performWork() () from /home/user/git/WebKit/WebKitBuild/Release/.libs/libwebkit2gtk-3.0.so.25
#15 0x00007fdf9773e509 in WebCore::RunLoop::queueWork(WebCore::RunLoop*) () from /home/user/git/WebKit/WebKitBuild/Release/.libs/libwebkit2gtk-3.0.so.25
#16 0x00007fdf93f7a2f5 in g_main_dispatch (context=0x1da0970) at gmain.c:3065
#17 g_main_context_dispatch (context=context@entry=0x1da0970) at gmain.c:3641
#18 0x00007fdf93f7a638 in g_main_context_iterate (context=0x1da0970, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimised out>) at gmain.c:3712
#19 0x00007fdf93f7aa9a in g_main_loop_run (loop=0x1dfd8c0) at gmain.c:3906
#20 0x0000000000407234 in testTLSErrorsPolicy(SSLTest*, void const*) ()
#21 0x00007fdf93f9d5e9 in test_case_run (tc=0x1df1800) at gtestutils.c:2067
#22 g_test_run_suite_internal (suite=suite@entry=0x1dcb7a0, path=path@entry=0x7fdf9401559e "") at gtestutils.c:2127
#23 0x00007fdf93f9d7ae in g_test_run_suite_internal (suite=suite@entry=0x1dcb780, path=path@entry=0x7fdf9401559e "") at gtestutils.c:2138
#24 0x00007fdf93f9d7ae in g_test_run_suite_internal (suite=suite@entry=0x1dcb760, path=path@entry=0x7fdf9401559e "") at gtestutils.c:2138
#25 0x00007fdf93f9dafb in g_test_run_suite (suite=0x1dcb760) at gtestutils.c:2189
#26 0x00000000004061c0 in main ()

[Brian Holt]

Created attachment 215733 [details]
Patch

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Mario Sanchez Prada]

Comment on attachment 215733 [details]
Patch

Good catch!

[Brian Holt]

Carlos, this should be merged back into the next release of 2.2

[Brian Holt]

(In reply to comment #4)
> Carlos, this should be merged back into the next release of 2.2

Actually, scrap that - I confused the TLS errors with authentication.  This won't need a merge because its only going to be in 2.4.

[WebKit Commit Bot]

Comment on attachment 215733 [details]
Patch

Clearing flags on attachment: 215733

Committed r158437: <http://trac.webkit.org/changeset/158437>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.