Bug 123604

Summary:

[Win] PlatformToolset should be specified in Windows build

Product:

WebKit

Reporter:

Alex Christensen <alex.christensen>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

bfulgham, commit-queue, darin, dino, kondapallykalyan, roger_fong

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 8

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
patch	none
patch	buildbot: commit-queue-

Alex Christensen

Reported 2013-10-31 17:29:54 PDT

In order to build WebKit with VS2012, I have to add this line to all the project files: <PlatformToolset>v110_xp</PlatformToolset> In our current VS2010 build, the PlatformToolset is unspecified, so it defaults to v100. To make it easier to build with VS2012 with a string replace, I'd like to specify the PlatformToolset in the projects. This doesn't seem to be able to be put into a property sheet, like the <CharacterSet>Unicode</CharacterSet> specification.

Attachments
Patch (138.31 KB, patch) 2013-10-31 17:36 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (1.25 KB, patch) 2013-10-31 19:26 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (6.17 KB, patch) 2013-11-01 09:48 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
patch (6.73 KB, patch) 2013-11-01 15:34 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
patch (141.70 KB, patch) 2013-12-07 17:13 PST, Alex Christensen	buildbot: commit-queue-	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2013-10-31 17:36:28 PDT

Created attachment 215700 [details] Patch

Alex Christensen

Comment 2 2013-10-31 19:26:20 PDT

Created attachment 215713 [details] Patch

Alex Christensen

Comment 3 2013-10-31 19:29:59 PDT

I guess this can be put into a property sheet, but not through the GUI. The second solution is *much* more elegant. Maybe we should move all the <CharacterSet>Unicode</CharacterSet> too!

Alex Christensen

Comment 4 2013-11-01 09:48:54 PDT

Created attachment 215732 [details] Patch

Alex Christensen

Comment 5 2013-11-01 15:34:17 PDT

Created attachment 215769 [details] patch

Alex Christensen

Comment 6 2013-11-01 15:59:36 PDT

There are several different ways to organize the property sheets. The last patch doesn't work for switching to VS2012. The first patch would be the most explicit. What do you think, Brent and Roger?

Brent Fulgham

Comment 7 2013-12-06 17:03:33 PST

Comment on attachment 215769 [details] patch When I apply this change, I still see the default Platform Toolset (e.g., for VS2013 this is v120). I do not see a "Platform Toolset" choice in the project. Are you sure this is actually setting the PlatformToolset?

Alex Christensen

Comment 8 2013-12-06 21:28:24 PST

I've never used VS2013, but I think the change will have to be most like the first of the patches I uploaded, except with v120 or v120_xp instead of v100. I don't have a way to verify this yet, though. We should make sure to still support Windows XP.

Alex Christensen

Comment 9 2013-12-07 17:13:46 PST

Created attachment 218671 [details] patch This doesn't have changelogs, but I think this is similar to what we'll need to do. Try it and let me know what you think.

WebKit Commit Bot

Comment 10 2013-12-08 21:03:07 PST

Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE

Build Bot

Comment 11 2013-12-08 21:45:45 PST

Comment on attachment 218671 [details] patch Attachment 218671 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/47188188

Alex Christensen

Comment 12 2013-12-16 19:29:29 PST

We updated to VS2013 instead.

Note You need to log in before you can comment on or make changes to this bug.