Bug 123595

Summary:

[CSS Shapes] Fix typo in simple-polygon.js LayoutTest helper

Product:

WebKit

Reporter:

Hans Muller <giles_joplin>

Component:

CSS

Assignee:

Hans Muller <giles_joplin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Hans Muller 2013-10-31 16:20:08 PDT

The lineHeight parameter to generatePolygonContentString() is 'lineheight'.  It should be lineHeight. 

This typo was found by SteveBlock@chromium.org - https://codereview.chromium.org/53583005/

Comment 1 Hans Muller 2013-10-31 16:25:51 PDT

Created attachment 215690 [details]
Patch

Comment 2 Darin Adler 2013-10-31 17:01:32 PDT

Comment on attachment 215690 [details]
Patch

Is this making some tests fail? If not, why not?

Comment 3 Hans Muller 2013-11-01 16:10:53 PDT

(In reply to comment #2)
> (From update of attachment 215690 [details])
> Is this making some tests fail? If not, why not?

A global called lineHeight was being set (correctly) in the test cases that used this code, so it wasn't causing any tests to fail.

Comment 4 WebKit Commit Bot 2013-11-01 16:37:05 PDT

Comment on attachment 215690 [details]
Patch

Clearing flags on attachment: 215690

Committed r158466: <http://trac.webkit.org/changeset/158466>

Comment 5 WebKit Commit Bot 2013-11-01 16:37:06 PDT

All reviewed patches have been landed.  Closing bug.