Summary: | Reproducible crash in WebCore::Settings::isJavaScriptEnabled in svg/custom/js-update-bounce.svg under guard-malloc | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Rowe (bdash) <mrowe> | ||||
Component: | New Bugs | Assignee: | Mark Rowe (bdash) <mrowe> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Major | Keywords: | LayoutTestFailure | ||||
Priority: | P1 | ||||||
Version: | 420+ | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.4 | ||||||
Attachments: |
|
Description
Mark Rowe (bdash)
2007-01-21 19:04:26 PST
Created attachment 12595 [details]
Patch
Comment on attachment 12595 [details]
Patch
Need a nil check of m_jscript which can be 0 if JavaScript was disabled or never used.
Should not have a space in Window*.
The code is inside "if (d->m_jscript && d->m_jscript->haveInterpreter())", so d->m_jscript can never be nil. Comment on attachment 12595 [details] Patch Resetting review? flag per Comment #3. Comment on attachment 12595 [details]
Patch
r=me
|