Bug 123560

Summary: [WINCE]Gif animation do not move
Product: WebKit Reporter: Zhuang Zhigang <zhuangzg>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: bfulgham, commit-queue, ossy, paroga
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Android   
Attachments:
Description Flags
a patch bfulgham: review+, commit-queue: commit-queue-

Zhuang Zhigang
Reported 2013-10-31 01:31:58 PDT
We work on wince port and found that gif do not move. We tried to find the problem. The method of CachedImage::shouldPauseAnimation returns true and causes this problem. And the reason is that in method of WebFrameLoaderClient::transitionToCommittedForNewPage of wince port, m_parentVisible is false. We check some others platform and found that m_parentVisible is true. So we tried to fix it. Later, I will upload a patch.
Attachments
a patch (1.21 KB, patch)
2013-10-31 02:14 PDT, Zhuang Zhigang 		bfulgham: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zhuang Zhigang
Comment 1 2013-10-31 02:14:41 PDT
Created attachment 215635 [details] a patch
Brent Fulgham
Comment 2 2013-10-31 09:43:33 PDT
Comment on attachment 215635 [details] a patch Seems fine to me. Bouncing to paroga.
Brent Fulgham
Comment 3 2013-11-19 17:52:13 PST
Comment on attachment 215635 [details] a patch Since paroga didn't seem to object, I'll put this through.
WebKit Commit Bot
Comment 4 2013-11-19 17:54:25 PST
Comment on attachment 215635 [details] a patch Rejecting attachment 215635 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 215635, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Working directory has changes, pass --force-clean to continue. Working directory has changes, pass --force-clean to continue. Full output: http://webkit-queues.appspot.com/results/29848010
Csaba Osztrogonác
Comment 5 2015-02-26 04:29:24 PST
There is no WinCE port long time ago.
Note You need to log in before you can comment on or make changes to this bug.