Bug 123541

Summary:

Move CSS3 text decoration implementation behind ENABLE(CSS3_TEXT_DECORATION)

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

New Bugs

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

allan.jensen, buildbot, commit-queue, dino, d-r, esprehn+autocc, glenn, gyuyoung.kim, jonlee, kondapallykalyan, macpherson, menard, rniwa, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from webkit-cq-02 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2	none
Patch	none

Myles C. Maxfield

Reported 2013-10-30 16:54:39 PDT

Move CSS3 text decoration implementation behind ENABLE(CSS3_TEXT_DECORATION)

Attachments
Patch (54.66 KB, patch) 2013-10-30 17:05 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-cq-02 for mac-mountainlion (559.49 KB, application/zip) 2013-10-30 18:20 PDT, WebKit Commit Bot	no flags	Details
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion (638.75 KB, application/zip) 2013-10-30 19:06 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (552.85 KB, application/zip) 2013-10-30 19:18 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (547.16 KB, application/zip) 2013-10-30 20:04 PDT, Build Bot	no flags	Details
Patch (104.72 KB, patch) 2013-10-31 12:35 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Myles C. Maxfield

Comment 1 2013-10-30 17:05:06 PDT

Created attachment 215579 [details] Patch

Myles C. Maxfield

Comment 2 2013-10-30 17:07:06 PDT

<rdar://problem/15345360>

WebKit Commit Bot

Comment 3 2013-10-30 18:20:56 PDT

Comment on attachment 215579 [details] Patch Rejecting attachment 215579 [details] from commit-queue. New failing tests: fast/css3-text/css3-text-decoration/text-decoration-color.html fast/css3-text/css3-text-decoration/text-decoration-line-scaled.html Full output: http://webkit-queues.appspot.com/results/17108356

WebKit Commit Bot

Comment 4 2013-10-30 18:20:58 PDT

Created attachment 215591 [details] Archive of layout-test-results from webkit-cq-02 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-02 Port: mac-mountainlion Platform: Mac OS X 10.8.4

Build Bot

Comment 5 2013-10-30 19:05:57 PDT

Comment on attachment 215579 [details] Patch Attachment 215579 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/17128373 New failing tests: fast/css3-text/css3-text-decoration/text-decoration-color.html fast/css3-text/css3-text-decoration/text-decoration-line-scaled.html

Build Bot

Comment 6 2013-10-30 19:06:01 PDT

Created attachment 215593 [details] Archive of layout-test-results from webkit-ews-07 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 7 2013-10-30 19:17:58 PDT

Comment on attachment 215579 [details] Patch Attachment 215579 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/17088399 New failing tests: fast/css3-text/css3-text-decoration/text-decoration-color.html fast/css3-text/css3-text-decoration/text-decoration-line-scaled.html

Build Bot

Comment 8 2013-10-30 19:18:01 PDT

Created attachment 215596 [details] Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 9 2013-10-30 20:04:16 PDT

Comment on attachment 215579 [details] Patch Attachment 215579 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/17088413 New failing tests: fast/css3-text/css3-text-decoration/text-decoration-color.html fast/css3-text/css3-text-decoration/text-decoration-line-scaled.html

Build Bot

Comment 10 2013-10-30 20:04:20 PDT

Created attachment 215603 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Myles C. Maxfield

Comment 11 2013-10-31 12:35:00 PDT

Created attachment 215665 [details] Patch

WebKit Commit Bot

Comment 12 2013-10-31 13:10:06 PDT

Comment on attachment 215665 [details] Patch Clearing flags on attachment: 215665 Committed r158389: <http://trac.webkit.org/changeset/158389>

WebKit Commit Bot

Comment 13 2013-10-31 13:10:11 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.