Bug 123536

Summary:

Implement ES6 Math functions

Product:

WebKit

Reporter:

Oliver Hunt <oliver>

Component:

New Bugs

Assignee:

Oliver Hunt <oliver>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, buildbot, cmarcelo, commit-queue, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2	none
Patch	none
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion	none
Patch	msaboff: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion	none

Oliver Hunt

Reported 2013-10-30 15:54:17 PDT

Implement ES6 Math functions

Attachments
Patch (20.95 KB, patch) 2013-10-30 15:59 PDT, Oliver Hunt	no flags	Details Formatted Diff Diff
Patch (21.06 KB, patch) 2013-10-30 16:46 PDT, Oliver Hunt	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (448.95 KB, application/zip) 2013-10-30 17:43 PDT, Build Bot	no flags	Details
Patch (22.48 KB, patch) 2013-10-30 18:10 PDT, Oliver Hunt	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (552.74 KB, application/zip) 2013-10-30 19:26 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (459.06 KB, application/zip) 2013-10-30 20:42 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (564.15 KB, application/zip) 2013-10-30 21:33 PDT, Build Bot	no flags	Details
Patch (22.47 KB, patch) 2013-10-30 21:39 PDT, Oliver Hunt	msaboff: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (450.28 KB, application/zip) 2013-10-30 22:55 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion (516.17 KB, application/zip) 2013-10-31 00:25 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (622.64 KB, application/zip) 2013-10-31 01:26 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (493.04 KB, application/zip) 2013-10-31 01:52 PDT, Build Bot	no flags	Details
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Oliver Hunt

Comment 1 2013-10-30 15:59:26 PDT

Created attachment 215568 [details] Patch

Build Bot

Comment 2 2013-10-30 16:39:30 PDT

Comment on attachment 215568 [details] Patch Attachment 215568 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/17058316

Oliver Hunt

Comment 3 2013-10-30 16:46:00 PDT

Created attachment 215573 [details] Patch

Build Bot

Comment 4 2013-10-30 17:28:45 PDT

Comment on attachment 215573 [details] Patch Attachment 215573 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/17068362

Build Bot

Comment 5 2013-10-30 17:43:25 PDT

Comment on attachment 215573 [details] Patch Attachment 215573 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/17128362 New failing tests: js/math.html

Build Bot

Comment 6 2013-10-30 17:43:26 PDT

Created attachment 215586 [details] Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Oliver Hunt

Comment 7 2013-10-30 18:10:39 PDT

Created attachment 215589 [details] Patch

Build Bot

Comment 8 2013-10-30 19:26:58 PDT

Comment on attachment 215589 [details] Patch Attachment 215589 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/17088400 New failing tests: js/math.html

Build Bot

Comment 9 2013-10-30 19:26:59 PDT

Created attachment 215598 [details] Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 10 2013-10-30 20:42:23 PDT

Comment on attachment 215589 [details] Patch Attachment 215589 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/17108386 New failing tests: js/math.html

Build Bot

Comment 11 2013-10-30 20:42:25 PDT

Created attachment 215607 [details] Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 12 2013-10-30 21:33:36 PDT

Comment on attachment 215589 [details] Patch Attachment 215589 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/17778073 New failing tests: js/math.html

Build Bot

Comment 13 2013-10-30 21:33:38 PDT

Created attachment 215611 [details] Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Oliver Hunt

Comment 14 2013-10-30 21:39:50 PDT

Created attachment 215612 [details] Patch

Build Bot

Comment 15 2013-10-30 22:55:27 PDT

Comment on attachment 215612 [details] Patch Attachment 215612 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/17088449 New failing tests: js/math.html

Build Bot

Comment 16 2013-10-30 22:55:29 PDT

Created attachment 215618 [details] Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 17 2013-10-31 00:25:32 PDT

Comment on attachment 215612 [details] Patch Attachment 215612 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/17788135 New failing tests: js/math.html

Build Bot

Comment 18 2013-10-31 00:25:34 PDT

Created attachment 215625 [details] Archive of layout-test-results from webkit-ews-03 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 19 2013-10-31 01:26:52 PDT

Comment on attachment 215612 [details] Patch Attachment 215612 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/17758123 New failing tests: js/math.html

Build Bot

Comment 20 2013-10-31 01:26:54 PDT

Created attachment 215628 [details] Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 21 2013-10-31 01:52:23 PDT

Comment on attachment 215612 [details] Patch Attachment 215612 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/17928002 New failing tests: js/math.html

Build Bot

Comment 22 2013-10-31 01:52:25 PDT

Created attachment 215631 [details] Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Michael Saboff

Comment 23 2013-10-31 15:01:17 PDT

Comment on attachment 215612 [details] Patch r=me, but fix the test failure (the result of Math.log1p(-0) should be -0.

Oliver Hunt

Comment 24 2013-10-31 15:36:23 PDT

Committed r158401: <http://trac.webkit.org/changeset/158401>

Geoffrey Garen

Comment 25 2016-03-14 12:52:06 PDT

*** Bug 131709 has been marked as a duplicate of this bug. ***

Geoffrey Garen

Comment 26 2016-03-14 12:53:43 PDT

*** Bug 131710 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.