Bug 123528

Summary: Teach the style checker about ENUM_CLASS
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, commit-queue, glenn, mitz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch none

Alexey Proskuryakov
Reported 2013-10-30 13:47:35 PDT
Complaints in <https://bugs.webkit.org/show_bug.cgi?id=123462#c4> were wrong.
Attachments
proposed patch (6.29 KB, patch)
2013-10-30 16:25 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2013-10-30 16:25:22 PDT
Created attachment 215570 [details] proposed patch
Andy Estes
Comment 2 2013-10-30 17:01:44 PDT
Comment on attachment 215570 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=215570&action=review r=me > Tools/Scripts/webkitpy/style/checkers/cpp.py:1196 > + expr_enum_start = r'\s*(?:enum(?:\s+[a-zA-Z0-9]+)?|ENUM_CLASS\s*\([a-zA-Z0-9]+\))\s*\{?\s*' Does the ([a-zA-Z0-9]+\) need to be non-capturing? Not sure it matters since only named groups are used.
Alexey Proskuryakov
Comment 3 2013-10-30 19:24:56 PDT
It's not a group - the parentheses are escaped :)
Andy Estes
Comment 4 2013-10-30 20:34:55 PDT
(In reply to comment #3) > It's not a group - the parentheses are escaped :) Indeed :/
WebKit Commit Bot
Comment 5 2013-10-30 21:09:20 PDT
Comment on attachment 215570 [details] proposed patch Clearing flags on attachment: 215570 Committed r158342: <http://trac.webkit.org/changeset/158342>
WebKit Commit Bot
Comment 6 2013-10-30 21:09:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.