Bug 123517

Summary: Remote Layer Tree: Lots of ASSERT(m_children.isEmpty()); on Poster Circle
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebKit2Assignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
no reason not to fold it into the existing loop simon.fraser: review+

Tim Horton
Reported 2013-10-30 11:12:02 PDT
A recently added assertion discovered a bug where our dependence on undefined behavior in CA was causing the layer tree to get into a bad state. We depend on adding a sublayer which already has a parent to another layer, the sublayer is first removed from its parent layer. CA headers say this is undefined behavior (that layers should always have a nil superlayer when being added as a sublayer), but we heavily depend on it being the case. Most of PlatformCALayerRemote behaved correctly, but setSublayers() failed to unparent the incoming layers.
Attachments
patch (1.35 KB, patch)
2013-10-30 11:14 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
no reason not to fold it into the existing loop (1.43 KB, patch)
2013-10-30 11:50 PDT, Tim Horton 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2013-10-30 11:14:17 PDT
Created attachment 215533 [details] patch
Tim Horton
Comment 2 2013-10-30 11:50:24 PDT
Created attachment 215542 [details] no reason not to fold it into the existing loop
Tim Horton
Comment 3 2013-10-30 11:58:06 PDT
http://trac.webkit.org/changeset/158297
Note You need to log in before you can comment on or make changes to this bug.