Bug 123464 – Node shouldn't be selected if it's not a draggable element and has -webkit-user-select: none set

• Component: DOM
• Status: UNCONFIRMED

[Crystal Zhang]

As the comment says, if it's a draggable element, then it should be allowed to be selected, so drag & drop action can be performed, if it's not, and has -webkit-user-select: none set, then it shouldn't be allowed.

[Crystal Zhang]

Created attachment 215425 [details]
patch

patch.

[Crystal Zhang]

Add Antonio to cc list.

[Crystal Zhang]

Comment on attachment 215425 [details]
patch

Need have a second thought.

[Ahmad Saleem]

This patch was modifying this:

https://searchfox.org/wubkat/rev/3f1a725ef3d3f0a0ee05b56aff41fbfdae90f34f/Source/WebCore/dom/Node.cpp#1288

- It seems blink did the change:

https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/dom/node.cc;l=1654;drc=5180d4deb2bee0cc22d14ced5ac540e51135a2e5

** Blink:

    // We allow selections to begin within |user-select: text/all| sub trees
    // but not if the element is draggable.
    if (style.UserDrag() != EUserDrag::kElement &&
        (user_select == EUserSelect::kText || user_select == EUserSelect::kAll))
      return true;

** WebKit:

        // We allow selections to begin within an element that has -webkit-user-select: none set,
        // but if the element is draggable then dragging should take priority over selection.
        if (style.userDrag() == UserDrag::Element && style.usedUserSelect() == UserSelect::None)
            return false;
    }

__