Bug 123462

Summary:

Beef up CryptoKey

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

WebCore Misc.

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, esprehn+autocc, kondapallykalyan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

122679

Attachments:

Description	Flags
proposed patch	none
with appropriate style fixes	sam: review+

Description Alexey Proskuryakov 2013-10-29 13:37:24 PDT

A bit of glue code to add here...

Comment 1 Alexey Proskuryakov 2013-10-29 13:47:19 PDT

Created attachment 215417 [details]
proposed patch

Comment 2 WebKit Commit Bot 2013-10-29 13:50:08 PDT

Attachment 215417 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/crypto/CryptoAlgorithmIdentifier.h', u'Source/WebCore/crypto/CryptoKey.cpp', u'Source/WebCore/crypto/CryptoKey.h', u'Source/WebCore/crypto/CryptoKey.idl', u'Source/WebCore/crypto/CryptoKeyFormat.h', u'Source/WebCore/crypto/CryptoKeyType.h', u'Source/WebCore/crypto/CryptoKeyUsage.h']" exit_code: 1
Source/WebCore/crypto/CryptoKey.h:42:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/crypto/CryptoKeyFormat.h:33:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/crypto/CryptoKeyUsage.h:34:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/crypto/CryptoKeyUsage.h:35:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/crypto/CryptoKeyUsage.h:36:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/crypto/CryptoKeyUsage.h:37:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/crypto/CryptoKeyUsage.h:38:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/crypto/CryptoKeyUsage.h:39:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/crypto/CryptoKeyUsage.h:40:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/crypto/CryptoKeyUsage.h:41:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/crypto/CryptoKeyType.h:33:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/crypto/CryptoAlgorithmIdentifier.h:33:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 12 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Alexey Proskuryakov 2013-10-29 13:52:23 PDT

Created attachment 215420 [details]
with appropriate style fixes

Also, don't add JSDOMPromise to project yet, it's not in this patch.

Comment 4 WebKit Commit Bot 2013-10-29 13:53:26 PDT

Attachment 215420 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/crypto/CryptoAlgorithmIdentifier.h', u'Source/WebCore/crypto/CryptoKey.cpp', u'Source/WebCore/crypto/CryptoKey.h', u'Source/WebCore/crypto/CryptoKey.idl', u'Source/WebCore/crypto/CryptoKeyFormat.h', u'Source/WebCore/crypto/CryptoKeyType.h', u'Source/WebCore/crypto/CryptoKeyUsage.h']" exit_code: 1
Source/WebCore/crypto/CryptoKey.h:42:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/crypto/CryptoKeyFormat.h:33:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/crypto/CryptoKeyType.h:33:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/crypto/CryptoAlgorithmIdentifier.h:33:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 4 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 Alexey Proskuryakov 2013-10-29 16:11:22 PDT

Committed <http://trac.webkit.org/r158236>.

Comment 6 Alexey Proskuryakov 2013-10-29 16:31:39 PDT

And a build fix in <http://trac.webkit.org/r158239>