Bug 123460

Summary: REGRESSION(r158198): editing/execCommand/insert-list-xml.xhtml fails
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, dino, rniwa
Priority: P2 Keywords: LayoutTestFailure
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch rniwa: review+

Ryosuke Niwa
Reported 2013-10-29 12:49:53 PDT
http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=editing%2FexecCommand%2Finsert-list-xml.xhtml e.g. http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r158206%20(14254)/results.html --- /Volumes/Data/slave/mountainlion-release-tests-wk1/build/layout-test-results/editing/execCommand/insert-list-xml-expected.txt +++ /Volumes/Data/slave/mountainlion-release-tests-wk1/build/layout-test-results/editing/execCommand/insert-list-xml-actual.txt @@ -1,3 +1 @@ -. -<div xmlns="http://www.w3.org/1999/xhtml" contenteditable="true" id="insertlisthere"><ol><li>.<br /></li></ol></div> -PASS +
Attachments
Patch (2.15 KB, patch)
2013-10-29 17:29 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (2.75 KB, patch)
2013-10-29 17:38 PDT, Brent Fulgham 		rniwa: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-10-29 13:28:54 PDT
Added test expectation in http://trac.webkit.org/changeset/158216
Brent Fulgham
Comment 2 2013-10-29 14:03:41 PDT
This test is failing because I modified the MathML logic to refuse to emit renderers for non-MathML nodes. This is intended to satisfy the behavior described by the MathML 3.0 specification. This test needs to change from using MathML as the enclosing document root, to something like SVG that accepts internal nodes of HTML types.
Brent Fulgham
Comment 3 2013-10-29 14:05:03 PDT
The change that "broke" this test is https://bugs.webkit.org/show_bug.cgi?id=121728.
Brent Fulgham
Comment 4 2013-10-29 15:15:51 PDT
The test was added as part of http://trac.webkit.org/changeset/55167/trunk/WebCore/ChangeLog. We want to make sure that changing the test to use SVG instead of MathML still exercises the code that had previously caused a bad cast.
Brent Fulgham
Comment 5 2013-10-29 17:29:37 PDT
Created attachment 215453 [details] Patch
Brent Fulgham
Comment 6 2013-10-29 17:38:30 PDT
Created attachment 215455 [details] Patch
Brent Fulgham
Comment 7 2013-10-29 17:56:51 PDT
Committed r158242: <http://trac.webkit.org/changeset/158242>
Note You need to log in before you can comment on or make changes to this bug.