Bug 123442

Summary: Buildfix after r158182 for GCC 4.6
Product: WebKit Reporter: Berta József <jberta.u-szeged>
Component: WebCore Misc.Assignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, darin, esprehn+autocc, kangil.han, ossy, piotr.grad, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Berta József
Reported 2013-10-29 05:53:28 PDT
Added explicit "friend class", because GCC 4.6 doesn't support extended friend declaration (c++11)
Attachments
Patch (1.13 KB, patch)
2013-10-29 06:09 PDT, Berta József 		no flags
DetailsFormatted DiffDiff
Patch (1.29 KB, patch)
2013-10-29 07:45 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (1.30 KB, patch)
2013-10-29 08:23 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Berta József
Comment 1 2013-10-29 06:09:56 PDT
Created attachment 215382 [details] Patch
Build Bot
Comment 2 2013-10-29 06:51:08 PDT
Comment on attachment 215382 [details] Patch Attachment 215382 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/17068097
Csaba Osztrogonác
Comment 3 2013-10-29 07:45:40 PDT
Created attachment 215387 [details] Patch with speculative fix for Windows EWS
Csaba Osztrogonác
Comment 4 2013-10-29 08:23:42 PDT
Created attachment 215390 [details] Patch one more attempt to make MSVC happy
Build Bot
Comment 5 2013-10-29 08:25:30 PDT
Comment on attachment 215387 [details] Patch Attachment 215387 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/17118106
Csaba Osztrogonác
Comment 6 2013-10-29 08:38:50 PDT
It seems it is a crazy MSVC bug, see https://bugs.webkit.org/show_bug.cgi?id=121883#c26 for details.
Zan Dobersek
Comment 7 2013-10-29 08:59:59 PDT
Could making the ScopedEventQueue destructor public help?
Csaba Osztrogonác
Comment 8 2013-10-29 09:01:24 PDT
Hehe, we got it: friend class WTF::NeverDestroyed<WebCore::ScopedEventQueue>;
Csaba Osztrogonác
Comment 9 2013-11-04 04:11:24 PST
*** Bug 123733 has been marked as a duplicate of this bug. ***
Csaba Osztrogonác
Comment 10 2013-11-04 04:15:17 PST
Committed r158566: <http://trac.webkit.org/changeset/158566>
Note You need to log in before you can comment on or make changes to this bug.