Bug 123442

Summary: Buildfix after r158182 for GCC 4.6
Product: WebKit Reporter: Berta József <jberta.u-szeged>
Component: WebCore Misc.Assignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, darin, esprehn+autocc, kangil.han, ossy, piotr.grad, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Berta József 2013-10-29 05:53:28 PDT 
Added explicit "friend class", because  GCC 4.6 doesn't support extended friend declaration (c++11)
Comment 1 Berta József 2013-10-29 06:09:56 PDT 
Created attachment 215382 [details]
Patch
Comment 2 Build Bot 2013-10-29 06:51:08 PDT 
Comment on attachment 215382 [details]
Patch

Attachment 215382 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/17068097
Comment 3 Csaba Osztrogonác 2013-10-29 07:45:40 PDT 
Created attachment 215387 [details]
Patch

with speculative fix for Windows EWS
Comment 4 Csaba Osztrogonác 2013-10-29 08:23:42 PDT 
Created attachment 215390 [details]
Patch

one more attempt to make MSVC happy
Comment 5 Build Bot 2013-10-29 08:25:30 PDT 
Comment on attachment 215387 [details]
Patch

Attachment 215387 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/17118106
Comment 6 Csaba Osztrogonác 2013-10-29 08:38:50 PDT 
It seems it is a crazy MSVC bug, see https://bugs.webkit.org/show_bug.cgi?id=121883#c26 for details.
Comment 7 Zan Dobersek 2013-10-29 08:59:59 PDT 
Could making the ScopedEventQueue destructor public help?
Comment 8 Csaba Osztrogonác 2013-10-29 09:01:24 PDT 
Hehe, we got it:
friend class WTF::NeverDestroyed<WebCore::ScopedEventQueue>;
Comment 9 Csaba Osztrogonác 2013-11-04 04:11:24 PST 
*** Bug 123733 has been marked as a duplicate of this bug. ***
Comment 10 Csaba Osztrogonác 2013-11-04 04:15:17 PST 
Committed r158566: <http://trac.webkit.org/changeset/158566>