Bug 123438

Summary: [GStreamer] Adopt nullptr
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, commit-queue, vjaquez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Philippe Normand
Reported 2013-10-29 01:24:11 PDT
All call sites using 0 or NULL should use nullptr. The code style checker gst* exceptions need to be removed as well.
Attachments
Patch (44.41 KB, patch)
2017-02-22 14:09 PST, Vanessa Chipirrás Navalón 		no flags
DetailsFormatted DiffDiff
Patch (45.89 KB, patch)
2017-02-23 09:58 PST, Vanessa Chipirrás Navalón 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vanessa Chipirrás Navalón
Comment 1 2017-02-22 14:09:22 PST
Created attachment 302440 [details] Patch
Xabier Rodríguez Calvar
Comment 2 2017-02-23 02:18:52 PST
Comment on attachment 302440 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302440&action=review > Source/WebCore/ChangeLog:10 > + The per-file and per-function explanations are left blank because the change is very simple, > + so there's no need to explain it once per source file. You don't need this explanation. The first line is enough. > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1180 > + processTableOfContentsEntry(static_cast<GstTocEntry*>(i->data), nullptr); The null argument of this function is unused and it does not take part of any API inside WebKit so I'd say we remove it from the calls and from the declaration. Obviously, the UNUSED_PARAM would be useless too.
Vanessa Chipirrás Navalón
Comment 3 2017-02-23 09:58:28 PST
Created attachment 302524 [details] Patch
WebKit Commit Bot
Comment 4 2017-03-06 02:33:01 PST
Comment on attachment 302524 [details] Patch Clearing flags on attachment: 302524 Committed r213445: <http://trac.webkit.org/changeset/213445>
WebKit Commit Bot
Comment 5 2017-03-06 02:33:04 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.