[GStreamer] Adopt nullptr

• Component: Platform
• Status: RESOLVED FIXED

[Philippe Normand]

All call sites using 0 or NULL should use nullptr. The code style checker gst* exceptions need to be removed as well.

[Vanessa Chipirrás Navalón]

Created attachment 302440 [details]
Patch

[Xabier Rodríguez Calvar]

Comment on attachment 302440 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302440&action=review

> Source/WebCore/ChangeLog:10
> +        The per-file and per-function explanations are left blank because the change is very simple,
> +        so there's no need to explain it once per source file.

You don't need this explanation. The first line is enough.

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1180
> +        processTableOfContentsEntry(static_cast<GstTocEntry*>(i->data), nullptr);

The null argument of this function is unused and it does not take part of any API inside WebKit so I'd say we remove it from the calls and from the declaration. Obviously, the UNUSED_PARAM would be useless too.

[Vanessa Chipirrás Navalón]

Created attachment 302524 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 302524 [details]
Patch

Clearing flags on attachment: 302524

Committed r213445: <http://trac.webkit.org/changeset/213445>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.