Bug 123431
Summary: | Linked stylesheet loading order tests fail on Mac WK2 | ||
---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
Status: | NEW | ||
Severity: | Normal | CC: | ap, beidson, dbates, fujii.hironori, koivisto, simon.fraser |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=97179 https://bugs.webkit.org/show_bug.cgi?id=139489 |
Simon Fraser (smfr)
These tests fail on Mavericks WK2:
http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html
http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html
http/tests/local/link-stylesheet-load-order-preload.html
http/tests/local/link-stylesheet-load-order.html
http://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK2%20(Tests)/r158145%20(81)/results.html
I'll mark them as such.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
Failing on Yosemite too - presumably because we still drop all resource load scheduling on the floor.
Simon Fraser (smfr)
> drop all resource load scheduling on the floor
What does this refer to? Is there a bug tracking it?
Alexey Proskuryakov
See bug 144550, where all the code for resource load scheduling was removed (but it didn't work before that either).
I'm not sure how to track that with a bug, given that there is no hard data showing that this affects performance.
Fujii Hironori
269753@main changed the test a bit.
Here is the new failure diff.
https://build.webkit.org/results/Apple-Monterey-Release-AppleSilicon-WK2-Tests/269760@main%20(11770)/http/tests/css/link-css-disabled-value-with-slow-loading-sheet-diff.txt
--- /Volumes/Data/worker/Apple-Monterey-Release-AppleSilicon-WK2-Tests/build/layout-test-results/http/tests/css/link-css-disabled-value-with-slow-loading-sheet-expected.txt
+++ /Volumes/Data/worker/Apple-Monterey-Release-AppleSilicon-WK2-Tests/build/layout-test-results/http/tests/css/link-css-disabled-value-with-slow-loading-sheet-actual.txt
@@ -5,7 +5,7 @@
--- /Volumes/Data/worker/Apple-Monterey-Release-AppleSilicon-WK2-Tests/build/layout-test-results/http/tests/css/link-css-disabled-value-with-slow-loading-sheet-expected.txt
+++ /Volumes/Data/worker/Apple-Monterey-Release-AppleSilicon-WK2-Tests/build/layout-test-results/http/tests/css/link-css-disabled-value-with-slow-loading-sheet-actual.txt
@@ -5,7 +5,7 @@
Testing value of 'disabled' prior to load just after setting them
PASS mainSheetLink.sheet is null
-PASS alternateSheetLink.sheet is non-null.
+FAIL alternateSheetLink.sheet should be non-null. Was null
PASS mainSheetLink.disabled is true
PASS alternateSheetLink.disabled is false
Testing the values when the alternate sheet is loaded (as this is the only one that has sheet() === null)
Fujii Hironori
269803@main (bug#263679) removed the following obsolete tests.
http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html
http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html
The following tests are still failing.
http/tests/local/link-stylesheet-load-order-preload.html
http/tests/local/link-stylesheet-load-order.html
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=http%2Ftests%2Flocal%2Flink-stylesheet-load-order-preload.html&test=http%2Ftests%2Flocal%2Flink-stylesheet-load-order.html