Bug 123429

Summary:

Add tooltips to the platform icons in Dashboard

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, simon.fraser, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ap: review+, ap: commit-queue-

Simon Fraser (smfr)

Reported 2013-10-28 17:58:45 PDT

Add tooltips to the platform icons in Dashboard

Attachments
Patch (3.52 KB, patch) 2013-10-28 17:59 PDT, Simon Fraser (smfr)	ap: review+ ap: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2013-10-28 17:59:32 PDT

Created attachment 215356 [details] Patch

Alexey Proskuryakov

Comment 2 2013-10-28 18:28:26 PDT

Comment on attachment 215356 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215356&action=review r=me I would personally prefer the text to be just always visible, but even a tooltip is an improvement. > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:44 > + MacOSXMavericks: { name: "mac-os-x-mavericks", readablename: "Mac OS X Mavericks", order: 10 }, Does "readablename" match the style in this file? Should be readableName otherwise. Please remove "Mac", it's just "OS X Mavericks". > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:46 > + MacOSXMountainLion: { name: "mac-os-x-mountain-lion", readablename: "Mac OS X MountainLion", order: 20 }, > + MacOSXLion: { name : "mac-os-x-lion", readablename: "Mac OS X MountainLion", order: 30 }, Please add a space in "Mountain Lion", and remove "Mac".

Simon Fraser (smfr)

Comment 3 2013-11-08 11:29:21 PST

http://trac.webkit.org/changeset/158151

Note You need to log in before you can comment on or make changes to this bug.