Bug 123407

Summary: RunLoop::dispatch should take an std::function
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+

Anders Carlsson
Reported 2013-10-28 09:16:30 PDT
RunLoop::dispatch should take an std::function
Attachments
Patch (4.28 KB, patch)
2013-10-28 09:17 PDT, Anders Carlsson 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-10-28 09:17:19 PDT
Created attachment 215312 [details] Patch
Andreas Kling
Comment 2 2013-10-28 09:18:46 PDT
Comment on attachment 215312 [details] Patch Sweet!
WebKit Commit Bot
Comment 3 2013-10-28 09:19:38 PDT
Attachment 215312 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/FunctionDispatcher.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/platform/RunLoop.cpp', u'Source/WebCore/platform/RunLoop.h']" exit_code: 1 Source/WebCore/platform/RunLoop.cpp:123: Extra space before ( in function call [whitespace/parens] [4] Source/WebCore/platform/RunLoop.h:60: Extra space before ( in function call [whitespace/parens] [4] Source/WebCore/platform/RunLoop.h:136: Extra space before ( in function call [whitespace/parens] [4] Source/WTF/wtf/FunctionDispatcher.h:38: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 4 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 4 2013-10-28 13:09:13 PDT
Committed r158123: <http://trac.webkit.org/changeset/158123>
Note You need to log in before you can comment on or make changes to this bug.