Bug 123401

Summary: RenderElement::m_style should be a Ref.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, eflews.bot, esprehn+autocc, glenn, gyuyoung.kim, kling, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch koivisto: review+, eflews.bot: commit-queue-

Andreas Kling
Reported 2013-10-28 06:42:10 PDT
m_style can not be null, so let's enforce this at compile-time.
Attachments
Patch (7.08 KB, patch)
2013-10-28 06:49 PDT, Andreas Kling 		koivisto: review+
eflews.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-10-28 06:49:50 PDT
Created attachment 215300 [details] Patch
Antti Koivisto
Comment 2 2013-10-28 06:56:38 PDT
Comment on attachment 215300 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215300&action=review > Source/WebCore/rendering/RenderElement.cpp:415 > + Ref<RenderStyle> oldStyle(std::move(style)); > + m_style.swap(oldStyle); It is bit misleading that you put the new style to a variable called oldStyle. Might API that would work like Ref<RenderStyle> oldStyle(m_style.swap(std::move(style))) be better?
EFL EWS Bot
Comment 3 2013-10-28 07:44:52 PDT
Comment on attachment 215300 [details] Patch Attachment 215300 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/15558149
Andreas Kling
Comment 4 2013-10-28 08:47:06 PDT
Committed r158111: <http://trac.webkit.org/changeset/158111>
Note You need to log in before you can comment on or make changes to this bug.