Bug 123401

Summary: RenderElement::m_style should be a Ref.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Severity: Normal CC: benjamin, cmarcelo, commit-queue, eflews.bot, esprehn+autocc, glenn, gyuyoung.kim, kling, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch koivisto: review+, eflews.bot: commit-queue-

Description Andreas Kling 2013-10-28 06:42:10 PDT
m_style can not be null, so let's enforce this at compile-time.
Comment 1 Andreas Kling 2013-10-28 06:49:50 PDT
Created attachment 215300 [details]
Comment 2 Antti Koivisto 2013-10-28 06:56:38 PDT
Comment on attachment 215300 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=215300&action=review

> Source/WebCore/rendering/RenderElement.cpp:415
> +    Ref<RenderStyle> oldStyle(std::move(style));
> +    m_style.swap(oldStyle);

It is bit misleading that you put the new style to a variable called oldStyle. Might API that would work like

Ref<RenderStyle> oldStyle(m_style.swap(std::move(style)))

be better?
Comment 3 EFL EWS Bot 2013-10-28 07:44:52 PDT
Comment on attachment 215300 [details]

Attachment 215300 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/15558149
Comment 4 Andreas Kling 2013-10-28 08:47:06 PDT
Committed r158111: <http://trac.webkit.org/changeset/158111>