Bug 123396

Summary:

Renderers should receive their style at construction.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Layout and Rendering

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, kling, koivisto, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Snack for EWS	buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion	none
Second snack for EWS	none
Patch	koivisto: review+

Andreas Kling

Reported 2013-10-27 07:41:51 PDT

There's a small window of time between RenderElement construction and the first call to setStyle() where the renderer has a null style. Getting rid of this window will open up new opportunities for optimization and restructuring of data.

Attachments
Snack for EWS (274.26 KB, patch) 2013-10-27 07:44 PDT, Andreas Kling	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion (1.11 MB, application/zip) 2013-10-27 09:15 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (1.10 MB, application/zip) 2013-10-27 10:13 PDT, Build Bot	no flags	Details
Second snack for EWS (275.36 KB, patch) 2013-10-27 12:06 PDT, Andreas Kling	no flags	Details Formatted Diff Diff
Patch (277.94 KB, patch) 2013-10-27 14:22 PDT, Andreas Kling	koivisto: review+	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Andreas Kling

Comment 1 2013-10-27 07:44:08 PDT

Created attachment 215270 [details] Snack for EWS

WebKit Commit Bot

Comment 2 2013-10-27 07:46:17 PDT

Attachment 215270 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/dom/Element.h', u'Source/WebCore/html/BaseButtonInputType.cpp', u'Source/WebCore/html/BaseButtonInputType.h', u'Source/WebCore/html/FileInputType.cpp', u'Source/WebCore/html/FileInputType.h', u'Source/WebCore/html/HTMLAppletElement.cpp', u'Source/WebCore/html/HTMLAppletElement.h', u'Source/WebCore/html/HTMLBRElement.cpp', u'Source/WebCore/html/HTMLBRElement.h', u'Source/WebCore/html/HTMLButtonElement.cpp', u'Source/WebCore/html/HTMLButtonElement.h', u'Source/WebCore/html/HTMLCanvasElement.cpp', u'Source/WebCore/html/HTMLCanvasElement.h', u'Source/WebCore/html/HTMLDetailsElement.cpp', u'Source/WebCore/html/HTMLDetailsElement.h', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLElement.h', u'Source/WebCore/html/HTMLFieldSetElement.cpp', u'Source/WebCore/html/HTMLFieldSetElement.h', u'Source/WebCore/html/HTMLFrameElement.cpp', u'Source/WebCore/html/HTMLFrameElement.h', u'Source/WebCore/html/HTMLFrameSetElement.cpp', u'Source/WebCore/html/HTMLFrameSetElement.h', u'Source/WebCore/html/HTMLIFrameElement.cpp', u'Source/WebCore/html/HTMLIFrameElement.h', u'Source/WebCore/html/HTMLImageElement.cpp', u'Source/WebCore/html/HTMLImageElement.h', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HTMLInputElement.h', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/HTMLMediaElement.h', u'Source/WebCore/html/HTMLMeterElement.cpp', u'Source/WebCore/html/HTMLMeterElement.h', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.h', u'Source/WebCore/html/HTMLProgressElement.cpp', u'Source/WebCore/html/HTMLProgressElement.h', u'Source/WebCore/html/HTMLSelectElement.cpp', u'Source/WebCore/html/HTMLSelectElement.h', u'Source/WebCore/html/HTMLSummaryElement.cpp', u'Source/WebCore/html/HTMLSummaryElement.h', u'Source/WebCore/html/HTMLTextAreaElement.cpp', u'Source/WebCore/html/HTMLTextAreaElement.h', u'Source/WebCore/html/HTMLVideoElement.cpp', u'Source/WebCore/html/HTMLVideoElement.h', u'Source/WebCore/html/HiddenInputType.cpp', u'Source/WebCore/html/HiddenInputType.h', u'Source/WebCore/html/ImageInputType.cpp', u'Source/WebCore/html/ImageInputType.h', u'Source/WebCore/html/InputType.cpp', u'Source/WebCore/html/InputType.h', u'Source/WebCore/html/RangeInputType.cpp', u'Source/WebCore/html/RangeInputType.h', u'Source/WebCore/html/SearchInputType.cpp', u'Source/WebCore/html/SearchInputType.h', u'Source/WebCore/html/TextFieldInputType.cpp', u'Source/WebCore/html/TextFieldInputType.h', u'Source/WebCore/html/shadow/DetailsMarkerControl.cpp', u'Source/WebCore/html/shadow/DetailsMarkerControl.h', u'Source/WebCore/html/shadow/MediaControlElements.cpp', u'Source/WebCore/html/shadow/MediaControlElements.h', u'Source/WebCore/html/shadow/MeterShadowElement.cpp', u'Source/WebCore/html/shadow/MeterShadowElement.h', u'Source/WebCore/html/shadow/ProgressShadowElement.cpp', u'Source/WebCore/html/shadow/ProgressShadowElement.h', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.h', u'Source/WebCore/html/shadow/TextControlInnerElements.cpp', u'Source/WebCore/html/shadow/TextControlInnerElements.h', u'Source/WebCore/html/track/TextTrackCue.cpp', u'Source/WebCore/html/track/TextTrackCue.h', u'Source/WebCore/loader/icon/IconDatabase.cpp', u'Source/WebCore/mathml/MathMLInlineContainerElement.cpp', u'Source/WebCore/mathml/MathMLInlineContainerElement.h', u'Source/WebCore/mathml/MathMLMathElement.cpp', u'Source/WebCore/mathml/MathMLMathElement.h', u'Source/WebCore/mathml/MathMLTextElement.cpp', u'Source/WebCore/mathml/MathMLTextElement.h', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/animation/AnimationController.cpp', u'Source/WebCore/rendering/FlowThreadController.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBlockFlow.cpp', u'Source/WebCore/rendering/RenderBlockFlow.h', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderBox.h', u'Source/WebCore/rendering/RenderBoxModelObject.cpp', u'Source/WebCore/rendering/RenderBoxModelObject.h', u'Source/WebCore/rendering/RenderButton.cpp', u'Source/WebCore/rendering/RenderButton.h', u'Source/WebCore/rendering/RenderCounter.h', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.h', u'Source/WebCore/rendering/RenderDetailsMarker.cpp', u'Source/WebCore/rendering/RenderDetailsMarker.h', u'Source/WebCore/rendering/RenderElement.cpp', u'Source/WebCore/rendering/RenderElement.h', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderEmbeddedObject.h', u'Source/WebCore/rendering/RenderFieldset.cpp', u'Source/WebCore/rendering/RenderFieldset.h', u'Source/WebCore/rendering/RenderFileUploadControl.cpp', u'Source/WebCore/rendering/RenderFileUploadControl.h', u'Source/WebCore/rendering/RenderFlexibleBox.cpp', u'Source/WebCore/rendering/RenderFlexibleBox.h', u'Source/WebCore/rendering/RenderFlowThread.cpp', u'Source/WebCore/rendering/RenderFlowThread.h', u'Source/WebCore/rendering/RenderFrame.cpp', u'Source/WebCore/rendering/RenderFrame.h', u'Source/WebCore/rendering/RenderFrameBase.cpp', u'Source/WebCore/rendering/RenderFrameBase.h', u'Source/WebCore/rendering/RenderFrameSet.cpp', u'Source/WebCore/rendering/RenderFrameSet.h', u'Source/WebCore/rendering/RenderFullScreen.cpp', u'Source/WebCore/rendering/RenderFullScreen.h', u'Source/WebCore/rendering/RenderGrid.cpp', u'Source/WebCore/rendering/RenderGrid.h', u'Source/WebCore/rendering/RenderHTMLCanvas.cpp', u'Source/WebCore/rendering/RenderHTMLCanvas.h', u'Source/WebCore/rendering/RenderIFrame.cpp', u'Source/WebCore/rendering/RenderIFrame.h', u'Source/WebCore/rendering/RenderImage.cpp', u'Source/WebCore/rendering/RenderImage.h', u'Source/WebCore/rendering/RenderInline.cpp', u'Source/WebCore/rendering/RenderInline.h', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayer.h', u'Source/WebCore/rendering/RenderLayerModelObject.cpp', u'Source/WebCore/rendering/RenderLayerModelObject.h', u'Source/WebCore/rendering/RenderLineBreak.cpp', u'Source/WebCore/rendering/RenderLineBreak.h', u'Source/WebCore/rendering/RenderListBox.cpp', u'Source/WebCore/rendering/RenderListBox.h', u'Source/WebCore/rendering/RenderListItem.cpp', u'Source/WebCore/rendering/RenderListItem.h', u'Source/WebCore/rendering/RenderListMarker.cpp', u'Source/WebCore/rendering/RenderListMarker.h', u'Source/WebCore/rendering/RenderMedia.cpp', u'Source/WebCore/rendering/RenderMedia.h', u'Source/WebCore/rendering/RenderMediaControlElements.cpp', u'Source/WebCore/rendering/RenderMediaControlElements.h', u'Source/WebCore/rendering/RenderMenuList.cpp', u'Source/WebCore/rendering/RenderMenuList.h', u'Source/WebCore/rendering/RenderMeter.cpp', u'Source/WebCore/rendering/RenderMeter.h', u'Source/WebCore/rendering/RenderMultiColumnBlock.cpp', u'Source/WebCore/rendering/RenderMultiColumnBlock.h', u'Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp', u'Source/WebCore/rendering/RenderMultiColumnFlowThread.h', u'Source/WebCore/rendering/RenderMultiColumnSet.cpp', u'Source/WebCore/rendering/RenderMultiColumnSet.h', u'Source/WebCore/rendering/RenderNamedFlowFragment.cpp', u'Source/WebCore/rendering/RenderNamedFlowFragment.h', u'Source/WebCore/rendering/RenderNamedFlowThread.cpp', u'Source/WebCore/rendering/RenderNamedFlowThread.h', u'Source/WebCore/rendering/RenderProgress.cpp', u'Source/WebCore/rendering/RenderProgress.h', u'Source/WebCore/rendering/RenderRegion.cpp', u'Source/WebCore/rendering/RenderRegion.h', u'Source/WebCore/rendering/RenderRegionSet.cpp', u'Source/WebCore/rendering/RenderRegionSet.h', u'Source/WebCore/rendering/RenderReplaced.cpp', u'Source/WebCore/rendering/RenderReplaced.h', u'Source/WebCore/rendering/RenderReplica.cpp', u'Source/WebCore/rendering/RenderReplica.h', u'Source/WebCore/rendering/RenderRuby.cpp', u'Source/WebCore/rendering/RenderRuby.h', u'Source/WebCore/rendering/RenderRubyBase.cpp', u'Source/WebCore/rendering/RenderRubyBase.h', u'Source/WebCore/rendering/RenderRubyRun.cpp', u'Source/WebCore/rendering/RenderRubyRun.h', u'Source/WebCore/rendering/RenderRubyText.cpp', u'Source/WebCore/rendering/RenderRubyText.h', u'Source/WebCore/rendering/RenderScrollbar.cpp', u'Source/WebCore/rendering/RenderScrollbarPart.cpp', u'Source/WebCore/rendering/RenderScrollbarPart.h', u'Source/WebCore/rendering/RenderSearchField.cpp', u'Source/WebCore/rendering/RenderSearchField.h', u'Source/WebCore/rendering/RenderSlider.cpp', u'Source/WebCore/rendering/RenderSlider.h', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.h', u'Source/WebCore/rendering/RenderTable.cpp', u'Source/WebCore/rendering/RenderTable.h', u'Source/WebCore/rendering/RenderTableCaption.cpp', u'Source/WebCore/rendering/RenderTableCaption.h', u'Source/WebCore/rendering/RenderTableCell.cpp', u'Source/WebCore/rendering/RenderTableCell.h', u'Source/WebCore/rendering/RenderTableCol.cpp', u'Source/WebCore/rendering/RenderTableCol.h', u'Source/WebCore/rendering/RenderTableRow.cpp', u'Source/WebCore/rendering/RenderTableRow.h', u'Source/WebCore/rendering/RenderTableSection.cpp', u'Source/WebCore/rendering/RenderTableSection.h', u'Source/WebCore/rendering/RenderTextControl.cpp', u'Source/WebCore/rendering/RenderTextControl.h', u'Source/WebCore/rendering/RenderTextControlMultiLine.cpp', u'Source/WebCore/rendering/RenderTextControlMultiLine.h', u'Source/WebCore/rendering/RenderTextControlSingleLine.cpp', u'Source/WebCore/rendering/RenderTextControlSingleLine.h', u'Source/WebCore/rendering/RenderTextTrackCue.cpp', u'Source/WebCore/rendering/RenderTextTrackCue.h', u'Source/WebCore/rendering/RenderVideo.cpp', u'Source/WebCore/rendering/RenderVideo.h', u'Source/WebCore/rendering/RenderView.cpp', u'Source/WebCore/rendering/RenderView.h', u'Source/WebCore/rendering/RenderWidget.cpp', u'Source/WebCore/rendering/RenderWidget.h', u'Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLBlock.h', u'Source/WebCore/rendering/mathml/RenderMathMLFenced.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLFenced.h', u'Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLFraction.h', u'Source/WebCore/rendering/mathml/RenderMathMLMath.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLMath.h', u'Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLOperator.h', u'Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLRoot.h', u'Source/WebCore/rendering/mathml/RenderMathMLRow.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLRow.h', u'Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLScripts.h', u'Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLSpace.h', u'Source/WebCore/rendering/mathml/RenderMathMLSquareRoot.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLSquareRoot.h', u'Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLUnderOver.h', u'Source/WebCore/rendering/style/ContentData.cpp', u'Source/WebCore/rendering/svg/RenderSVGBlock.cpp', u'Source/WebCore/rendering/svg/RenderSVGBlock.h', u'Source/WebCore/rendering/svg/RenderSVGContainer.cpp', u'Source/WebCore/rendering/svg/RenderSVGContainer.h', u'Source/WebCore/rendering/svg/RenderSVGEllipse.cpp', u'Source/WebCore/rendering/svg/RenderSVGEllipse.h', u'Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp', u'Source/WebCore/rendering/svg/RenderSVGForeignObject.h', u'Source/WebCore/rendering/svg/RenderSVGGradientStop.cpp', u'Source/WebCore/rendering/svg/RenderSVGGradientStop.h', u'Source/WebCore/rendering/svg/RenderSVGHiddenContainer.cpp', u'Source/WebCore/rendering/svg/RenderSVGHiddenContainer.h', u'Source/WebCore/rendering/svg/RenderSVGImage.cpp', u'Source/WebCore/rendering/svg/RenderSVGImage.h', u'Source/WebCore/rendering/svg/RenderSVGInline.cpp', u'Source/WebCore/rendering/svg/RenderSVGInline.h', u'Source/WebCore/rendering/svg/RenderSVGModelObject.cpp', u'Source/WebCore/rendering/svg/RenderSVGModelObject.h', u'Source/WebCore/rendering/svg/RenderSVGPath.cpp', u'Source/WebCore/rendering/svg/RenderSVGPath.h', u'Source/WebCore/rendering/svg/RenderSVGRect.cpp', u'Source/WebCore/rendering/svg/RenderSVGRect.h', u'Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceClipper.h', u'Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceContainer.h', u'Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceFilter.h', u'Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.h', u'Source/WebCore/rendering/svg/RenderSVGResourceGradient.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceGradient.h', u'Source/WebCore/rendering/svg/RenderSVGResourceLinearGradient.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceLinearGradient.h', u'Source/WebCore/rendering/svg/RenderSVGResourceMarker.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceMarker.h', u'Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceMasker.h', u'Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourcePattern.h', u'Source/WebCore/rendering/svg/RenderSVGResourceRadialGradient.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceRadialGradient.h', u'Source/WebCore/rendering/svg/RenderSVGRoot.cpp', u'Source/WebCore/rendering/svg/RenderSVGRoot.h', u'Source/WebCore/rendering/svg/RenderSVGShape.cpp', u'Source/WebCore/rendering/svg/RenderSVGShape.h', u'Source/WebCore/rendering/svg/RenderSVGTSpan.h', u'Source/WebCore/rendering/svg/RenderSVGText.cpp', u'Source/WebCore/rendering/svg/RenderSVGText.h', u'Source/WebCore/rendering/svg/RenderSVGTextPath.cpp', u'Source/WebCore/rendering/svg/RenderSVGTextPath.h', u'Source/WebCore/rendering/svg/RenderSVGTransformableContainer.cpp', u'Source/WebCore/rendering/svg/RenderSVGTransformableContainer.h', u'Source/WebCore/rendering/svg/RenderSVGViewportContainer.cpp', u'Source/WebCore/rendering/svg/RenderSVGViewportContainer.h', u'Source/WebCore/style/StyleResolveForDocument.cpp', u'Source/WebCore/style/StyleResolveTree.cpp', u'Source/WebCore/svg/SVGAElement.cpp', u'Source/WebCore/svg/SVGAElement.h', u'Source/WebCore/svg/SVGAltGlyphElement.cpp', u'Source/WebCore/svg/SVGAltGlyphElement.h', u'Source/WebCore/svg/SVGCircleElement.cpp', u'Source/WebCore/svg/SVGCircleElement.h', u'Source/WebCore/svg/SVGClipPathElement.cpp', u'Source/WebCore/svg/SVGClipPathElement.h', u'Source/WebCore/svg/SVGDefsElement.cpp', u'Source/WebCore/svg/SVGDefsElement.h', u'Source/WebCore/svg/SVGEllipseElement.cpp', u'Source/WebCore/svg/SVGEllipseElement.h', u'Source/WebCore/svg/SVGFilterElement.cpp', u'Source/WebCore/svg/SVGFilterElement.h', u'Source/WebCore/svg/SVGFilterPrimitiveStandardAttributes.cpp', u'Source/WebCore/svg/SVGFilterPrimitiveStandardAttributes.h', u'Source/WebCore/svg/SVGForeignObjectElement.cpp', u'Source/WebCore/svg/SVGForeignObjectElement.h', u'Source/WebCore/svg/SVGGElement.cpp', u'Source/WebCore/svg/SVGGElement.h', u'Source/WebCore/svg/SVGGraphicsElement.cpp', u'Source/WebCore/svg/SVGGraphicsElement.h', u'Source/WebCore/svg/SVGImageElement.cpp', u'Source/WebCore/svg/SVGImageElement.h', u'Source/WebCore/svg/SVGLinearGradientElement.cpp', u'Source/WebCore/svg/SVGLinearGradientElement.h', u'Source/WebCore/svg/SVGMarkerElement.cpp', u'Source/WebCore/svg/SVGMarkerElement.h', u'Source/WebCore/svg/SVGMaskElement.cpp', u'Source/WebCore/svg/SVGMaskElement.h', u'Source/WebCore/svg/SVGPathElement.cpp', u'Source/WebCore/svg/SVGPathElement.h', u'Source/WebCore/svg/SVGPatternElement.cpp', u'Source/WebCore/svg/SVGPatternElement.h', u'Source/WebCore/svg/SVGRadialGradientElement.cpp', u'Source/WebCore/svg/SVGRadialGradientElement.h', u'Source/WebCore/svg/SVGRectElement.cpp', u'Source/WebCore/svg/SVGRectElement.h', u'Source/WebCore/svg/SVGSVGElement.cpp', u'Source/WebCore/svg/SVGSVGElement.h', u'Source/WebCore/svg/SVGStopElement.cpp', u'Source/WebCore/svg/SVGStopElement.h', u'Source/WebCore/svg/SVGSwitchElement.cpp', u'Source/WebCore/svg/SVGSwitchElement.h', u'Source/WebCore/svg/SVGSymbolElement.cpp', u'Source/WebCore/svg/SVGSymbolElement.h', u'Source/WebCore/svg/SVGTRefElement.cpp', u'Source/WebCore/svg/SVGTRefElement.h', u'Source/WebCore/svg/SVGTSpanElement.cpp', u'Source/WebCore/svg/SVGTSpanElement.h', u'Source/WebCore/svg/SVGTextElement.cpp', u'Source/WebCore/svg/SVGTextElement.h', u'Source/WebCore/svg/SVGTextPathElement.cpp', u'Source/WebCore/svg/SVGTextPathElement.h', u'Source/WebCore/svg/SVGUseElement.cpp', u'Source/WebCore/svg/SVGUseElement.h']" exit_code: 1 Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp:370: Missing space after , [whitespace/comma] [3] Source/WebCore/dom/Document.cpp:1951: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebCore/dom/Document.cpp:1952: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 3 in 346 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 3 2013-10-27 09:15:05 PDT

Comment on attachment 215270 [details] Snack for EWS Attachment 215270 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/11328076 New failing tests: fast/multicol/span/anonymous-before-child-parent-crash.html fast/multicol/span/clone-summary.html fast/multicol/span/positioned-child-not-removed-crash.html fast/multicol/span/clone-before-after-content-crash.html fast/multicol/span/span-as-nested-columns-child-dynamic.html fast/multicol/span/clone-flexbox.html fast/multicol/span/span-as-nested-columns-child.html

Build Bot

Comment 4 2013-10-27 09:15:06 PDT

Created attachment 215271 [details] Archive of layout-test-results from webkit-ews-03 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 5 2013-10-27 10:13:38 PDT

Comment on attachment 215270 [details] Snack for EWS Attachment 215270 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/14818002 New failing tests: fast/multicol/span/anonymous-before-child-parent-crash.html fast/multicol/span/clone-summary.html fast/multicol/span/positioned-child-not-removed-crash.html fast/multicol/span/clone-before-after-content-crash.html fast/multicol/span/span-as-nested-columns-child-dynamic.html fast/multicol/span/clone-flexbox.html fast/multicol/span/span-as-nested-columns-child.html

Build Bot

Comment 6 2013-10-27 10:13:39 PDT

Created attachment 215273 [details] Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Andreas Kling

Comment 7 2013-10-27 12:06:35 PDT

Created attachment 215274 [details] Second snack for EWS

WebKit Commit Bot

Comment 8 2013-10-27 12:25:57 PDT

Attachment 215274 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/dom/Element.h', u'Source/WebCore/html/BaseButtonInputType.cpp', u'Source/WebCore/html/BaseButtonInputType.h', u'Source/WebCore/html/FileInputType.cpp', u'Source/WebCore/html/FileInputType.h', u'Source/WebCore/html/HTMLAppletElement.cpp', u'Source/WebCore/html/HTMLAppletElement.h', u'Source/WebCore/html/HTMLBRElement.cpp', u'Source/WebCore/html/HTMLBRElement.h', u'Source/WebCore/html/HTMLButtonElement.cpp', u'Source/WebCore/html/HTMLButtonElement.h', u'Source/WebCore/html/HTMLCanvasElement.cpp', u'Source/WebCore/html/HTMLCanvasElement.h', u'Source/WebCore/html/HTMLDetailsElement.cpp', u'Source/WebCore/html/HTMLDetailsElement.h', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLElement.h', u'Source/WebCore/html/HTMLFieldSetElement.cpp', u'Source/WebCore/html/HTMLFieldSetElement.h', u'Source/WebCore/html/HTMLFrameElement.cpp', u'Source/WebCore/html/HTMLFrameElement.h', u'Source/WebCore/html/HTMLFrameSetElement.cpp', u'Source/WebCore/html/HTMLFrameSetElement.h', u'Source/WebCore/html/HTMLIFrameElement.cpp', u'Source/WebCore/html/HTMLIFrameElement.h', u'Source/WebCore/html/HTMLImageElement.cpp', u'Source/WebCore/html/HTMLImageElement.h', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HTMLInputElement.h', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/HTMLMediaElement.h', u'Source/WebCore/html/HTMLMeterElement.cpp', u'Source/WebCore/html/HTMLMeterElement.h', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.h', u'Source/WebCore/html/HTMLProgressElement.cpp', u'Source/WebCore/html/HTMLProgressElement.h', u'Source/WebCore/html/HTMLSelectElement.cpp', u'Source/WebCore/html/HTMLSelectElement.h', u'Source/WebCore/html/HTMLSummaryElement.cpp', u'Source/WebCore/html/HTMLSummaryElement.h', u'Source/WebCore/html/HTMLTextAreaElement.cpp', u'Source/WebCore/html/HTMLTextAreaElement.h', u'Source/WebCore/html/HTMLVideoElement.cpp', u'Source/WebCore/html/HTMLVideoElement.h', u'Source/WebCore/html/HiddenInputType.cpp', u'Source/WebCore/html/HiddenInputType.h', u'Source/WebCore/html/ImageInputType.cpp', u'Source/WebCore/html/ImageInputType.h', u'Source/WebCore/html/InputType.cpp', u'Source/WebCore/html/InputType.h', u'Source/WebCore/html/RangeInputType.cpp', u'Source/WebCore/html/RangeInputType.h', u'Source/WebCore/html/SearchInputType.cpp', u'Source/WebCore/html/SearchInputType.h', u'Source/WebCore/html/TextFieldInputType.cpp', u'Source/WebCore/html/TextFieldInputType.h', u'Source/WebCore/html/shadow/DetailsMarkerControl.cpp', u'Source/WebCore/html/shadow/DetailsMarkerControl.h', u'Source/WebCore/html/shadow/MediaControlElements.cpp', u'Source/WebCore/html/shadow/MediaControlElements.h', u'Source/WebCore/html/shadow/MeterShadowElement.cpp', u'Source/WebCore/html/shadow/MeterShadowElement.h', u'Source/WebCore/html/shadow/ProgressShadowElement.cpp', u'Source/WebCore/html/shadow/ProgressShadowElement.h', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.h', u'Source/WebCore/html/shadow/TextControlInnerElements.cpp', u'Source/WebCore/html/shadow/TextControlInnerElements.h', u'Source/WebCore/html/track/TextTrackCue.cpp', u'Source/WebCore/html/track/TextTrackCue.h', u'Source/WebCore/loader/icon/IconDatabase.cpp', u'Source/WebCore/mathml/MathMLInlineContainerElement.cpp', u'Source/WebCore/mathml/MathMLInlineContainerElement.h', u'Source/WebCore/mathml/MathMLMathElement.cpp', u'Source/WebCore/mathml/MathMLMathElement.h', u'Source/WebCore/mathml/MathMLTextElement.cpp', u'Source/WebCore/mathml/MathMLTextElement.h', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/animation/AnimationController.cpp', u'Source/WebCore/rendering/FlowThreadController.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBlockFlow.cpp', u'Source/WebCore/rendering/RenderBlockFlow.h', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderBox.h', u'Source/WebCore/rendering/RenderBoxModelObject.cpp', u'Source/WebCore/rendering/RenderBoxModelObject.h', u'Source/WebCore/rendering/RenderButton.cpp', u'Source/WebCore/rendering/RenderButton.h', u'Source/WebCore/rendering/RenderCounter.h', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.h', u'Source/WebCore/rendering/RenderDetailsMarker.cpp', u'Source/WebCore/rendering/RenderDetailsMarker.h', u'Source/WebCore/rendering/RenderElement.cpp', u'Source/WebCore/rendering/RenderElement.h', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderEmbeddedObject.h', u'Source/WebCore/rendering/RenderFieldset.cpp', u'Source/WebCore/rendering/RenderFieldset.h', u'Source/WebCore/rendering/RenderFileUploadControl.cpp', u'Source/WebCore/rendering/RenderFileUploadControl.h', u'Source/WebCore/rendering/RenderFlexibleBox.cpp', u'Source/WebCore/rendering/RenderFlexibleBox.h', u'Source/WebCore/rendering/RenderFlowThread.cpp', u'Source/WebCore/rendering/RenderFlowThread.h', u'Source/WebCore/rendering/RenderFrame.cpp', u'Source/WebCore/rendering/RenderFrame.h', u'Source/WebCore/rendering/RenderFrameBase.cpp', u'Source/WebCore/rendering/RenderFrameBase.h', u'Source/WebCore/rendering/RenderFrameSet.cpp', u'Source/WebCore/rendering/RenderFrameSet.h', u'Source/WebCore/rendering/RenderFullScreen.cpp', u'Source/WebCore/rendering/RenderFullScreen.h', u'Source/WebCore/rendering/RenderGrid.cpp', u'Source/WebCore/rendering/RenderGrid.h', u'Source/WebCore/rendering/RenderHTMLCanvas.cpp', u'Source/WebCore/rendering/RenderHTMLCanvas.h', u'Source/WebCore/rendering/RenderIFrame.cpp', u'Source/WebCore/rendering/RenderIFrame.h', u'Source/WebCore/rendering/RenderImage.cpp', u'Source/WebCore/rendering/RenderImage.h', u'Source/WebCore/rendering/RenderInline.cpp', u'Source/WebCore/rendering/RenderInline.h', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayer.h', u'Source/WebCore/rendering/RenderLayerModelObject.cpp', u'Source/WebCore/rendering/RenderLayerModelObject.h', u'Source/WebCore/rendering/RenderLineBreak.cpp', u'Source/WebCore/rendering/RenderLineBreak.h', u'Source/WebCore/rendering/RenderListBox.cpp', u'Source/WebCore/rendering/RenderListBox.h', u'Source/WebCore/rendering/RenderListItem.cpp', u'Source/WebCore/rendering/RenderListItem.h', u'Source/WebCore/rendering/RenderListMarker.cpp', u'Source/WebCore/rendering/RenderListMarker.h', u'Source/WebCore/rendering/RenderMedia.cpp', u'Source/WebCore/rendering/RenderMedia.h', u'Source/WebCore/rendering/RenderMediaControlElements.cpp', u'Source/WebCore/rendering/RenderMediaControlElements.h', u'Source/WebCore/rendering/RenderMenuList.cpp', u'Source/WebCore/rendering/RenderMenuList.h', u'Source/WebCore/rendering/RenderMeter.cpp', u'Source/WebCore/rendering/RenderMeter.h', u'Source/WebCore/rendering/RenderMultiColumnBlock.cpp', u'Source/WebCore/rendering/RenderMultiColumnBlock.h', u'Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp', u'Source/WebCore/rendering/RenderMultiColumnFlowThread.h', u'Source/WebCore/rendering/RenderMultiColumnSet.cpp', u'Source/WebCore/rendering/RenderMultiColumnSet.h', u'Source/WebCore/rendering/RenderNamedFlowFragment.cpp', u'Source/WebCore/rendering/RenderNamedFlowFragment.h', u'Source/WebCore/rendering/RenderNamedFlowThread.cpp', u'Source/WebCore/rendering/RenderNamedFlowThread.h', u'Source/WebCore/rendering/RenderProgress.cpp', u'Source/WebCore/rendering/RenderProgress.h', u'Source/WebCore/rendering/RenderRegion.cpp', u'Source/WebCore/rendering/RenderRegion.h', u'Source/WebCore/rendering/RenderRegionSet.cpp', u'Source/WebCore/rendering/RenderRegionSet.h', u'Source/WebCore/rendering/RenderReplaced.cpp', u'Source/WebCore/rendering/RenderReplaced.h', u'Source/WebCore/rendering/RenderReplica.cpp', u'Source/WebCore/rendering/RenderReplica.h', u'Source/WebCore/rendering/RenderRuby.cpp', u'Source/WebCore/rendering/RenderRuby.h', u'Source/WebCore/rendering/RenderRubyBase.cpp', u'Source/WebCore/rendering/RenderRubyBase.h', u'Source/WebCore/rendering/RenderRubyRun.cpp', u'Source/WebCore/rendering/RenderRubyRun.h', u'Source/WebCore/rendering/RenderRubyText.cpp', u'Source/WebCore/rendering/RenderRubyText.h', u'Source/WebCore/rendering/RenderScrollbar.cpp', u'Source/WebCore/rendering/RenderScrollbarPart.cpp', u'Source/WebCore/rendering/RenderScrollbarPart.h', u'Source/WebCore/rendering/RenderSearchField.cpp', u'Source/WebCore/rendering/RenderSearchField.h', u'Source/WebCore/rendering/RenderSlider.cpp', u'Source/WebCore/rendering/RenderSlider.h', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.h', u'Source/WebCore/rendering/RenderTable.cpp', u'Source/WebCore/rendering/RenderTable.h', u'Source/WebCore/rendering/RenderTableCaption.cpp', u'Source/WebCore/rendering/RenderTableCaption.h', u'Source/WebCore/rendering/RenderTableCell.cpp', u'Source/WebCore/rendering/RenderTableCell.h', u'Source/WebCore/rendering/RenderTableCol.cpp', u'Source/WebCore/rendering/RenderTableCol.h', u'Source/WebCore/rendering/RenderTableRow.cpp', u'Source/WebCore/rendering/RenderTableRow.h', u'Source/WebCore/rendering/RenderTableSection.cpp', u'Source/WebCore/rendering/RenderTableSection.h', u'Source/WebCore/rendering/RenderTextControl.cpp', u'Source/WebCore/rendering/RenderTextControl.h', u'Source/WebCore/rendering/RenderTextControlMultiLine.cpp', u'Source/WebCore/rendering/RenderTextControlMultiLine.h', u'Source/WebCore/rendering/RenderTextControlSingleLine.cpp', u'Source/WebCore/rendering/RenderTextControlSingleLine.h', u'Source/WebCore/rendering/RenderTextTrackCue.cpp', u'Source/WebCore/rendering/RenderTextTrackCue.h', u'Source/WebCore/rendering/RenderVideo.cpp', u'Source/WebCore/rendering/RenderVideo.h', u'Source/WebCore/rendering/RenderView.cpp', u'Source/WebCore/rendering/RenderView.h', u'Source/WebCore/rendering/RenderWidget.cpp', u'Source/WebCore/rendering/RenderWidget.h', u'Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLBlock.h', u'Source/WebCore/rendering/mathml/RenderMathMLFenced.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLFenced.h', u'Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLFraction.h', u'Source/WebCore/rendering/mathml/RenderMathMLMath.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLMath.h', u'Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLOperator.h', u'Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLRoot.h', u'Source/WebCore/rendering/mathml/RenderMathMLRow.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLRow.h', u'Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLScripts.h', u'Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLSpace.h', u'Source/WebCore/rendering/mathml/RenderMathMLSquareRoot.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLSquareRoot.h', u'Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLUnderOver.h', u'Source/WebCore/rendering/style/ContentData.cpp', u'Source/WebCore/rendering/svg/RenderSVGBlock.cpp', u'Source/WebCore/rendering/svg/RenderSVGBlock.h', u'Source/WebCore/rendering/svg/RenderSVGContainer.cpp', u'Source/WebCore/rendering/svg/RenderSVGContainer.h', u'Source/WebCore/rendering/svg/RenderSVGEllipse.cpp', u'Source/WebCore/rendering/svg/RenderSVGEllipse.h', u'Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp', u'Source/WebCore/rendering/svg/RenderSVGForeignObject.h', u'Source/WebCore/rendering/svg/RenderSVGGradientStop.cpp', u'Source/WebCore/rendering/svg/RenderSVGGradientStop.h', u'Source/WebCore/rendering/svg/RenderSVGHiddenContainer.cpp', u'Source/WebCore/rendering/svg/RenderSVGHiddenContainer.h', u'Source/WebCore/rendering/svg/RenderSVGImage.cpp', u'Source/WebCore/rendering/svg/RenderSVGImage.h', u'Source/WebCore/rendering/svg/RenderSVGInline.cpp', u'Source/WebCore/rendering/svg/RenderSVGInline.h', u'Source/WebCore/rendering/svg/RenderSVGModelObject.cpp', u'Source/WebCore/rendering/svg/RenderSVGModelObject.h', u'Source/WebCore/rendering/svg/RenderSVGPath.cpp', u'Source/WebCore/rendering/svg/RenderSVGPath.h', u'Source/WebCore/rendering/svg/RenderSVGRect.cpp', u'Source/WebCore/rendering/svg/RenderSVGRect.h', u'Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceClipper.h', u'Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceContainer.h', u'Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceFilter.h', u'Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.h', u'Source/WebCore/rendering/svg/RenderSVGResourceGradient.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceGradient.h', u'Source/WebCore/rendering/svg/RenderSVGResourceLinearGradient.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceLinearGradient.h', u'Source/WebCore/rendering/svg/RenderSVGResourceMarker.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceMarker.h', u'Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceMasker.h', u'Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourcePattern.h', u'Source/WebCore/rendering/svg/RenderSVGResourceRadialGradient.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceRadialGradient.h', u'Source/WebCore/rendering/svg/RenderSVGRoot.cpp', u'Source/WebCore/rendering/svg/RenderSVGRoot.h', u'Source/WebCore/rendering/svg/RenderSVGShape.cpp', u'Source/WebCore/rendering/svg/RenderSVGShape.h', u'Source/WebCore/rendering/svg/RenderSVGTSpan.h', u'Source/WebCore/rendering/svg/RenderSVGText.cpp', u'Source/WebCore/rendering/svg/RenderSVGText.h', u'Source/WebCore/rendering/svg/RenderSVGTextPath.cpp', u'Source/WebCore/rendering/svg/RenderSVGTextPath.h', u'Source/WebCore/rendering/svg/RenderSVGTransformableContainer.cpp', u'Source/WebCore/rendering/svg/RenderSVGTransformableContainer.h', u'Source/WebCore/rendering/svg/RenderSVGViewportContainer.cpp', u'Source/WebCore/rendering/svg/RenderSVGViewportContainer.h', u'Source/WebCore/style/StyleResolveForDocument.cpp', u'Source/WebCore/style/StyleResolveTree.cpp', u'Source/WebCore/svg/SVGAElement.cpp', u'Source/WebCore/svg/SVGAElement.h', u'Source/WebCore/svg/SVGAltGlyphElement.cpp', u'Source/WebCore/svg/SVGAltGlyphElement.h', u'Source/WebCore/svg/SVGCircleElement.cpp', u'Source/WebCore/svg/SVGCircleElement.h', u'Source/WebCore/svg/SVGClipPathElement.cpp', u'Source/WebCore/svg/SVGClipPathElement.h', u'Source/WebCore/svg/SVGDefsElement.cpp', u'Source/WebCore/svg/SVGDefsElement.h', u'Source/WebCore/svg/SVGEllipseElement.cpp', u'Source/WebCore/svg/SVGEllipseElement.h', u'Source/WebCore/svg/SVGFilterElement.cpp', u'Source/WebCore/svg/SVGFilterElement.h', u'Source/WebCore/svg/SVGFilterPrimitiveStandardAttributes.cpp', u'Source/WebCore/svg/SVGFilterPrimitiveStandardAttributes.h', u'Source/WebCore/svg/SVGForeignObjectElement.cpp', u'Source/WebCore/svg/SVGForeignObjectElement.h', u'Source/WebCore/svg/SVGGElement.cpp', u'Source/WebCore/svg/SVGGElement.h', u'Source/WebCore/svg/SVGGraphicsElement.cpp', u'Source/WebCore/svg/SVGGraphicsElement.h', u'Source/WebCore/svg/SVGImageElement.cpp', u'Source/WebCore/svg/SVGImageElement.h', u'Source/WebCore/svg/SVGLinearGradientElement.cpp', u'Source/WebCore/svg/SVGLinearGradientElement.h', u'Source/WebCore/svg/SVGMarkerElement.cpp', u'Source/WebCore/svg/SVGMarkerElement.h', u'Source/WebCore/svg/SVGMaskElement.cpp', u'Source/WebCore/svg/SVGMaskElement.h', u'Source/WebCore/svg/SVGPathElement.cpp', u'Source/WebCore/svg/SVGPathElement.h', u'Source/WebCore/svg/SVGPatternElement.cpp', u'Source/WebCore/svg/SVGPatternElement.h', u'Source/WebCore/svg/SVGRadialGradientElement.cpp', u'Source/WebCore/svg/SVGRadialGradientElement.h', u'Source/WebCore/svg/SVGRectElement.cpp', u'Source/WebCore/svg/SVGRectElement.h', u'Source/WebCore/svg/SVGSVGElement.cpp', u'Source/WebCore/svg/SVGSVGElement.h', u'Source/WebCore/svg/SVGStopElement.cpp', u'Source/WebCore/svg/SVGStopElement.h', u'Source/WebCore/svg/SVGSwitchElement.cpp', u'Source/WebCore/svg/SVGSwitchElement.h', u'Source/WebCore/svg/SVGSymbolElement.cpp', u'Source/WebCore/svg/SVGSymbolElement.h', u'Source/WebCore/svg/SVGTRefElement.cpp', u'Source/WebCore/svg/SVGTRefElement.h', u'Source/WebCore/svg/SVGTSpanElement.cpp', u'Source/WebCore/svg/SVGTSpanElement.h', u'Source/WebCore/svg/SVGTextElement.cpp', u'Source/WebCore/svg/SVGTextElement.h', u'Source/WebCore/svg/SVGTextPathElement.cpp', u'Source/WebCore/svg/SVGTextPathElement.h', u'Source/WebCore/svg/SVGUseElement.cpp', u'Source/WebCore/svg/SVGUseElement.h']" exit_code: 1 Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp:370: Missing space after , [whitespace/comma] [3] Total errors found: 1 in 346 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andreas Kling

Comment 9 2013-10-27 14:22:48 PDT

Created attachment 215276 [details] Patch

Antti Koivisto

Comment 10 2013-10-27 14:39:46 PDT

Comment on attachment 215276 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215276&action=review > Source/WebCore/loader/icon/IconDatabase.cpp:266 > - ASSERT(iconRecord || m_retainedPageURLs.contains(pageURLOriginal)); > +// ASSERT(iconRecord || m_retainedPageURLs.contains(pageURLOriginal)); Probably don't want to land this > Source/WebCore/rendering/FlowThreadController.cpp:82 > + auto flowRenderer = new RenderNamedFlowThread( > + m_view->document(), > + RenderFlowThread::createFlowThreadStyle(m_view->style()), > + namedFlows->ensureFlowWithName(name) > + ); New fashionable way of calling functions? > Source/WebCore/rendering/RenderElement.cpp:355 > +void RenderElement::initializeStyle() > +{ > + styleWillChange(StyleDifferenceEqual, *style()); > + > + m_hasInitializedStyle = true; Would be nice to be able to do all style initialization during construction and get rid of this function. > Source/WebCore/rendering/RenderElement.h:168 > + bool m_hasInitializedStyle : 1; Bit of a hack but ok. > Source/WebCore/style/StyleResolveTree.cpp:259 > + // FIXME: There's probably a better way to factor this. > + // This just does what setAnimatedStyle() does, except with setStyleInternal() instead of setStyle(). > + newRenderer->setStyleInternal(newRenderer->animation().updateAnimations(*newRenderer, *newRenderer->style())); > + > + newRenderer->initializeStyle(); Might be nicer to at least factor these to something like initializeAnimatableStyle()

Darin Adler

Comment 11 2013-10-27 14:42:08 PDT

Comment on attachment 215276 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215276&action=review Are you changing the style() function to return a reference? Next patch? > Source/WebCore/dom/Element.h:307 > + virtual RenderElement* createRenderer(PassRef<RenderStyle>); Should add OVERRIDE. > Source/WebCore/html/HTMLBRElement.h:44 > + virtual RenderElement* createRenderer(PassRef<RenderStyle>); Should add OVERRIDE. > Source/WebCore/html/HTMLButtonElement.h:48 > + virtual RenderElement* createRenderer(PassRef<RenderStyle>); Should add OVERRIDE. > Source/WebCore/html/HTMLDetailsElement.h:38 > + virtual RenderElement* createRenderer(PassRef<RenderStyle>); Should add OVERRIDE. > Source/WebCore/html/HTMLFrameElement.h:45 > + virtual RenderElement* createRenderer(PassRef<RenderStyle>); Should add OVERRIDE. > Source/WebCore/html/HTMLFrameSetElement.h:78 > + virtual RenderElement* createRenderer(PassRef<RenderStyle>); Should add OVERRIDE. > Source/WebCore/html/HTMLIFrameElement.h:45 > + virtual RenderElement* createRenderer(PassRef<RenderStyle>); Should add OVERRIDE. >> Source/WebCore/loader/icon/IconDatabase.cpp:266 >> - ASSERT(iconRecord || m_retainedPageURLs.contains(pageURLOriginal)); >> +// ASSERT(iconRecord || m_retainedPageURLs.contains(pageURLOriginal)); > > Probably don't want to land this Hmm, this one snuck in here. Not part of this patch. > Source/WebCore/mathml/MathMLTextElement.h:43 > + virtual RenderElement* createRenderer(PassRef<RenderStyle>); Should add OVERRIDE. >> Source/WebCore/rendering/FlowThreadController.cpp:82 >> + auto flowRenderer = new RenderNamedFlowThread( >> + m_view->document(), >> + RenderFlowThread::createFlowThreadStyle(m_view->style()), >> + namedFlows->ensureFlowWithName(name) >> + ); > > New fashionable way of calling functions? Not sure I like the formatting here, but I don’t have a better suggestion. > Source/WebCore/rendering/RenderButton.h:38 > - explicit RenderButton(HTMLFormControlElement&); > + explicit RenderButton(HTMLFormControlElement&, PassRef<RenderStyle>); Left a stray explicit here. > Source/WebCore/rendering/RenderDeprecatedFlexibleBox.h:34 > - explicit RenderDeprecatedFlexibleBox(Element&); > + explicit RenderDeprecatedFlexibleBox(Element&, PassRef<RenderStyle>); Left a stray explicit here. > Source/WebCore/rendering/RenderGrid.h:39 > - explicit RenderGrid(Element&); > + explicit RenderGrid(Element&, PassRef<RenderStyle>); Stray explicit left here. > Source/WebCore/rendering/RenderNamedFlowThread.h:48 > - explicit RenderNamedFlowThread(Document&, PassRefPtr<WebKitNamedFlow>); > + explicit RenderNamedFlowThread(Document&, PassRef<RenderStyle>, PassRefPtr<WebKitNamedFlow>); Stray explicit left here. > Source/WebCore/style/StyleResolveForDocument.cpp:-52 > - ASSERT(document.hasLivingRenderTree()); I don’t understand this change, nor does the change log shed any light. > Source/WebCore/svg/SVGAElement.h:51 > + virtual RenderElement* createRenderer(PassRef<RenderStyle>); Should add OVERRIDE. > Source/WebCore/svg/SVGAltGlyphElement.h:49 > + virtual RenderElement* createRenderer(PassRef<RenderStyle>); Should add OVERRIDE. > Source/WebCore/svg/SVGForeignObjectElement.h:48 > + virtual RenderElement* createRenderer(PassRef<RenderStyle>); Should add OVERRIDE. > Source/WebCore/svg/SVGTRefElement.h:47 > + virtual RenderElement* createRenderer(PassRef<RenderStyle>); Should add OVERRIDE. > Source/WebCore/svg/SVGTSpanElement.h:36 > + virtual RenderElement* createRenderer(PassRef<RenderStyle>); Should add OVERRIDE. > Source/WebCore/svg/SVGTextElement.h:40 > + virtual RenderElement* createRenderer(PassRef<RenderStyle>); Should add OVERRIDE. > Source/WebCore/svg/SVGTextPathElement.h:130 > + virtual RenderElement* createRenderer(PassRef<RenderStyle>); Should add OVERRIDE. > Source/WebCore/svg/SVGUseElement.h:72 > + virtual RenderElement* createRenderer(PassRef<RenderStyle>); Should add OVERRIDE.

Andreas Kling

Comment 12 2013-10-27 15:17:08 PDT

(In reply to comment #10) > (From update of attachment 215276 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=215276&action=review > > > Source/WebCore/loader/icon/IconDatabase.cpp:266 > > - ASSERT(iconRecord || m_retainedPageURLs.contains(pageURLOriginal)); > > +// ASSERT(iconRecord || m_retainedPageURLs.contains(pageURLOriginal)); > > Probably don't want to land this I really kind of want to, but no. > > Source/WebCore/rendering/FlowThreadController.cpp:82 > > + auto flowRenderer = new RenderNamedFlowThread( > > + m_view->document(), > > + RenderFlowThread::createFlowThreadStyle(m_view->style()), > > + namedFlows->ensureFlowWithName(name) > > + ); > > New fashionable way of calling functions? Oh, I didn't mean to leave that in. Restored the old formatting. > > Source/WebCore/rendering/RenderElement.cpp:355 > > +void RenderElement::initializeStyle() > > +{ > > + styleWillChange(StyleDifferenceEqual, *style()); > > + > > + m_hasInitializedStyle = true; > > Would be nice to be able to do all style initialization during construction and get rid of this function. Yes. Soon. > > Source/WebCore/style/StyleResolveTree.cpp:259 > > + // FIXME: There's probably a better way to factor this. > > + // This just does what setAnimatedStyle() does, except with setStyleInternal() instead of setStyle(). > > + newRenderer->setStyleInternal(newRenderer->animation().updateAnimations(*newRenderer, *newRenderer->style())); > > + > > + newRenderer->initializeStyle(); > > Might be nicer to at least factor these to something like initializeAnimatableStyle() Sure. Follow-up.

Andreas Kling

Comment 13 2013-10-27 15:18:49 PDT

(In reply to comment #11) > (From update of attachment 215276 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=215276&action=review > > Are you changing the style() function to return a reference? Next patch? Next patch! > > Source/WebCore/style/StyleResolveForDocument.cpp:-52 > > - ASSERT(document.hasLivingRenderTree()); > > I don’t understand this change, nor does the change log shed any light. Oops! Thanks for catching this. It got left over when I was trying to create an initial style for the RenderView without having a RenderView. Fixed up OVERRIDE and explicit things locally.

Andreas Kling

Comment 14 2013-10-27 15:53:14 PDT

Committed r158097: <http://trac.webkit.org/changeset/158097>

Note You need to log in before you can comment on or make changes to this bug.