Bug 123392

Summary: Re-use existing RenderStyle local in textWidth().
Product: WebKit Reporter: Andreas Kling <kling>
Component: TextAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kling, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch koivisto: review+, commit-queue: commit-queue-

Andreas Kling
Reported 2013-10-26 13:53:32 PDT
From the Saturday Micro-Optimization Department.
Attachments
Patch (1.35 KB, patch)
2013-10-26 13:54 PDT, Andreas Kling 		koivisto: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-10-26 13:54:09 PDT
Created attachment 215259 [details] Patch
WebKit Commit Bot
Comment 2 2013-10-29 12:42:18 PDT
Comment on attachment 215259 [details] Patch Rejecting attachment 215259 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 215259, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/rendering/RenderBlockLineLayout.cpp Hunk #1 FAILED at 2388. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/RenderBlockLineLayout.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/16968039
Andreas Kling
Comment 3 2013-11-01 18:48:36 PDT
Committed r158476: <http://trac.webkit.org/changeset/158476>
Note You need to log in before you can comment on or make changes to this bug.