Summary: | fast/frames/seamless/seamless-nested-crash.html asserts on wk2 only | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED CONFIGURATION CHANGED | ||||||
Severity: | Normal | CC: | ahmad.saleem792, commit-queue, esprehn+autocc, glenn, koivisto, kondapallykalyan, mark.lam, mmaxfield, simon.fraser | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Antti Koivisto
2013-10-25 11:59:33 PDT
Skipped temporarily in https://trac.webkit.org/r158031 Created attachment 215249 [details]
patch
Comment on attachment 215249 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=215249&action=review OK > Source/WebCore/ChangeLog:12 > + to use the primary font metrics for all lines but those wont match the fallbacks won't This broke the build: http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20%28Build%29/builds/17795/steps/compile-webkit/logs/stdio Fixed in r158086: <http://trac.webkit.org/r158086>. (In reply to comment #4) > This broke the build: > http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20%28Build%29/builds/17795/steps/compile-webkit/logs/stdio > > Fixed in r158086: <http://trac.webkit.org/r158086>. FYI, the commit that broke the build is r158085: <http://trac.webkit.org/r158085>. r158085 - RefPtr<SimpleFontData>& fontData = m_fontDataTable.add(hashKey, nullptr).iterator->value; + RefPtr<SimpleFontData> fontData = m_fontDataTable.add(hashKey, nullptr).iterator->value; Means that we no longer add anything to the cache (ever!) iframe 'seamless' support is gone and this test was removed as well: https://github.com/WebKit/WebKit/commit/3e2010a853456a8ad1e097897ef35ff5b54b2877 Nothing to do here. |