Bug 123346

Summary: [CSS Regions][CSS Shapes] Layout error when the shape has negative top coordinate and it's applied on the second region
Product: WebKit Reporter: Zoltan Horvath <zoltan>
Component: CSSAssignee: Zoltan Horvath <zoltan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch hyatt: review+

Description Zoltan Horvath 2013-10-25 09:36:28 PDT
We have a layout error when there is a shape applied on the second region,and it has a negative 'top' coordinate. Since shapeInsideInfo::shapeLogicalTop() can return negative numbers, we need to check for it we're positioning the first line in the region.
Comment 1 Zoltan Horvath 2013-10-25 11:04:30 PDT
Created attachment 215192 [details]
Patch
Comment 2 Dave Hyatt 2013-10-29 13:28:12 PDT
Comment on attachment 215192 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215192&action=review

r=me

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:1447
> +        if (!shapeTopOffset && (0 < shapeInsideInfo->shapeLogicalTop()))

We don't typically put the constants on the left. I'd change this to shapeInsideInfo->shapeLogicalTop() > 0
Comment 3 Zoltan Horvath 2013-10-29 13:43:55 PDT
http://trac.webkit.org/changeset/158219