Bug 12334

Summary: Respect <text> boundaries for svg text selecting
Product: WebKit Reporter: Rob Buis <rwlbuis>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
First attempt
eric: review-
Improved patch
none
Now with testcase sam: review+

Rob Buis
Reported 2007-01-18 22:55:56 PST
See text-tselect-01-b.svg and text-tselect-02-f.svg for tests.
Attachments
First attempt (1.52 KB, patch)
2007-01-19 04:35 PST, Rob Buis 		eric: review-
DetailsFormatted DiffDiff
Improved patch (3.21 KB, patch)
2007-01-19 13:41 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Now with testcase (4.16 KB, patch)
2007-01-20 14:04 PST, Rob Buis 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2007-01-19 04:35:03 PST
Created attachment 12555 [details] First attempt This patch should do it. Testcases may need to wait until we can select SVG text using the DOM. Cheers, Rob.
Eric Seidel (no email)
Comment 2 2007-01-19 04:39:40 PST
Comment on attachment 12555 [details] First attempt This is wrong: strncmp(r->renderName(), "RenderSVGInlineText", 19) == 0 || strncmp(r->renderName(), "RenderSVGText", 13) == 0 we should add a virtual method isSVGTextObject() (or similar) to RenderObject instead (if RenderSVGInlineTExt is a subclass of RenderSVGText it coudl easily be named isSVGText()) maybe there is an easier more general way to do this? It seems a little awkward to hack this into the base code.
Rob Buis
Comment 3 2007-01-19 13:41:23 PST
Created attachment 12563 [details] Improved patch Addressing Eric's issue. Cheers, Rob.
Rob Buis
Comment 4 2007-01-20 14:04:15 PST
Created attachment 12575 [details] Now with testcase This one contains some extra safety checks and cleanups. Also added a manual test. Cheers, Rob.
Sam Weinig
Comment 5 2007-01-20 14:07:56 PST
Comment on attachment 12575 [details] Now with testcase r=me
Rob Buis
Comment 6 2007-01-20 14:11:28 PST
Landed in r19002.
Note You need to log in before you can comment on or make changes to this bug.