Bug 123317

Summary: [JSC] Can't disable jit
Product: WebKit Reporter: ChangSeok Oh <changseok>
Component: JavaScriptCoreAssignee: ChangSeok Oh <changseok>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: buildbot, eflews.bot, fpizlo, ggaren, gtk-ews, gyuyoung.kim, mark.lam, msaboff, oliver, ossy, rego+ews, rniwa, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch mark.lam: review-

ChangSeok Oh
Reported 2013-10-24 21:13:47 PDT
Disabling jit with --disable-jit causes many compile issue.
Attachments
Patch (20.21 KB, patch)
2013-10-24 21:25 PDT, ChangSeok Oh 		no flags
DetailsFormatted DiffDiff
Patch (19.79 KB, patch)
2013-10-24 22:15 PDT, ChangSeok Oh 		no flags
DetailsFormatted DiffDiff
Patch (19.63 KB, patch)
2013-10-28 06:56 PDT, ChangSeok Oh 		mark.lam: review-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
ChangSeok Oh
Comment 1 2013-10-24 21:25:43 PDT
Created attachment 215140 [details] Patch
ChangSeok Oh
Comment 2 2013-10-24 22:15:26 PDT
Created attachment 215142 [details] Patch
EFL EWS Bot
Comment 3 2013-10-24 22:20:23 PDT
Comment on attachment 215142 [details] Patch Attachment 215142 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/11828017
kov's GTK+ EWS bot
Comment 4 2013-10-24 22:26:20 PDT
Comment on attachment 215142 [details] Patch Attachment 215142 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/11868008
Build Bot
Comment 5 2013-10-24 22:44:38 PDT
Comment on attachment 215142 [details] Patch Attachment 215142 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/11858014
Build Bot
Comment 6 2013-10-24 22:56:42 PDT
Comment on attachment 215142 [details] Patch Attachment 215142 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/11888024
Build Bot
Comment 7 2013-10-24 22:57:58 PDT
Comment on attachment 215142 [details] Patch Attachment 215142 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/11838016
EFL EWS Bot
Comment 8 2013-10-25 02:27:58 PDT
Comment on attachment 215142 [details] Patch Attachment 215142 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/11878082
Darin Adler
Comment 9 2013-10-25 12:49:37 PDT
Comment on attachment 215142 [details] Patch Doesn’t compile on any platform.
ChangSeok Oh
Comment 10 2013-10-25 17:56:46 PDT
(In reply to comment #9) > (From update of attachment 215142 [details]) > Doesn’t compile on any platform. Yeah I know. I'll rebase the patch. :)
ChangSeok Oh
Comment 11 2013-10-28 06:56:32 PDT
Created attachment 215301 [details] Patch
ChangSeok Oh
Comment 12 2013-10-31 01:59:16 PDT
Any comments?
Mark Lam
Comment 13 2013-10-31 08:29:13 PDT
It is not clear to me what --disable-jit means. Tools/Scripts/build-jsc doesn't take that option. I'll presume you mean the equivalent of #define ENABLE_JIT 0. Based on that, are you sure that there is really an issue? I built ToT yesterday with ENABLE_JIT 0 and it built fine. Would you mind re-trying with the most recent version of trunk?
Mark Lam
Comment 14 2013-10-31 08:30:35 PDT
(In reply to comment #13) > Based on that, are you sure that there is really an issue? I built ToT yesterday with ENABLE_JIT 0 and it built fine. Would you mind re-trying with the most recent version of trunk? I just confirmed that ToT r158357 builds fine with ENABLE_JIT 0. Please re-test.
Mark Lam
Comment 15 2013-10-31 19:07:10 PDT
Comment on attachment 215301 [details] Patch I'm quite sure I fixed this already in ToT by providing a placeholder StubInfoMap. Hence, this patch is not needed.
ChangSeok Oh
Comment 16 2013-10-31 23:12:27 PDT
(In reply to comment #15) > (From update of attachment 215301 [details]) > I'm quite sure I fixed this already in ToT by providing a placeholder StubInfoMap. Hence, this patch is not needed. Yeah. You're right. The break seems fixed in http://trac.webkit.org/changeset/157932 Thanks :)
ChangSeok Oh
Comment 17 2013-10-31 23:13:28 PDT
*** This bug has been marked as a duplicate of bug 123271 ***
Note You need to log in before you can comment on or make changes to this bug.