Bug 123281

Summary:

Web Inspector: Adjust the precision of byte strings

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eoconnor, graouts, joepeck, mat, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	joepeck: review+, timothy: commit-queue-
Patch	joepeck: review+
Patch	none

Timothy Hatcher

Reported 2013-10-24 11:36:55 PDT

It should show more precision for MB and less precision for < 1024 KB.

Attachments
Patch (1.72 KB, patch) 2013-10-24 11:40 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Patch (1.69 KB, patch) 2013-10-24 11:43 PDT, Timothy Hatcher	joepeck: review+ timothy: commit-queue-	Details Formatted Diff Diff
Patch (1.86 KB, patch) 2013-10-24 11:50 PDT, Timothy Hatcher	joepeck: review+	Details Formatted Diff Diff
Patch (1.81 KB, patch) 2013-10-24 12:04 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2013-10-24 11:37:30 PDT

<rdar://problem/15311366>

Mat Marquis

Comment 2 2013-10-24 11:39:53 PDT

> less precision for < 1024 KB. I’m not sure why you’d want it to be less precise at any point?

Timothy Hatcher

Comment 3 2013-10-24 11:40:02 PDT

Created attachment 215085 [details] Patch

Timothy Hatcher

Comment 4 2013-10-24 11:43:25 PDT

Created attachment 215086 [details] Patch

Joseph Pecoraro

Comment 5 2013-10-24 11:44:05 PDT

Comment on attachment 215086 [details] Patch r=me

Joseph Pecoraro

Comment 6 2013-10-24 11:47:20 PDT

Comment on attachment 215086 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215086&action=review > Source/WebInspectorUI/UserInterface/Utilities.js:945 > + if (higherResolution || megabytes < 10) We could even do the same for kilobytes. if KB < 10 show %.2f

Mat Marquis

Comment 7 2013-10-24 11:47:54 PDT

*** Bug 123280 has been marked as a duplicate of this bug. ***

Timothy Hatcher

Comment 8 2013-10-24 11:50:05 PDT

Created attachment 215087 [details] Patch

Mat Marquis

Comment 9 2013-10-24 11:50:21 PDT

Wait, so this only shows the first decimal place up to 10MB? I’m not sure why there needs to be an upper threshold. I’d really rather have the most accurate possible read of bandwidth usage at any point.

Joseph Pecoraro

Comment 10 2013-10-24 11:52:08 PDT

Comment on attachment 215087 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215087&action=review > Source/WebInspectorUI/UserInterface/Utilities.js:942 > + else if (higherResolution && kilobytes < 1024) > + return WebInspector.UIString("%.1f KB").format(kilobytes); This should be just "kilobytes < 1024", if higherResolution were true, the top if would have been taken.

Timothy Hatcher

Comment 11 2013-10-24 12:04:52 PDT

Created attachment 215088 [details] Patch

Joseph Pecoraro

Comment 12 2013-10-24 12:05:54 PDT

Comment on attachment 215088 [details] Patch r=me!!

WebKit Commit Bot

Comment 13 2013-10-24 12:38:07 PDT

Comment on attachment 215088 [details] Patch Clearing flags on attachment: 215088 Committed r157947: <http://trac.webkit.org/changeset/157947>

WebKit Commit Bot

Comment 14 2013-10-24 12:38:09 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.