Bug 123273

Summary:

Stop bringing in the std namespace

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, eflews.bot, gyuyoung.kim, rego+ews, rniwa, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Anders Carlsson

Reported 2013-10-24 08:51:55 PDT

Stop bringing in the std namespace

Attachments
Patch (176.78 KB, patch) 2013-10-24 08:54 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (179.00 KB, patch) 2013-10-24 09:16 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (181.11 KB, patch) 2013-10-24 09:24 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (185.95 KB, patch) 2013-10-24 10:16 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Anders Carlsson

Comment 1 2013-10-24 08:54:56 PDT

Created attachment 215069 [details] Patch

WebKit Commit Bot

Comment 2 2013-10-24 08:58:05 PDT

Attachment 215069 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp', u'Source/WebCore/Modules/webaudio/AudioNodeInput.cpp', u'Source/WebCore/Modules/webaudio/AudioParamTimeline.cpp', u'Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp', u'Source/WebCore/Modules/webaudio/AudioSummingJunction.cpp', u'Source/WebCore/Modules/webaudio/DelayDSPKernel.cpp', u'Source/WebCore/Modules/webaudio/OfflineAudioDestinationNode.cpp', u'Source/WebCore/Modules/webaudio/OscillatorNode.cpp', u'Source/WebCore/Modules/webaudio/PannerNode.cpp', u'Source/WebCore/Modules/webaudio/WaveShaperDSPKernel.cpp', u'Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp', u'Source/WebCore/Modules/websockets/WebSocket.cpp', u'Source/WebCore/Modules/websockets/WebSocketChannel.cpp', u'Source/WebCore/Modules/websockets/WebSocketFrame.cpp', u'Source/WebCore/accessibility/AccessibilityARIAGrid.cpp', u'Source/WebCore/accessibility/AccessibilityARIAGridCell.cpp', u'Source/WebCore/accessibility/AccessibilityARIAGridRow.cpp', u'Source/WebCore/accessibility/AccessibilityList.cpp', u'Source/WebCore/accessibility/AccessibilityListBox.cpp', u'Source/WebCore/accessibility/AccessibilityListBoxOption.cpp', u'Source/WebCore/accessibility/AccessibilityNodeObject.cpp', u'Source/WebCore/accessibility/AccessibilityObject.cpp', u'Source/WebCore/accessibility/AccessibilityRenderObject.cpp', u'Source/WebCore/accessibility/AccessibilityTable.cpp', u'Source/WebCore/accessibility/AccessibilityTableCell.cpp', u'Source/WebCore/accessibility/AccessibilityTableColumn.cpp', u'Source/WebCore/accessibility/AccessibilityTableHeaderContainer.cpp', u'Source/WebCore/accessibility/AccessibilityTableRow.cpp', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm', u'Source/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp', u'Source/WebCore/bindings/js/JSGeolocationCustom.cpp', u'Source/WebCore/bindings/js/ScriptController.cpp', u'Source/WebCore/bindings/js/SerializedScriptValue.cpp', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/css/CSSFontSelector.cpp', u'Source/WebCore/css/CSSGradientValue.cpp', u'Source/WebCore/css/CSSParser.cpp', u'Source/WebCore/css/CSSReflectValue.cpp', u'Source/WebCore/css/DeprecatedStyleBuilder.cpp', u'Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp', u'Source/WebCore/css/SVGCSSParser.cpp', u'Source/WebCore/css/StylePropertySet.cpp', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/dom/CharacterData.cpp', u'Source/WebCore/dom/ContainerNode.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/Node.cpp', u'Source/WebCore/dom/Range.cpp', u'Source/WebCore/dom/ScriptedAnimationController.cpp', u'Source/WebCore/dom/StyledElement.cpp', u'Source/WebCore/dom/Text.cpp', u'Source/WebCore/dom/ViewportArguments.cpp', u'Source/WebCore/editing/AlternativeTextController.cpp', u'Source/WebCore/editing/ApplyStyleCommand.cpp', u'Source/WebCore/editing/CompositeEditCommand.cpp', u'Source/WebCore/editing/Editor.cpp', u'Source/WebCore/editing/EditorCommand.cpp', u'Source/WebCore/editing/TextIterator.cpp', u'Source/WebCore/editing/VisibleUnits.cpp', u'Source/WebCore/editing/htmlediting.cpp', u'Source/WebCore/editing/markup.cpp', u'Source/WebCore/fileapi/FileReaderLoader.cpp', u'Source/WebCore/history/BackForwardList.cpp', u'Source/WebCore/history/PageCache.cpp', u'Source/WebCore/html/BaseDateAndTimeInputType.cpp', u'Source/WebCore/html/FTPDirectoryDocument.cpp', u'Source/WebCore/html/HTMLAreaElement.cpp', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLFormControlElement.cpp', u'Source/WebCore/html/HTMLFormElement.cpp', u'Source/WebCore/html/HTMLImageElement.cpp', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HTMLMapElement.cpp', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/HTMLSelectElement.cpp', u'Source/WebCore/html/HTMLSourceElement.cpp', u'Source/WebCore/html/HTMLTableCellElement.cpp', u'Source/WebCore/html/HTMLTableElement.cpp', u'Source/WebCore/html/HTMLTextFormControlElement.cpp', u'Source/WebCore/html/HTMLTrackElement.cpp', u'Source/WebCore/html/ImageDocument.cpp', u'Source/WebCore/html/InputType.cpp', u'Source/WebCore/html/MediaController.cpp', u'Source/WebCore/html/NumberInputType.cpp', u'Source/WebCore/html/RangeInputType.cpp', u'Source/WebCore/html/SearchInputType.cpp', u'Source/WebCore/html/StepRange.cpp', u'Source/WebCore/html/TimeRanges.cpp', u'Source/WebCore/html/ValidationMessage.cpp', u'Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp', u'Source/WebCore/html/shadow/MediaControlElements.cpp', u'Source/WebCore/html/shadow/MediaControlsApple.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/inspector/ContentSearchUtils.cpp', u'Source/WebCore/inspector/DOMEditor.cpp', u'Source/WebCore/inspector/DOMPatchSupport.cpp', u'Source/WebCore/inspector/InjectedScriptHost.cpp', u'Source/WebCore/loader/ProgressTracker.cpp', u'Source/WebCore/loader/cache/CachedImage.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/page/FrameTree.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/PrintContext.cpp', u'Source/WebCore/page/SpatialNavigation.cpp', u'Source/WebCore/page/animation/CSSPropertyAnimation.cpp', u'Source/WebCore/platform/graphics/FloatRect.cpp', u'Source/WebCore/platform/graphics/GlyphPageTreeNode.cpp', u'Source/WebCore/platform/graphics/IntRect.cpp', u'Source/WebCore/platform/graphics/LayoutRect.cpp', u'Source/WebCore/platform/graphics/filters/FEMorphology.cpp', u'Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm', u'Source/WebCore/platform/text/TextCodecICU.cpp', u'Source/WebCore/rendering/LineWidth.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderFieldset.cpp', u'Source/WebCore/rendering/RenderFlowThread.cpp', u'Source/WebCore/rendering/RenderFrameBase.cpp', u'Source/WebCore/rendering/RenderFrameSet.cpp', u'Source/WebCore/rendering/RenderSlider.cpp', u'Source/WebCore/rendering/RenderTableCell.h', u'Source/WebCore/rendering/RenderTreeAsText.cpp', u'Source/WebCore/rendering/RootInlineBox.h', u'Source/WebCore/rendering/mathml/RenderMathMLRow.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp', u'Source/WebCore/rendering/style/RenderStyle.h', u'Source/WebCore/rendering/style/StyleGeneratedImage.cpp', u'Source/WebCore/style/StyleFontSizeFunctions.cpp', u'Source/WebCore/svg/SVGSVGElement.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebView/WebFrameView.mm', u'Source/WebKit/mac/WebView/WebHTMLView.mm', u'Source/WebKit/mac/WebView/WebView.mm']" exit_code: 1 Source/WebCore/platform/graphics/FloatRect.cpp:80: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] Source/WebCore/platform/graphics/IntRect.cpp:64: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] Source/WebCore/platform/graphics/IntRect.cpp:93: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] Total errors found: 3 in 96 files If any of these errors are false positives, please file a bug against check-webkit-style.

Darin Adler

Comment 3 2013-10-24 09:01:22 PDT

Comment on attachment 215069 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215069&action=review > Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp:160 > - when = max(0.0, when); > + when = std::max<double>(0, when); Inconsistent that you did this here, but not in DelayDSPKernel.cpp. > Source/WebCore/rendering/LineWidth.cpp:190 > - newLineWidth = max(0.0f, newLineRight - newLineLeft); > + newLineWidth = std::max(0.0f, newLineRight - newLineLeft); Later in the same file you did this the other way (max<float>).

Build Bot

Comment 4 2013-10-24 09:11:45 PDT

Comment on attachment 215069 [details] Patch Attachment 215069 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/10218095

EFL EWS Bot

Comment 5 2013-10-24 09:11:53 PDT

Comment on attachment 215069 [details] Patch Attachment 215069 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/10318099

EFL EWS Bot

Comment 6 2013-10-24 09:14:40 PDT

Comment on attachment 215069 [details] Patch Attachment 215069 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/10358093

Anders Carlsson

Comment 7 2013-10-24 09:16:13 PDT

Created attachment 215070 [details] Patch

WebKit Commit Bot

Comment 8 2013-10-24 09:17:46 PDT

Attachment 215070 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp', u'Source/WebCore/Modules/webaudio/AudioNodeInput.cpp', u'Source/WebCore/Modules/webaudio/AudioParamTimeline.cpp', u'Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp', u'Source/WebCore/Modules/webaudio/AudioSummingJunction.cpp', u'Source/WebCore/Modules/webaudio/DelayDSPKernel.cpp', u'Source/WebCore/Modules/webaudio/OfflineAudioDestinationNode.cpp', u'Source/WebCore/Modules/webaudio/OscillatorNode.cpp', u'Source/WebCore/Modules/webaudio/PannerNode.cpp', u'Source/WebCore/Modules/webaudio/WaveShaperDSPKernel.cpp', u'Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp', u'Source/WebCore/Modules/websockets/WebSocket.cpp', u'Source/WebCore/Modules/websockets/WebSocketChannel.cpp', u'Source/WebCore/Modules/websockets/WebSocketFrame.cpp', u'Source/WebCore/accessibility/AccessibilityARIAGrid.cpp', u'Source/WebCore/accessibility/AccessibilityARIAGridCell.cpp', u'Source/WebCore/accessibility/AccessibilityARIAGridRow.cpp', u'Source/WebCore/accessibility/AccessibilityList.cpp', u'Source/WebCore/accessibility/AccessibilityListBox.cpp', u'Source/WebCore/accessibility/AccessibilityListBoxOption.cpp', u'Source/WebCore/accessibility/AccessibilityNodeObject.cpp', u'Source/WebCore/accessibility/AccessibilityObject.cpp', u'Source/WebCore/accessibility/AccessibilityRenderObject.cpp', u'Source/WebCore/accessibility/AccessibilityTable.cpp', u'Source/WebCore/accessibility/AccessibilityTableCell.cpp', u'Source/WebCore/accessibility/AccessibilityTableColumn.cpp', u'Source/WebCore/accessibility/AccessibilityTableHeaderContainer.cpp', u'Source/WebCore/accessibility/AccessibilityTableRow.cpp', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm', u'Source/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp', u'Source/WebCore/bindings/js/JSGeolocationCustom.cpp', u'Source/WebCore/bindings/js/ScriptController.cpp', u'Source/WebCore/bindings/js/SerializedScriptValue.cpp', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/css/CSSFontSelector.cpp', u'Source/WebCore/css/CSSGradientValue.cpp', u'Source/WebCore/css/CSSParser.cpp', u'Source/WebCore/css/CSSReflectValue.cpp', u'Source/WebCore/css/DeprecatedStyleBuilder.cpp', u'Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp', u'Source/WebCore/css/SVGCSSParser.cpp', u'Source/WebCore/css/StylePropertySet.cpp', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/dom/CharacterData.cpp', u'Source/WebCore/dom/ContainerNode.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/Node.cpp', u'Source/WebCore/dom/Range.cpp', u'Source/WebCore/dom/ScriptedAnimationController.cpp', u'Source/WebCore/dom/StyledElement.cpp', u'Source/WebCore/dom/Text.cpp', u'Source/WebCore/dom/ViewportArguments.cpp', u'Source/WebCore/editing/AlternativeTextController.cpp', u'Source/WebCore/editing/ApplyStyleCommand.cpp', u'Source/WebCore/editing/CompositeEditCommand.cpp', u'Source/WebCore/editing/Editor.cpp', u'Source/WebCore/editing/EditorCommand.cpp', u'Source/WebCore/editing/TextIterator.cpp', u'Source/WebCore/editing/VisibleUnits.cpp', u'Source/WebCore/editing/htmlediting.cpp', u'Source/WebCore/editing/markup.cpp', u'Source/WebCore/fileapi/FileReaderLoader.cpp', u'Source/WebCore/history/BackForwardList.cpp', u'Source/WebCore/history/PageCache.cpp', u'Source/WebCore/html/BaseDateAndTimeInputType.cpp', u'Source/WebCore/html/FTPDirectoryDocument.cpp', u'Source/WebCore/html/HTMLAreaElement.cpp', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLFormControlElement.cpp', u'Source/WebCore/html/HTMLFormElement.cpp', u'Source/WebCore/html/HTMLImageElement.cpp', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HTMLMapElement.cpp', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/HTMLSelectElement.cpp', u'Source/WebCore/html/HTMLSourceElement.cpp', u'Source/WebCore/html/HTMLTableCellElement.cpp', u'Source/WebCore/html/HTMLTableElement.cpp', u'Source/WebCore/html/HTMLTextFormControlElement.cpp', u'Source/WebCore/html/HTMLTrackElement.cpp', u'Source/WebCore/html/ImageDocument.cpp', u'Source/WebCore/html/InputType.cpp', u'Source/WebCore/html/MediaController.cpp', u'Source/WebCore/html/NumberInputType.cpp', u'Source/WebCore/html/RangeInputType.cpp', u'Source/WebCore/html/SearchInputType.cpp', u'Source/WebCore/html/StepRange.cpp', u'Source/WebCore/html/TimeRanges.cpp', u'Source/WebCore/html/ValidationMessage.cpp', u'Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp', u'Source/WebCore/html/shadow/MediaControlElements.cpp', u'Source/WebCore/html/shadow/MediaControlsApple.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/inspector/ContentSearchUtils.cpp', u'Source/WebCore/inspector/DOMEditor.cpp', u'Source/WebCore/inspector/DOMPatchSupport.cpp', u'Source/WebCore/inspector/InjectedScriptHost.cpp', u'Source/WebCore/loader/ProgressTracker.cpp', u'Source/WebCore/loader/cache/CachedImage.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/page/FrameTree.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/PrintContext.cpp', u'Source/WebCore/page/SpatialNavigation.cpp', u'Source/WebCore/page/animation/CSSPropertyAnimation.cpp', u'Source/WebCore/platform/efl/RenderThemeEfl.cpp', u'Source/WebCore/platform/graphics/FloatRect.cpp', u'Source/WebCore/platform/graphics/GlyphPageTreeNode.cpp', u'Source/WebCore/platform/graphics/IntRect.cpp', u'Source/WebCore/platform/graphics/LayoutRect.cpp', u'Source/WebCore/platform/graphics/filters/FEMorphology.cpp', u'Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm', u'Source/WebCore/platform/text/TextCodecICU.cpp', u'Source/WebCore/rendering/LineWidth.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderFieldset.cpp', u'Source/WebCore/rendering/RenderFlowThread.cpp', u'Source/WebCore/rendering/RenderFrameBase.cpp', u'Source/WebCore/rendering/RenderFrameSet.cpp', u'Source/WebCore/rendering/RenderSlider.cpp', u'Source/WebCore/rendering/RenderTableCell.h', u'Source/WebCore/rendering/RenderTreeAsText.cpp', u'Source/WebCore/rendering/RootInlineBox.h', u'Source/WebCore/rendering/mathml/RenderMathMLRow.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp', u'Source/WebCore/rendering/style/RenderStyle.h', u'Source/WebCore/rendering/style/StyleGeneratedImage.cpp', u'Source/WebCore/style/StyleFontSizeFunctions.cpp', u'Source/WebCore/svg/SVGSVGElement.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebView/WebFrameView.mm', u'Source/WebKit/mac/WebView/WebHTMLView.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/mac/WebProcessMac.mm']" exit_code: 1 Source/WebCore/platform/graphics/FloatRect.cpp:80: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] Source/WebCore/platform/graphics/IntRect.cpp:64: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] Source/WebCore/platform/graphics/IntRect.cpp:93: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] Total errors found: 3 in 99 files If any of these errors are false positives, please file a bug against check-webkit-style.

Anders Carlsson

Comment 9 2013-10-24 09:24:22 PDT

Created attachment 215071 [details] Patch

WebKit Commit Bot

Comment 10 2013-10-24 09:27:02 PDT

Attachment 215071 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp', u'Source/WebCore/Modules/webaudio/AudioNodeInput.cpp', u'Source/WebCore/Modules/webaudio/AudioParamTimeline.cpp', u'Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp', u'Source/WebCore/Modules/webaudio/AudioSummingJunction.cpp', u'Source/WebCore/Modules/webaudio/DelayDSPKernel.cpp', u'Source/WebCore/Modules/webaudio/OfflineAudioDestinationNode.cpp', u'Source/WebCore/Modules/webaudio/OscillatorNode.cpp', u'Source/WebCore/Modules/webaudio/PannerNode.cpp', u'Source/WebCore/Modules/webaudio/WaveShaperDSPKernel.cpp', u'Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp', u'Source/WebCore/Modules/websockets/WebSocket.cpp', u'Source/WebCore/Modules/websockets/WebSocketChannel.cpp', u'Source/WebCore/Modules/websockets/WebSocketFrame.cpp', u'Source/WebCore/accessibility/AccessibilityARIAGrid.cpp', u'Source/WebCore/accessibility/AccessibilityARIAGridCell.cpp', u'Source/WebCore/accessibility/AccessibilityARIAGridRow.cpp', u'Source/WebCore/accessibility/AccessibilityList.cpp', u'Source/WebCore/accessibility/AccessibilityListBox.cpp', u'Source/WebCore/accessibility/AccessibilityListBoxOption.cpp', u'Source/WebCore/accessibility/AccessibilityNodeObject.cpp', u'Source/WebCore/accessibility/AccessibilityObject.cpp', u'Source/WebCore/accessibility/AccessibilityRenderObject.cpp', u'Source/WebCore/accessibility/AccessibilityTable.cpp', u'Source/WebCore/accessibility/AccessibilityTableCell.cpp', u'Source/WebCore/accessibility/AccessibilityTableColumn.cpp', u'Source/WebCore/accessibility/AccessibilityTableHeaderContainer.cpp', u'Source/WebCore/accessibility/AccessibilityTableRow.cpp', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm', u'Source/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp', u'Source/WebCore/bindings/js/JSGeolocationCustom.cpp', u'Source/WebCore/bindings/js/ScriptController.cpp', u'Source/WebCore/bindings/js/SerializedScriptValue.cpp', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/css/CSSFontSelector.cpp', u'Source/WebCore/css/CSSGradientValue.cpp', u'Source/WebCore/css/CSSParser.cpp', u'Source/WebCore/css/CSSReflectValue.cpp', u'Source/WebCore/css/DeprecatedStyleBuilder.cpp', u'Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp', u'Source/WebCore/css/SVGCSSParser.cpp', u'Source/WebCore/css/StylePropertySet.cpp', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/dom/CharacterData.cpp', u'Source/WebCore/dom/ContainerNode.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/Node.cpp', u'Source/WebCore/dom/Range.cpp', u'Source/WebCore/dom/ScriptedAnimationController.cpp', u'Source/WebCore/dom/StyledElement.cpp', u'Source/WebCore/dom/Text.cpp', u'Source/WebCore/dom/ViewportArguments.cpp', u'Source/WebCore/editing/AlternativeTextController.cpp', u'Source/WebCore/editing/ApplyStyleCommand.cpp', u'Source/WebCore/editing/CompositeEditCommand.cpp', u'Source/WebCore/editing/Editor.cpp', u'Source/WebCore/editing/EditorCommand.cpp', u'Source/WebCore/editing/TextIterator.cpp', u'Source/WebCore/editing/VisibleUnits.cpp', u'Source/WebCore/editing/htmlediting.cpp', u'Source/WebCore/editing/markup.cpp', u'Source/WebCore/fileapi/FileReaderLoader.cpp', u'Source/WebCore/history/BackForwardList.cpp', u'Source/WebCore/history/PageCache.cpp', u'Source/WebCore/html/BaseDateAndTimeInputType.cpp', u'Source/WebCore/html/FTPDirectoryDocument.cpp', u'Source/WebCore/html/HTMLAreaElement.cpp', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLFormControlElement.cpp', u'Source/WebCore/html/HTMLFormElement.cpp', u'Source/WebCore/html/HTMLImageElement.cpp', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HTMLMapElement.cpp', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/HTMLSelectElement.cpp', u'Source/WebCore/html/HTMLSourceElement.cpp', u'Source/WebCore/html/HTMLTableCellElement.cpp', u'Source/WebCore/html/HTMLTableElement.cpp', u'Source/WebCore/html/HTMLTextFormControlElement.cpp', u'Source/WebCore/html/HTMLTrackElement.cpp', u'Source/WebCore/html/ImageDocument.cpp', u'Source/WebCore/html/InputType.cpp', u'Source/WebCore/html/MediaController.cpp', u'Source/WebCore/html/NumberInputType.cpp', u'Source/WebCore/html/RangeInputType.cpp', u'Source/WebCore/html/SearchInputType.cpp', u'Source/WebCore/html/StepRange.cpp', u'Source/WebCore/html/TimeRanges.cpp', u'Source/WebCore/html/ValidationMessage.cpp', u'Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp', u'Source/WebCore/html/shadow/MediaControlElements.cpp', u'Source/WebCore/html/shadow/MediaControlsApple.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/inspector/ContentSearchUtils.cpp', u'Source/WebCore/inspector/DOMEditor.cpp', u'Source/WebCore/inspector/DOMPatchSupport.cpp', u'Source/WebCore/inspector/InjectedScriptHost.cpp', u'Source/WebCore/loader/ProgressTracker.cpp', u'Source/WebCore/loader/cache/CachedImage.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/page/FrameTree.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/PrintContext.cpp', u'Source/WebCore/page/SpatialNavigation.cpp', u'Source/WebCore/page/animation/CSSPropertyAnimation.cpp', u'Source/WebCore/platform/efl/RenderThemeEfl.cpp', u'Source/WebCore/platform/graphics/FloatRect.cpp', u'Source/WebCore/platform/graphics/GlyphPageTreeNode.cpp', u'Source/WebCore/platform/graphics/IntRect.cpp', u'Source/WebCore/platform/graphics/LayoutRect.cpp', u'Source/WebCore/platform/graphics/filters/FEMorphology.cpp', u'Source/WebCore/platform/gtk/RenderThemeGtk.cpp', u'Source/WebCore/platform/gtk/RenderThemeGtk3.cpp', u'Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm', u'Source/WebCore/platform/text/TextCodecICU.cpp', u'Source/WebCore/rendering/LineWidth.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderFieldset.cpp', u'Source/WebCore/rendering/RenderFlowThread.cpp', u'Source/WebCore/rendering/RenderFrameBase.cpp', u'Source/WebCore/rendering/RenderFrameSet.cpp', u'Source/WebCore/rendering/RenderSlider.cpp', u'Source/WebCore/rendering/RenderTableCell.h', u'Source/WebCore/rendering/RenderTreeAsText.cpp', u'Source/WebCore/rendering/RootInlineBox.h', u'Source/WebCore/rendering/mathml/RenderMathMLRow.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp', u'Source/WebCore/rendering/style/RenderStyle.h', u'Source/WebCore/rendering/style/StyleGeneratedImage.cpp', u'Source/WebCore/style/StyleFontSizeFunctions.cpp', u'Source/WebCore/svg/SVGSVGElement.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebView/WebFrameView.mm', u'Source/WebKit/mac/WebView/WebHTMLView.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/mac/WebProcessMac.mm']" exit_code: 1 Source/WebCore/platform/graphics/FloatRect.cpp:80: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] Source/WebCore/platform/graphics/IntRect.cpp:64: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] Source/WebCore/platform/graphics/IntRect.cpp:93: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] Total errors found: 3 in 101 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alexey Proskuryakov

Comment 11 2013-10-24 09:33:25 PDT

Comment on attachment 215071 [details] Patch rs=me, please make EWS green (except for style bot I guess)

Build Bot

Comment 12 2013-10-24 10:08:15 PDT

Comment on attachment 215071 [details] Patch Attachment 215071 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/10378120

Anders Carlsson

Comment 13 2013-10-24 10:16:03 PDT

Created attachment 215078 [details] Patch

WebKit Commit Bot

Comment 14 2013-10-24 10:18:20 PDT

Attachment 215078 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp', u'Source/WebCore/Modules/webaudio/AudioNodeInput.cpp', u'Source/WebCore/Modules/webaudio/AudioParamTimeline.cpp', u'Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp', u'Source/WebCore/Modules/webaudio/AudioSummingJunction.cpp', u'Source/WebCore/Modules/webaudio/DelayDSPKernel.cpp', u'Source/WebCore/Modules/webaudio/OfflineAudioDestinationNode.cpp', u'Source/WebCore/Modules/webaudio/OscillatorNode.cpp', u'Source/WebCore/Modules/webaudio/PannerNode.cpp', u'Source/WebCore/Modules/webaudio/WaveShaperDSPKernel.cpp', u'Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp', u'Source/WebCore/Modules/websockets/WebSocket.cpp', u'Source/WebCore/Modules/websockets/WebSocketChannel.cpp', u'Source/WebCore/Modules/websockets/WebSocketFrame.cpp', u'Source/WebCore/accessibility/AccessibilityARIAGrid.cpp', u'Source/WebCore/accessibility/AccessibilityARIAGridCell.cpp', u'Source/WebCore/accessibility/AccessibilityARIAGridRow.cpp', u'Source/WebCore/accessibility/AccessibilityList.cpp', u'Source/WebCore/accessibility/AccessibilityListBox.cpp', u'Source/WebCore/accessibility/AccessibilityListBoxOption.cpp', u'Source/WebCore/accessibility/AccessibilityNodeObject.cpp', u'Source/WebCore/accessibility/AccessibilityObject.cpp', u'Source/WebCore/accessibility/AccessibilityRenderObject.cpp', u'Source/WebCore/accessibility/AccessibilityTable.cpp', u'Source/WebCore/accessibility/AccessibilityTableCell.cpp', u'Source/WebCore/accessibility/AccessibilityTableColumn.cpp', u'Source/WebCore/accessibility/AccessibilityTableHeaderContainer.cpp', u'Source/WebCore/accessibility/AccessibilityTableRow.cpp', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm', u'Source/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp', u'Source/WebCore/bindings/js/JSGeolocationCustom.cpp', u'Source/WebCore/bindings/js/ScriptController.cpp', u'Source/WebCore/bindings/js/SerializedScriptValue.cpp', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/css/CSSFontSelector.cpp', u'Source/WebCore/css/CSSGradientValue.cpp', u'Source/WebCore/css/CSSParser.cpp', u'Source/WebCore/css/CSSReflectValue.cpp', u'Source/WebCore/css/DeprecatedStyleBuilder.cpp', u'Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp', u'Source/WebCore/css/SVGCSSParser.cpp', u'Source/WebCore/css/StylePropertySet.cpp', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/dom/CharacterData.cpp', u'Source/WebCore/dom/ContainerNode.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/Node.cpp', u'Source/WebCore/dom/Range.cpp', u'Source/WebCore/dom/ScriptedAnimationController.cpp', u'Source/WebCore/dom/StyledElement.cpp', u'Source/WebCore/dom/Text.cpp', u'Source/WebCore/dom/ViewportArguments.cpp', u'Source/WebCore/editing/AlternativeTextController.cpp', u'Source/WebCore/editing/ApplyStyleCommand.cpp', u'Source/WebCore/editing/CompositeEditCommand.cpp', u'Source/WebCore/editing/Editor.cpp', u'Source/WebCore/editing/EditorCommand.cpp', u'Source/WebCore/editing/TextIterator.cpp', u'Source/WebCore/editing/VisibleUnits.cpp', u'Source/WebCore/editing/htmlediting.cpp', u'Source/WebCore/editing/markup.cpp', u'Source/WebCore/fileapi/FileReaderLoader.cpp', u'Source/WebCore/history/BackForwardList.cpp', u'Source/WebCore/history/PageCache.cpp', u'Source/WebCore/html/BaseDateAndTimeInputType.cpp', u'Source/WebCore/html/FTPDirectoryDocument.cpp', u'Source/WebCore/html/HTMLAreaElement.cpp', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLFormControlElement.cpp', u'Source/WebCore/html/HTMLFormElement.cpp', u'Source/WebCore/html/HTMLImageElement.cpp', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HTMLMapElement.cpp', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/HTMLSelectElement.cpp', u'Source/WebCore/html/HTMLSourceElement.cpp', u'Source/WebCore/html/HTMLTableCellElement.cpp', u'Source/WebCore/html/HTMLTableElement.cpp', u'Source/WebCore/html/HTMLTextFormControlElement.cpp', u'Source/WebCore/html/HTMLTrackElement.cpp', u'Source/WebCore/html/ImageDocument.cpp', u'Source/WebCore/html/InputType.cpp', u'Source/WebCore/html/MediaController.cpp', u'Source/WebCore/html/NumberInputType.cpp', u'Source/WebCore/html/RangeInputType.cpp', u'Source/WebCore/html/SearchInputType.cpp', u'Source/WebCore/html/StepRange.cpp', u'Source/WebCore/html/TimeRanges.cpp', u'Source/WebCore/html/ValidationMessage.cpp', u'Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp', u'Source/WebCore/html/shadow/MediaControlElements.cpp', u'Source/WebCore/html/shadow/MediaControlsApple.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/inspector/ContentSearchUtils.cpp', u'Source/WebCore/inspector/DOMEditor.cpp', u'Source/WebCore/inspector/DOMPatchSupport.cpp', u'Source/WebCore/inspector/InjectedScriptHost.cpp', u'Source/WebCore/loader/ProgressTracker.cpp', u'Source/WebCore/loader/cache/CachedImage.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/page/FrameTree.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/PrintContext.cpp', u'Source/WebCore/page/SpatialNavigation.cpp', u'Source/WebCore/page/animation/CSSPropertyAnimation.cpp', u'Source/WebCore/platform/efl/RenderThemeEfl.cpp', u'Source/WebCore/platform/graphics/FloatRect.cpp', u'Source/WebCore/platform/graphics/GlyphPageTreeNode.cpp', u'Source/WebCore/platform/graphics/IntRect.cpp', u'Source/WebCore/platform/graphics/LayoutRect.cpp', u'Source/WebCore/platform/graphics/filters/FEMorphology.cpp', u'Source/WebCore/platform/gtk/RenderThemeGtk.cpp', u'Source/WebCore/platform/gtk/RenderThemeGtk2.cpp', u'Source/WebCore/platform/gtk/RenderThemeGtk3.cpp', u'Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm', u'Source/WebCore/platform/text/TextCodecICU.cpp', u'Source/WebCore/platform/win/PopupMenuWin.cpp', u'Source/WebCore/rendering/LineWidth.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderFieldset.cpp', u'Source/WebCore/rendering/RenderFlowThread.cpp', u'Source/WebCore/rendering/RenderFrameBase.cpp', u'Source/WebCore/rendering/RenderFrameSet.cpp', u'Source/WebCore/rendering/RenderSlider.cpp', u'Source/WebCore/rendering/RenderTableCell.h', u'Source/WebCore/rendering/RenderTreeAsText.cpp', u'Source/WebCore/rendering/RootInlineBox.h', u'Source/WebCore/rendering/mathml/RenderMathMLRow.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp', u'Source/WebCore/rendering/style/RenderStyle.h', u'Source/WebCore/rendering/style/StyleGeneratedImage.cpp', u'Source/WebCore/style/StyleFontSizeFunctions.cpp', u'Source/WebCore/svg/SVGSVGElement.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebView/WebFrameView.mm', u'Source/WebKit/mac/WebView/WebHTMLView.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/mac/WebProcessMac.mm']" exit_code: 1 Source/WebCore/platform/graphics/FloatRect.cpp:80: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] Source/WebCore/platform/graphics/IntRect.cpp:64: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] Source/WebCore/platform/graphics/IntRect.cpp:93: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] Total errors found: 3 in 103 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andreas Kling

Comment 15 2013-10-24 17:47:47 PDT

Comment on attachment 215078 [details] Patch This is really nice. r=me.

WebKit Commit Bot

Comment 16 2013-10-24 18:13:55 PDT

Comment on attachment 215078 [details] Patch Clearing flags on attachment: 215078 Committed r157971: <http://trac.webkit.org/changeset/157971>

WebKit Commit Bot

Comment 17 2013-10-24 18:13:58 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.