Bug 123259

Summary: Show unmute for unmute context menu action
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: MediaAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: NEW ---    
Severity: Normal CC: andersca, cdumez, commit-queue, eflews.bot, eric.carlson, glenn, gyuyoung.kim, jer.noble, rakuco, rego+ews, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch jer.noble: review+, commit-queue: commit-queue-

Description Allan Sandfeld Jensen 2013-10-24 02:59:06 PDT 
The 'mute' context-menu action should show 'unmute' when that is what the action would perform.

(Alternatively the mute action should be a checkable context-menu item).
Comment 1 Allan Sandfeld Jensen 2013-10-24 03:01:25 PDT 
Created attachment 215040 [details]
Patch
Comment 2 EFL EWS Bot 2013-10-24 03:37:56 PDT 
Comment on attachment 215040 [details]
Patch

Attachment 215040 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/11468011
Comment 3 EFL EWS Bot 2013-10-24 04:28:01 PDT 
Comment on attachment 215040 [details]
Patch

Attachment 215040 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/10418020
Comment 4 Allan Sandfeld Jensen 2013-10-24 04:36:31 PDT 
Created attachment 215053 [details]
Patch
Comment 5 Jer Noble 2013-10-24 09:16:10 PDT 
LGTM, but this could be tested in media/context-menu-actions.html.

(There is an existing "Mute" test, but an additional test could test "Unmute" and verify that the end state after clicking that item is unmuted.)
Comment 6 Allan Sandfeld Jensen 2013-10-30 08:36:14 PDT 
Created attachment 215508 [details]
Patch

Added test
Comment 7 Jer Noble 2013-10-30 08:56:48 PDT 
Comment on attachment 215508 [details]
Patch

r=me.
Comment 8 WebKit Commit Bot 2013-10-30 12:06:02 PDT 
Comment on attachment 215508 [details]
Patch

Rejecting attachment 215508 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 215508, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
LayoutTests
:040000 040000 2d029f3af9fe7d5a535cf26e65595f2a86f930a7 c7df8cd71f4f7a702f1cfdfdef0e1974245e1fc1 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: http://webkit-queues.appspot.com/results/16058283