Bug 123258

Summary:

Qt workaround can be removed from Source/WebCore/css/make-css-file-arrays.pl

Product:

WebKit

Reporter:

Peter Molnar <pmolnar.u-szeged>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, gyuyoung.kim, macpherson, menard

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Remove Qt workaround.	none

Peter Molnar

Reported 2013-10-24 01:26:23 PDT

!$defines case can be removed, because Qt and Android aren't in WebKit trunk, all ports (Mac,EFL,GTK,Windows) call this script with --defines option now

Attachments
Remove Qt workaround. (1.71 KB, patch) 2013-10-24 01:34 PDT, Peter Molnar	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Peter Molnar

Comment 1 2013-10-24 01:34:22 PDT

Created attachment 215037 [details] Remove Qt workaround.

Csaba Osztrogonác

Comment 2 2013-10-24 06:04:20 PDT

Comment on attachment 215037 [details] Remove Qt workaround. LGTM, r=me.

WebKit Commit Bot

Comment 3 2013-10-24 06:28:30 PDT

Comment on attachment 215037 [details] Remove Qt workaround. Clearing flags on attachment: 215037 Committed r157926: <http://trac.webkit.org/changeset/157926>

WebKit Commit Bot

Comment 4 2013-10-24 06:28:32 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.