Bug 123206

Summary: Build scripts should add |Win32 for Windows 32-bit builds
Product: WebKit Reporter: Alex Christensen <alex.christensen>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: bfulgham, buildbot, commit-queue, dbates, eflews.bot, gtk-ews, gyuyoung.kim, philn, rniwa, xan.lopez
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Alex Christensen 2013-10-23 07:15:50 PDT
I thought we did not need to be this explicit, but after opening a solution, building it with the x64 configuration, then running build-webkit or build-jsc, it defaults to the 64-bit build.  The script should add |Win32 or |x64, depending on the desired configuration.
Comment 1 Alex Christensen 2013-10-23 07:27:50 PDT
Created attachment 214958 [details]
Patch
Comment 2 Build Bot 2013-10-23 07:29:08 PDT
Comment on attachment 214958 [details]
Patch

Attachment 214958 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/9658010
Comment 3 EFL EWS Bot 2013-10-23 07:31:37 PDT
Comment on attachment 214958 [details]
Patch

Attachment 214958 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/9848012
Comment 4 Build Bot 2013-10-23 08:08:56 PDT
Comment on attachment 214958 [details]
Patch

Attachment 214958 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/9858010
Comment 5 EFL EWS Bot 2013-10-23 08:10:06 PDT
Comment on attachment 214958 [details]
Patch

Attachment 214958 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/9958002
Comment 6 kov's GTK+ EWS bot 2013-10-23 08:51:32 PDT
Comment on attachment 214958 [details]
Patch

Attachment 214958 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/4548155
Comment 7 Alex Christensen 2013-10-23 12:18:39 PDT
Created attachment 214980 [details]
Patch
Comment 8 Brent Fulgham 2013-10-23 13:02:26 PDT
Comment on attachment 214980 [details]
Patch

r=me
Comment 9 Brent Fulgham 2013-10-23 13:05:16 PDT
Comment on attachment 214980 [details]
Patch

Whoops!  This doesn't work.  It's putting the "|Win32" into the path.
Comment 10 Alex Christensen 2013-10-23 13:17:11 PDT
Created attachment 214986 [details]
Patch
Comment 11 Brent Fulgham 2013-10-23 13:29:21 PDT
Comment on attachment 214986 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214986&action=review

r=me

> Tools/Scripts/old-run-webkit-tests:436
> +    $dumpToolName .= "_debug" if configuration() eq "Debug_All";

I think this is now called "DebugSuffix" in the Visual Studio project, but I'm not sure if other targets use "Debug_All" to define their builds.

We might want to change this to "DebugSuffix" if it's only used on Windows.
Comment 12 WebKit Commit Bot 2013-10-23 13:53:48 PDT
Comment on attachment 214986 [details]
Patch

Clearing flags on attachment: 214986

Committed r157882: <http://trac.webkit.org/changeset/157882>
Comment 13 WebKit Commit Bot 2013-10-23 13:53:51 PDT
All reviewed patches have been landed.  Closing bug.