Bug 123203

Summary: Make more StringImpl construction functions return PassRef.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Web Template FrameworkAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, esprehn+autocc, glenn, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Andreas Kling
Reported 2013-10-23 06:12:20 PDT
Patch ahoy.
Attachments
Patch (8.88 KB, patch)
2013-10-23 06:13 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-10-23 06:13:46 PDT
Created attachment 214950 [details] Patch
Antti Koivisto
Comment 2 2013-10-23 06:40:31 PDT
Comment on attachment 214950 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=214950&action=review > Source/WTF/wtf/text/AtomicString.cpp:134 > static void translate(StringImpl*& location, const UCharBuffer& buf, unsigned hash) Can these just return PassRef<StringImpl>?
WebKit Commit Bot
Comment 3 2013-10-23 12:11:56 PDT
Comment on attachment 214950 [details] Patch Clearing flags on attachment: 214950 Committed r157877: <http://trac.webkit.org/changeset/157877>
WebKit Commit Bot
Comment 4 2013-10-23 12:11:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.