Bug 123172

Summary:

{ClipPathOperation, FilterOperation}::getOperationType() should not include ‘get'

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

CSS

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

allan.jensen, commit-queue, dino, d-r, dstockwell, esprehn+autocc, fmalita, glenn, gyuyoung.kim, kondapallykalyan, macpherson, menard, pdr, schenney, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
stylebot	simon.fraser: review+

Tim Horton

Reported 2013-10-22 14:07:39 PDT

We use 'get' for things with out params, not straightforward getters.

Attachments
patch (31.40 KB, patch) 2013-10-22 15:05 PDT, Tim Horton	no flags	Details Formatted Diff Diff
stylebot (31.39 KB, patch) 2013-10-22 15:14 PDT, Tim Horton	simon.fraser: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Tim Horton

Comment 1 2013-10-22 15:05:39 PDT

Created attachment 214890 [details] patch

WebKit Commit Bot

Comment 2 2013-10-22 15:07:14 PDT

Attachment 214890 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/page/animation/CSSPropertyAnimation.cpp', u'Source/WebCore/platform/graphics/GraphicsLayer.cpp', u'Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp', u'Source/WebCore/platform/graphics/ca/mac/PlatformCAFiltersMac.mm', u'Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm', u'Source/WebCore/platform/graphics/filters/FilterOperation.h', u'Source/WebCore/platform/graphics/filters/FilterOperations.cpp', u'Source/WebCore/platform/graphics/transforms/IdentityTransformOperation.h', u'Source/WebCore/platform/graphics/transforms/Matrix3DTransformOperation.h', u'Source/WebCore/platform/graphics/transforms/MatrixTransformOperation.h', u'Source/WebCore/platform/graphics/transforms/PerspectiveTransformOperation.h', u'Source/WebCore/platform/graphics/transforms/RotateTransformOperation.h', u'Source/WebCore/platform/graphics/transforms/ScaleTransformOperation.h', u'Source/WebCore/platform/graphics/transforms/SkewTransformOperation.h', u'Source/WebCore/platform/graphics/transforms/TransformOperation.h', u'Source/WebCore/platform/graphics/transforms/TranslateTransformOperation.h', u'Source/WebCore/rendering/ClipPathOperation.h', u'Source/WebCore/rendering/FilterEffectRenderer.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayerFilterInfo.cpp', u'Source/WebCore/rendering/style/RenderStyle.cpp', u'Source/WebCore/rendering/svg/SVGRenderingContext.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/WebCoreArgumentCoders.cpp', u'Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm']" exit_code: 1 Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2831: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 1 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tim Horton

Comment 3 2013-10-22 15:14:48 PDT

Created attachment 214891 [details] stylebot

Tim Horton

Comment 4 2013-10-22 15:32:26 PDT

http://trac.webkit.org/changeset/157823

Note You need to log in before you can comment on or make changes to this bug.