| Summary: | [GTK] enable media-stream in build-webkit | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||||||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, dbates, gtk-ews, mrobinson, pnormand, xan.lopez | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 79203 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Philippe Normand
2013-10-22 02:24:34 PDT
Created attachment 214826 [details]
enable mediastream in autofools
Comment on attachment 214826 [details] enable mediastream in autofools View in context: https://bugs.webkit.org/attachment.cgi?id=214826&action=review I'm okay with enabling media stream for build-webkit, but let's not add a configure flag. > Source/autotools/ReadCommandLineArguments.m4:133 > +AC_MSG_CHECKING([whether to enable media stream support]) > +AC_ARG_ENABLE(media_stream, > + AC_HELP_STRING([--enable-media-stream], [enable media stream support (incomplete) [default=no]]), > + [], > + [enable_media_stream="no"]) > +AC_MSG_RESULT([$enable_media_stream]) > + I don't think we actually need a configuration flag for this. It's incomplete and we don't typically add flags for web features. The existing flags are exceptions to this rule. So how is it supposed to work without the configure option? All this patch relies on it. I only want MEDIA_STREAM on for developer builds... (In reply to comment #3) > So how is it supposed to work without the configure option? All this patch relies on it. > > I only want MEDIA_STREAM on for developer builds... If you don't add the setting to %configurableFeatures, the default will be overridden by WebKitBuild/Release/WebKitFeatureOverrides.txt, which is combined with the default options during configuration with the defaults defined in SetupWebKitFeatures.m4. Created attachment 215290 [details]
enable media-stream in GTK build
Comment on attachment 215290 [details] enable media-stream in GTK build Attachment 215290 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/15608065 Created attachment 215293 [details]
enable media-stream in GTK build
Comment on attachment 215293 [details] enable media-stream in GTK build Attachment 215293 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/15568087 Created attachment 215294 [details]
enable media-stream in GTK build
Committed r158194: <http://trac.webkit.org/changeset/158194> |