Bug 12313 – Need code style guidelines for multi-line boolean expressions

• Component: WebKit Website
• Status: CLOSED FIXED

[David Kilzer (:ddkilzer)]

The code style guidelines page on the web site needs style guidelines for multi-line boolean expressions per Bug 12305 Comment #12.  Something to the effect of:

Boolean expressions at the same nesting level that span multiple lines should have their operators on the left side of the line instead of the right side.

Wrong:

    return attr->name() == srcAttr ||
           attr->name() == lowsrcAttr ||
           (attr->name() == usemapAttr && attr->value().domString()[0] != '#');

Right:

    return attr->name() == srcAttr
        || attr->name() == lowsrcAttr
        || (attr->name() == usemapAttr && attr->value().domString()[0] != '#');

[Robert Blaut]

Created attachment 22336 [details]
Patch for the issue

[Robert Blaut]

After applying this patch WebKit will match Firefox and Opera behavior.

[Robert Blaut]

(In reply to comment #2)
> After applying this patch WebKit will match Firefox and Opera behavior.
> 

This comment is in wrong place :(

[David Kilzer (:ddkilzer)]

Comment on attachment 22336 [details]
Patch for the issue

I think 4 spaces for indenting the code is sufficient for the multi-line boolean expressions.

I'd like Darin to comment on this as well since he may have a different perspective on where operators should go.

[David Kilzer (:ddkilzer)]

Comment on attachment 22336 [details]
Patch for the issue

Oops!  Reading the inspiration for this bug, I see Darin already made his opinion known.

I will change the indentation to 4 spaces when I land the patch.  Thanks Robert!

r=me

[David Kilzer (:ddkilzer)]

Committed r35232

I also moved the item from "Other Punctuation" section up to the "Indentation" section since I thought it fit just a little better there.

[Robert Blaut]

(In reply to comment #6)
> Committed r35232
> 
> I also moved the item from "Other Punctuation" section up to the "Indentation"
> section since I thought it fit just a little better there.
> 

Thank you for landing it. I wasn't sure where it should be placed so I chose "other punctuation".