Bug 123077

Summary: Rename RegisterSet to TempRegisterSet
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: atrick, barraclough, commit-queue, ggaren, mark.lam, mhahnenberg, mitz, msaboff, nrotem, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 123076    
Attachments:
Description Flags
the patch
none
the patch
mitz: review+
the patch none

Description Filip Pizlo 2013-10-19 20:46:29 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2013-10-19 20:47:15 PDT 
Created attachment 214685 [details]
the patch
Comment 2 mitz 2013-10-19 20:52:04 PDT 
Comment on attachment 214685 [details]
the patch

I think you need to update the Xcode project reference to this file, and maybe other build systems that reference headers.
Comment 3 Filip Pizlo 2013-10-19 20:54:55 PDT 
(In reply to comment #2)
> (From update of attachment 214685 [details])
> I think you need to update the Xcode project reference to this file, and maybe other build systems that reference headers.

Oh yeah, good point :-)
Comment 4 WebKit Commit Bot 2013-10-19 20:55:35 PDT 
Attachment 214685 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/bytecode/StructureStubInfo.h', u'Source/JavaScriptCore/dfg/DFGJITCompiler.h', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h', u'Source/JavaScriptCore/jit/JITInlineCacheGenerator.cpp', u'Source/JavaScriptCore/jit/JITInlineCacheGenerator.h', u'Source/JavaScriptCore/jit/JITPropertyAccess.cpp', u'Source/JavaScriptCore/jit/JITPropertyAccess32_64.cpp', u'Source/JavaScriptCore/jit/RegisterSet.h', u'Source/JavaScriptCore/jit/ScratchRegisterAllocator.h', u'Source/JavaScriptCore/jit/TempRegisterSet.h']" exit_code: 1
Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:58:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/bytecode/StructureStubInfo.h:39:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Filip Pizlo 2013-10-19 20:55:54 PDT 
Created attachment 214686 [details]
the patch
Comment 6 Filip Pizlo 2013-10-19 20:56:52 PDT 
Created attachment 214687 [details]
the patch
Comment 7 WebKit Commit Bot 2013-10-19 20:58:25 PDT 
Attachment 214687 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/bytecode/StructureStubInfo.h', u'Source/JavaScriptCore/dfg/DFGJITCompiler.h', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h', u'Source/JavaScriptCore/jit/JITInlineCacheGenerator.cpp', u'Source/JavaScriptCore/jit/JITInlineCacheGenerator.h', u'Source/JavaScriptCore/jit/JITPropertyAccess.cpp', u'Source/JavaScriptCore/jit/JITPropertyAccess32_64.cpp', u'Source/JavaScriptCore/jit/RegisterSet.h', u'Source/JavaScriptCore/jit/ScratchRegisterAllocator.h', u'Source/JavaScriptCore/jit/TempRegisterSet.h']" exit_code: 1
Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:58:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Filip Pizlo 2013-10-19 21:11:01 PDT 
Landed in http://trac.webkit.org/changeset/157693
Comment 9 Filip Pizlo 2013-10-19 21:11:44 PDT 
Comment on attachment 214687 [details]
the patch

r=mitz, since this is almost an identical patch.