Bug 123048

Summary: Add option so that JSC will crash if it can't allocate executable memory for the JITs
Product: WebKit Reporter: Daniel Bates <dbates>
Component: JavaScriptCoreAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, ggaren, mhahnenberg, msaboff
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Daniel Bates
Reported 2013-10-18 16:26:10 PDT
Add an option to JSC, called crashIfCantAllocateJITMemory. If enabled and the operating system fails to provide executable memory then we will explicitly cause a crash to make it straightforward to identify the lack of availability of executable memory.
Attachments
Patch (4.24 KB, patch)
2013-10-18 16:30 PDT, Daniel Bates 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2013-10-18 16:30:38 PDT
Created attachment 214615 [details] Patch This patch only enables crashIfCantAllocateJITMemory on iOS for the jsc app.
Geoffrey Garen
Comment 2 2013-10-19 13:02:22 PDT
Comment on attachment 214615 [details] Patch r=me Is this an upstreaming patch, or do you need it for something else?
Daniel Bates
Comment 3 2013-10-21 08:33:59 PDT
(In reply to comment #2) > Is this an upstreaming patch, or do you need it for something else? This is an upstreaming patch.
Daniel Bates
Comment 4 2013-10-21 08:38:17 PDT
<rdar://problem/12856193>
Daniel Bates
Comment 5 2013-10-21 08:39:30 PDT
Committed r157719: <http://trac.webkit.org/changeset/157719>
Note You need to log in before you can comment on or make changes to this bug.