Bug 123040

Summary: Remove spaces between template angle brackets
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+

Description Anders Carlsson 2013-10-18 14:56:39 PDT
Remove spaces between template angle brackets
Comment 1 Anders Carlsson 2013-10-18 14:59:36 PDT
Created attachment 214604 [details]
Patch
Comment 2 WebKit Commit Bot 2013-10-18 15:03:00 PDT
Attachment 214604 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSCallbackObject.cpp', u'Source/JavaScriptCore/API/JSObjectRef.cpp', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/bytecode/CodeBlock.h', u'Source/JavaScriptCore/bytecode/DFGExitProfile.h', u'Source/JavaScriptCore/bytecode/EvalCodeCache.h', u'Source/JavaScriptCore/bytecode/Operands.h', u'Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.h', u'Source/JavaScriptCore/bytecode/Watchpoint.h', u'Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h', u'Source/JavaScriptCore/bytecompiler/StaticPropertyAnalysis.h', u'Source/JavaScriptCore/bytecompiler/StaticPropertyAnalyzer.h', u'Source/JavaScriptCore/dfg/DFGArgumentsSimplificationPhase.cpp', u'Source/JavaScriptCore/dfg/DFGBlockInsertionSet.h', u'Source/JavaScriptCore/dfg/DFGCSEPhase.cpp', u'Source/JavaScriptCore/dfg/DFGCommonData.h', u'Source/JavaScriptCore/dfg/DFGDesiredStructureChains.h', u'Source/JavaScriptCore/dfg/DFGDesiredWatchpoints.h', u'Source/JavaScriptCore/dfg/DFGJITCompiler.h', u'Source/JavaScriptCore/dfg/DFGOSRExitCompiler32_64.cpp', u'Source/JavaScriptCore/dfg/DFGOSRExitCompiler64.cpp', u'Source/JavaScriptCore/dfg/DFGWorklist.h', u'Source/JavaScriptCore/heap/BlockAllocator.h', u'Source/JavaScriptCore/heap/Heap.h', u'Source/JavaScriptCore/heap/Local.h', u'Source/JavaScriptCore/heap/MarkedBlock.h', u'Source/JavaScriptCore/heap/Strong.h', u'Source/JavaScriptCore/jit/AssemblyHelpers.cpp', u'Source/JavaScriptCore/jit/AssemblyHelpers.h', u'Source/JavaScriptCore/jit/SpecializedThunkJIT.h', u'Source/JavaScriptCore/parser/Nodes.h', u'Source/JavaScriptCore/parser/Parser.cpp', u'Source/JavaScriptCore/parser/Parser.h', u'Source/JavaScriptCore/parser/ParserArena.h', u'Source/JavaScriptCore/parser/SourceProviderCacheItem.h', u'Source/JavaScriptCore/profiler/LegacyProfiler.cpp', u'Source/JavaScriptCore/profiler/LegacyProfiler.h', u'Source/JavaScriptCore/profiler/ProfileNode.h', u'Source/JavaScriptCore/profiler/ProfilerDatabase.h', u'Source/JavaScriptCore/runtime/Butterfly.h', u'Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h', u'Source/JavaScriptCore/runtime/Identifier.h', u'Source/JavaScriptCore/runtime/JSPromise.h', u'Source/JavaScriptCore/runtime/PropertyMapHashTable.h', u'Source/JavaScriptCore/runtime/PropertyNameArray.h', u'Source/JavaScriptCore/runtime/RegExpCache.h', u'Source/JavaScriptCore/runtime/SparseArrayValueMap.h', u'Source/JavaScriptCore/runtime/SymbolTable.h', u'Source/JavaScriptCore/runtime/VM.h', u'Source/JavaScriptCore/tools/CodeProfile.cpp', u'Source/JavaScriptCore/tools/CodeProfile.h', u'Source/JavaScriptCore/yarr/YarrInterpreter.cpp', u'Source/JavaScriptCore/yarr/YarrInterpreter.h', u'Source/JavaScriptCore/yarr/YarrJIT.cpp', u'Source/JavaScriptCore/yarr/YarrPattern.cpp', u'Source/JavaScriptCore/yarr/YarrPattern.h', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/AVLTree.h', u'Source/WTF/wtf/CheckedArithmetic.h', u'Source/WTF/wtf/Compression.h', u'Source/WTF/wtf/Functional.h', u'Source/WTF/wtf/HashFunctions.h', u'Source/WTF/wtf/HashIterators.h', u'Source/WTF/wtf/HashSet.h', u'Source/WTF/wtf/ListHashSet.h', u'Source/WTF/wtf/RefCountedLeakCounter.cpp', u'Source/WTF/wtf/RetainPtr.h', u'Source/WTF/wtf/SentinelLinkedList.h', u'Source/WTF/wtf/SizeLimits.cpp', u'Source/WTF/wtf/StreamBuffer.h', u'Source/WTF/wtf/Vector.h', u'Source/WTF/wtf/VectorTraits.h', u'Source/WTF/wtf/WeakPtr.h', u'Source/WTF/wtf/text/AtomicString.cpp', u'Source/WTF/wtf/text/StringConcatenate.h', u'Source/WTF/wtf/text/StringImpl.h', u'Source/WTF/wtf/text/StringOperators.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/encryptedmedia/MediaKeySession.h', u'Source/WebCore/Modules/encryptedmedia/MediaKeys.h', u'Source/WebCore/Modules/geolocation/Geolocation.h', u'Source/WebCore/Modules/geolocation/GeolocationController.cpp', u'Source/WebCore/Modules/geolocation/GeolocationController.h', u'Source/WebCore/Modules/indexeddb/IDBCallbacks.h', u'Source/WebCore/Modules/indexeddb/IDBDatabase.h', u'Source/WebCore/Modules/indexeddb/IDBDatabaseBackendInterface.h', u'Source/WebCore/Modules/indexeddb/IDBEventDispatcher.cpp', u'Source/WebCore/Modules/indexeddb/IDBEventDispatcher.h', u'Source/WebCore/Modules/indexeddb/IDBKey.h', u'Source/WebCore/Modules/indexeddb/IDBObjectStore.h', u'Source/WebCore/Modules/indexeddb/IDBPendingTransactionMonitor.cpp', u'Source/WebCore/Modules/indexeddb/IDBRequest.cpp', u'Source/WebCore/Modules/indexeddb/IDBRequest.h', u'Source/WebCore/Modules/indexeddb/IDBTransaction.cpp', u'Source/WebCore/Modules/indexeddb/IDBTransaction.h', u'Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp', u'Source/WebCore/Modules/mediacontrols/MediaControlsHost.h', u'Source/WebCore/Modules/mediasource/MediaSource.cpp', u'Source/WebCore/Modules/mediasource/MediaSource.h', u'Source/WebCore/Modules/mediasource/MediaSourceBase.cpp', u'Source/WebCore/Modules/mediasource/MediaSourceBase.h', u'Source/WebCore/Modules/mediasource/MediaSourceRegistry.cpp', u'Source/WebCore/Modules/mediasource/MediaSourceRegistry.h', u'Source/WebCore/Modules/mediasource/SourceBufferList.h', u'Source/WebCore/Modules/mediasource/WebKitMediaSource.cpp', u'Source/WebCore/Modules/mediasource/WebKitMediaSource.h', u'Source/WebCore/Modules/mediasource/WebKitSourceBufferList.h', u'Source/WebCore/Modules/mediastream/MediaStream.cpp', u'Source/WebCore/Modules/mediastream/MediaStream.h', u'Source/WebCore/Modules/mediastream/MediaStreamRegistry.h', u'Source/WebCore/Modules/mediastream/MediaStreamTrack.h', u'Source/WebCore/Modules/mediastream/RTCDTMFSender.cpp', u'Source/WebCore/Modules/mediastream/RTCDTMFSender.h', u'Source/WebCore/Modules/mediastream/RTCDataChannel.cpp', u'Source/WebCore/Modules/mediastream/RTCDataChannel.h', u'Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp', u'Source/WebCore/Modules/mediastream/RTCPeerConnection.h', u'Source/WebCore/Modules/mediastream/RTCStatsResponse.h', u'Source/WebCore/Modules/notifications/Notification.h', u'Source/WebCore/Modules/notifications/NotificationCenter.h', u'Source/WebCore/Modules/speech/SpeechSynthesis.cpp', u'Source/WebCore/Modules/speech/SpeechSynthesis.h', u'Source/WebCore/Modules/webaudio/AudioBuffer.h', u'Source/WebCore/Modules/webaudio/AudioNode.h', u'Source/WebCore/Modules/webaudio/AudioNodeOutput.h', u'Source/WebCore/Modules/webaudio/MediaStreamAudioSource.cpp', u'Source/WebCore/Modules/webaudio/PeriodicWave.h', u'Source/WebCore/Modules/webaudio/ScriptProcessorNode.h', u'Source/WebCore/Modules/webdatabase/AbstractDatabaseServer.h', u'Source/WebCore/Modules/webdatabase/DatabaseBackend.h', u'Source/WebCore/Modules/webdatabase/DatabaseManager.cpp', u'Source/WebCore/Modules/webdatabase/DatabaseManager.h', u'Source/WebCore/Modules/webdatabase/DatabaseServer.cpp', u'Source/WebCore/Modules/webdatabase/DatabaseServer.h', u'Source/WebCore/Modules/webdatabase/DatabaseThread.h', u'Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp', u'Source/WebCore/Modules/webdatabase/DatabaseTracker.h', u'Source/WebCore/Modules/webdatabase/SQLStatementBackend.cpp', u'Source/WebCore/Modules/webdatabase/SQLTransactionBackend.cpp', u'Source/WebCore/Modules/webdatabase/SQLTransactionBackend.h', u'Source/WebCore/Modules/webdatabase/SQLTransactionCoordinator.cpp', u'Source/WebCore/Modules/webdatabase/SQLTransactionCoordinator.h', u'Source/WebCore/Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp', u'Source/WebCore/Modules/websockets/ThreadableWebSocketChannelClientWrapper.h', u'Source/WebCore/Modules/websockets/WebSocket.cpp', u'Source/WebCore/Modules/websockets/WebSocket.h', u'Source/WebCore/Modules/websockets/WebSocketChannel.cpp', u'Source/WebCore/Modules/websockets/WebSocketChannel.h', u'Source/WebCore/Modules/websockets/WebSocketChannelClient.h', u'Source/WebCore/Modules/websockets/WebSocketExtensionDispatcher.h', u'Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.cpp', u'Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.h', u'Source/WebCore/accessibility/AXObjectCache.cpp', u'Source/WebCore/accessibility/AXObjectCache.h', u'Source/WebCore/accessibility/AccessibilityNodeObject.cpp', u'Source/WebCore/accessibility/AccessibilityObject.h', u'Source/WebCore/bindings/js/DOMWrapperWorld.h', u'Source/WebCore/bindings/js/JSDOMBinding.h', u'Source/WebCore/bindings/js/JSDOMGlobalObject.h', u'Source/WebCore/bindings/js/JSMutationCallback.cpp', u'Source/WebCore/bindings/js/JSMutationCallback.h', u'Source/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp', u'Source/WebCore/bindings/js/PageScriptDebugServer.h', u'Source/WebCore/bindings/js/ScheduledAction.h', u'Source/WebCore/bindings/js/ScriptController.cpp', u'Source/WebCore/bindings/js/ScriptController.h', u'Source/WebCore/bindings/js/ScriptDebugServer.h', u'Source/WebCore/bindings/js/ScriptProfile.cpp', u'Source/WebCore/bindings/objc/ObjCNodeFilterCondition.h', u'Source/WebCore/bridge/objc/objc_class.h', u'Source/WebCore/bridge/runtime_root.cpp', u'Source/WebCore/bridge/runtime_root.h', u'Source/WebCore/css/BasicShapeFunctions.cpp', u'Source/WebCore/css/CSSBasicShapes.h', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/css/CSSFontFace.h', u'Source/WebCore/css/CSSFontFaceSource.h', u'Source/WebCore/css/CSSFontSelector.cpp', u'Source/WebCore/css/CSSFontSelector.h', u'Source/WebCore/css/CSSGroupingRule.h', u'Source/WebCore/css/CSSImageGeneratorValue.h', u'Source/WebCore/css/CSSParserValues.cpp', u'Source/WebCore/css/CSSParserValues.h', u'Source/WebCore/css/CSSPropertySourceData.h', u'Source/WebCore/css/CSSRuleList.h', u'Source/WebCore/css/CSSSegmentedFontFace.cpp', u'Source/WebCore/css/CSSSegmentedFontFace.h', u'Source/WebCore/css/CSSSelectorList.cpp', u'Source/WebCore/css/CSSSelectorList.h', u'Source/WebCore/css/CSSStyleSheet.h', u'Source/WebCore/css/CSSValue.h', u'Source/WebCore/css/CSSValuePool.h', u'Source/WebCore/css/DocumentRuleSets.cpp', u'Source/WebCore/css/DocumentRuleSets.h', u'Source/WebCore/css/ElementRuleCollector.cpp', u'Source/WebCore/css/ElementRuleCollector.h', u'Source/WebCore/css/FontLoader.h', u'Source/WebCore/css/InspectorCSSOMWrappers.cpp', u'Source/WebCore/css/InspectorCSSOMWrappers.h', u'Source/WebCore/css/MediaList.cpp', u'Source/WebCore/css/MediaList.h', u'Source/WebCore/css/MediaQueryEvaluator.cpp', u'Source/WebCore/css/MediaQueryMatcher.h', u'Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp', u'Source/WebCore/css/PropertySetCSSStyleDeclaration.h', u'Source/WebCore/css/RuleSet.cpp', u'Source/WebCore/css/RuleSet.h', u'Source/WebCore/css/SelectorFilter.h', u'Source/WebCore/css/StyleInvalidationAnalysis.cpp', u'Source/WebCore/css/StylePropertySet.cpp', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/css/StyleResolver.h', u'Source/WebCore/css/StyleRule.cpp', u'Source/WebCore/css/StyleRule.h', u'Source/WebCore/css/StyleScopeResolver.h', u'Source/WebCore/css/StyleSheetContents.cpp', u'Source/WebCore/css/StyleSheetContents.h', u'Source/WebCore/css/StyleSheetList.cpp', u'Source/WebCore/css/StyleSheetList.h', u'Source/WebCore/css/WebKitCSSKeyframesRule.h', u'Source/WebCore/dom/CheckedRadioButtons.h', u'Source/WebCore/dom/ClientRectList.h', u'Source/WebCore/dom/ContainerNode.h', u'Source/WebCore/dom/CrossThreadTask.h', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/Document.h', u'Source/WebCore/dom/DocumentMarkerController.cpp', u'Source/WebCore/dom/DocumentMarkerController.h', u'Source/WebCore/dom/DocumentStyleSheetCollection.cpp', u'Source/WebCore/dom/DocumentStyleSheetCollection.h', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/dom/Element.h', u'Source/WebCore/dom/EventListenerMap.h', u'Source/WebCore/dom/EventSender.h', u'Source/WebCore/dom/IdTargetObserverRegistry.h', u'Source/WebCore/dom/MutationCallback.h', u'Source/WebCore/dom/MutationObserver.cpp', u'Source/WebCore/dom/MutationObserver.h', u'Source/WebCore/dom/MutationObserverRegistration.h', u'Source/WebCore/dom/NamedFlowCollection.cpp', u'Source/WebCore/dom/NamedFlowCollection.h', u'Source/WebCore/dom/Node.cpp', u'Source/WebCore/dom/Node.h', u'Source/WebCore/dom/NodeRareData.h', u'Source/WebCore/dom/Range.cpp', u'Source/WebCore/dom/Range.h', u'Source/WebCore/dom/ScopedEventQueue.h', u'Source/WebCore/dom/ScriptExecutionContext.cpp', u'Source/WebCore/dom/ScriptExecutionContext.h', u'Source/WebCore/dom/ScriptedAnimationController.h', u'Source/WebCore/editing/ApplyStyleCommand.cpp', u'Source/WebCore/editing/BreakBlockquoteCommand.cpp', u'Source/WebCore/editing/CompositeEditCommand.cpp', u'Source/WebCore/editing/CompositeEditCommand.h', u'Source/WebCore/editing/EditingStyle.cpp', u'Source/WebCore/editing/Editor.cpp', u'Source/WebCore/editing/Editor.h', u'Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp', u'Source/WebCore/editing/InsertParagraphSeparatorCommand.h', u'Source/WebCore/editing/MergeIdenticalElementsCommand.cpp', u'Source/WebCore/editing/RemoveNodePreservingChildrenCommand.cpp', u'Source/WebCore/editing/ReplaceSelectionCommand.cpp', u'Source/WebCore/editing/SimplifyMarkupCommand.cpp', u'Source/WebCore/editing/SimplifyMarkupCommand.h', u'Source/WebCore/editing/SpellChecker.h', u'Source/WebCore/editing/SplitElementCommand.cpp', u'Source/WebCore/editing/WrapContentsInDummySpanCommand.cpp', u'Source/WebCore/editing/mac/AlternativeTextUIController.h', u'Source/WebCore/fileapi/FileList.h', u'Source/WebCore/history/BackForwardList.h', u'Source/WebCore/history/HistoryItem.cpp', u'Source/WebCore/history/HistoryItem.h', u'Source/WebCore/history/mac/HistoryItemMac.mm', u'Source/WebCore/html/FormController.h', u'Source/WebCore/html/HTMLAnchorElement.cpp', u'Source/WebCore/html/HTMLCollection.cpp', u'Source/WebCore/html/HTMLCollection.h', u'Source/WebCore/html/HTMLFormControlElement.cpp', u'Source/WebCore/html/HTMLFormControlElement.h', u'Source/WebCore/html/HTMLFormElement.cpp', u'Source/WebCore/html/HTMLFormElement.h', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/HTMLMediaElement.h', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/html/HTMLSelectElement.cpp', u'Source/WebCore/html/MediaController.cpp', u'Source/WebCore/html/MediaController.h', u'Source/WebCore/html/MediaFragmentURIParser.h', u'Source/WebCore/html/ValidationMessage.h', u'Source/WebCore/html/canvas/WebGLFramebuffer.h', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp', u'Source/WebCore/html/canvas/WebGLRenderingContext.h', u'Source/WebCore/html/canvas/WebGLTexture.h', u'Source/WebCore/html/parser/BackgroundHTMLParser.cpp', u'Source/WebCore/html/parser/BackgroundHTMLParser.h', u'Source/WebCore/html/parser/HTMLDocumentParser.cpp', u'Source/WebCore/html/parser/HTMLDocumentParser.h', u'Source/WebCore/html/parser/HTMLMetaCharsetParser.h', u'Source/WebCore/html/parser/HTMLPreloadScanner.cpp', u'Source/WebCore/html/parser/HTMLResourcePreloader.h', u'Source/WebCore/html/parser/XSSAuditor.h', u'Source/WebCore/html/shadow/ContentDistributor.cpp', u'Source/WebCore/html/shadow/ContentDistributor.h', u'Source/WebCore/html/shadow/MediaControlElements.cpp', u'Source/WebCore/html/shadow/MediaControlElements.h', u'Source/WebCore/html/track/InbandGenericTextTrack.h', u'Source/WebCore/html/track/InbandWebVTTTextTrack.cpp', u'Source/WebCore/html/track/LoadableTextTrack.cpp', u'Source/WebCore/html/track/TextTrackCueList.h', u'Source/WebCore/html/track/TextTrackList.cpp', u'Source/WebCore/html/track/TextTrackList.h', u'Source/WebCore/html/track/TrackListBase.cpp', u'Source/WebCore/html/track/TrackListBase.h', u'Source/WebCore/html/track/WebVTTParser.cpp', u'Source/WebCore/html/track/WebVTTParser.h', u'Source/WebCore/inspector/ConsoleMessage.cpp', u'Source/WebCore/inspector/ContentSearchUtils.cpp', u'Source/WebCore/inspector/ContentSearchUtils.h', u'Source/WebCore/inspector/DOMPatchSupport.cpp', u'Source/WebCore/inspector/DOMPatchSupport.h', u'Source/WebCore/inspector/InjectedScript.cpp', u'Source/WebCore/inspector/InjectedScript.h', u'Source/WebCore/inspector/InjectedScriptHost.h', u'Source/WebCore/inspector/InspectorAgent.cpp', u'Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp', u'Source/WebCore/inspector/InspectorApplicationCacheAgent.h', u'Source/WebCore/inspector/InspectorBaseAgent.h', u'Source/WebCore/inspector/InspectorCSSAgent.cpp', u'Source/WebCore/inspector/InspectorCSSAgent.h', u'Source/WebCore/inspector/InspectorConsoleAgent.h', u'Source/WebCore/inspector/InspectorDOMAgent.cpp', u'Source/WebCore/inspector/InspectorDOMAgent.h', u'Source/WebCore/inspector/InspectorDOMStorageAgent.cpp', u'Source/WebCore/inspector/InspectorDOMStorageAgent.h', u'Source/WebCore/inspector/InspectorDatabaseAgent.cpp', u'Source/WebCore/inspector/InspectorDatabaseAgent.h', u'Source/WebCore/inspector/InspectorDebuggerAgent.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.h', u'Source/WebCore/inspector/InspectorHeapProfilerAgent.cpp', u'Source/WebCore/inspector/InspectorHeapProfilerAgent.h', u'Source/WebCore/inspector/InspectorHistory.h', u'Source/WebCore/inspector/InspectorIndexedDBAgent.cpp', u'Source/WebCore/inspector/InspectorLayerTreeAgent.cpp', u'Source/WebCore/inspector/InspectorLayerTreeAgent.h', u'Source/WebCore/inspector/InspectorMemoryAgent.h', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/InspectorPageAgent.h', u'Source/WebCore/inspector/InspectorProfilerAgent.cpp', u'Source/WebCore/inspector/InspectorProfilerAgent.h', u'Source/WebCore/inspector/InspectorResourceAgent.h', u'Source/WebCore/inspector/InspectorRuntimeAgent.cpp', u'Source/WebCore/inspector/InspectorRuntimeAgent.h', u'Source/WebCore/inspector/InspectorState.h', u'Source/WebCore/inspector/InspectorStyleSheet.cpp', u'Source/WebCore/inspector/InspectorStyleSheet.h', u'Source/WebCore/inspector/InspectorValues.cpp', u'Source/WebCore/inspector/InspectorValues.h', u'Source/WebCore/inspector/PageRuntimeAgent.cpp', u'Source/WebCore/inspector/ScriptCallStack.cpp', u'Source/WebCore/inspector/ScriptCallStack.h', u'Source/WebCore/loader/CrossOriginPreflightResultCache.h', u'Source/WebCore/loader/DocumentLoader.cpp', u'Source/WebCore/loader/DocumentLoader.h', u'Source/WebCore/loader/FormState.h', u'Source/WebCore/loader/FormSubmission.cpp', u'Source/WebCore/loader/ProgressTracker.h', u'Source/WebCore/loader/ResourceLoadScheduler.h', u'Source/WebCore/loader/TextTrackLoader.cpp', u'Source/WebCore/loader/TextTrackLoader.h', u'Source/WebCore/loader/WorkerThreadableLoader.cpp', u'Source/WebCore/loader/appcache/ApplicationCache.cpp', u'Source/WebCore/loader/appcache/ApplicationCache.h', u'Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp', u'Source/WebCore/loader/archive/Archive.cpp', u'Source/WebCore/loader/archive/Archive.h', u'Source/WebCore/loader/archive/ArchiveResourceCollection.cpp', u'Source/WebCore/loader/archive/ArchiveResourceCollection.h', u'Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp', u'Source/WebCore/loader/archive/cf/LegacyWebArchive.h', u'Source/WebCore/loader/archive/mhtml/MHTMLParser.h', u'Source/WebCore/loader/cache/CachedResource.h', u'Source/WebCore/loader/cache/CachedResourceLoader.h', u'Source/WebCore/loader/cache/MemoryCache.h', u'Source/WebCore/loader/icon/IconDatabase.cpp', u'Source/WebCore/loader/icon/IconDatabase.h', u'Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp', u'Source/WebCore/page/CaptionUserPreferencesMediaAF.h', u'Source/WebCore/page/ChromeClient.h', u'Source/WebCore/page/Console.h', u'Source/WebCore/page/ContentSecurityPolicy.h', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/DeviceController.cpp', u'Source/WebCore/page/DeviceController.h', u'Source/WebCore/page/EditorClient.h', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/page/EventHandler.h', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/Page.h', u'Source/WebCore/page/PageGroup.h', u'Source/WebCore/page/Performance.cpp', u'Source/WebCore/page/Performance.h', u'Source/WebCore/page/PerformanceEntryList.cpp', u'Source/WebCore/page/PerformanceEntryList.h', u'Source/WebCore/page/SecurityOriginHash.h', u'Source/WebCore/page/SecurityPolicy.cpp', u'Source/WebCore/page/SpeechInputResult.h', u'Source/WebCore/page/animation/AnimationController.cpp', u'Source/WebCore/page/animation/AnimationControllerPrivate.h', u'Source/WebCore/page/animation/CSSPropertyAnimation.cpp', u'Source/WebCore/page/animation/CompositeAnimation.h', u'Source/WebCore/page/scrolling/ScrollingStateNode.cpp', u'Source/WebCore/page/scrolling/ScrollingStateNode.h', u'Source/WebCore/page/scrolling/ScrollingThread.cpp', u'Source/WebCore/page/scrolling/ScrollingThread.h', u'Source/WebCore/page/scrolling/ScrollingTree.cpp', u'Source/WebCore/page/scrolling/ScrollingTreeNode.cpp', u'Source/WebCore/page/scrolling/ScrollingTreeNode.h', u'Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm', u'Source/WebCore/platform/CrossThreadCopier.cpp', u'Source/WebCore/platform/CrossThreadCopier.h', u'Source/WebCore/platform/DragData.h', u'Source/WebCore/platform/MainThreadTask.h', u'Source/WebCore/platform/PODFreeListArena.h', u'Source/WebCore/platform/PODIntervalTree.h', u'Source/WebCore/platform/PODRedBlackTree.h', u'Source/WebCore/platform/PlatformSpeechSynthesizer.cpp', u'Source/WebCore/platform/PlatformSpeechSynthesizer.h', u'Source/WebCore/platform/RunLoop.h', u'Source/WebCore/platform/ScrollView.cpp', u'Source/WebCore/platform/ScrollView.h', u'Source/WebCore/platform/SharedBuffer.h', u'Source/WebCore/platform/Supplementable.h', u'Source/WebCore/platform/URL.cpp', u'Source/WebCore/platform/audio/AudioBus.h', u'Source/WebCore/platform/audio/AudioDSPKernelProcessor.h', u'Source/WebCore/platform/audio/AudioResampler.h', u'Source/WebCore/platform/audio/DynamicsCompressor.h', u'Source/WebCore/platform/audio/DynamicsCompressorKernel.h', u'Source/WebCore/platform/audio/HRTFDatabase.h', u'Source/WebCore/platform/audio/HRTFKernel.h', u'Source/WebCore/platform/audio/MultiChannelResampler.h', u'Source/WebCore/platform/audio/Reverb.h', u'Source/WebCore/platform/audio/ReverbConvolver.h', u'Source/WebCore/platform/cf/SharedBufferCF.cpp', u'Source/WebCore/platform/graphics/FloatPolygon.cpp', u'Source/WebCore/platform/graphics/FloatPolygon.h', u'Source/WebCore/platform/graphics/FontCache.cpp', u'Source/WebCore/platform/graphics/GlyphMetricsMap.h', u'Source/WebCore/platform/graphics/GlyphPageTreeNode.h', u'Source/WebCore/platform/graphics/GraphicsContext3D.h', u'Source/WebCore/platform/graphics/GraphicsLayer.cpp', u'Source/WebCore/platform/graphics/GraphicsLayer.h', u'Source/WebCore/platform/graphics/PlatformTextTrackMenu.h', u'Source/WebCore/platform/graphics/SimpleFontData.h', u'Source/WebCore/platform/graphics/WidthCache.h', u'Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h', u'Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp', u'Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm', u'Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp', u'Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h', u'Source/WebCore/platform/graphics/ca/PlatformCAAnimation.h', u'Source/WebCore/platform/graphics/ca/PlatformCALayer.h', u'Source/WebCore/platform/graphics/ca/mac/LayerPool.h', u'Source/WebCore/platform/graphics/ca/mac/PlatformCAAnimationMac.mm', u'Source/WebCore/platform/graphics/ca/mac/TileController.h', u'Source/WebCore/platform/graphics/cg/SubimageCacheWithTimer.h', u'Source/WebCore/platform/graphics/filters/CustomFilterParameterList.h', u'Source/WebCore/platform/graphics/filters/FilterEffect.h', u'Source/WebCore/platform/graphics/filters/FilterOperations.h', u'Source/WebCore/platform/graphics/gpu/Texture.cpp', u'Source/WebCore/platform/graphics/gpu/Texture.h', u'Source/WebCore/platform/graphics/mac/ComplexTextController.h', u'Source/WebCore/platform/graphics/mac/SimpleFontDataCoreText.cpp', u'Source/WebCore/platform/graphics/transforms/TransformOperations.h', u'Source/WebCore/platform/ios/PasteboardIOS.mm', u'Source/WebCore/platform/mac/PlatformSpeechSynthesizerMac.mm', u'Source/WebCore/platform/mediastream/MediaStreamDescriptor.h', u'Source/WebCore/platform/mediastream/MediaStreamSource.h', u'Source/WebCore/platform/mediastream/RTCConfiguration.h', u'Source/WebCore/platform/network/BlobRegistryImpl.h', u'Source/WebCore/platform/network/HTTPHeaderMap.h', u'Source/WebCore/platform/network/ResourceResponseBase.cpp', u'Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp', u'Source/WebCore/platform/text/cf/HyphenationCF.cpp', u'Source/WebCore/plugins/PluginMainThreadScheduler.h', u'Source/WebCore/rendering/HitTestResult.h', u'Source/WebCore/rendering/InlineFlowBox.h', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderButton.h', u'Source/WebCore/rendering/RenderCounter.cpp', u'Source/WebCore/rendering/RenderGrid.cpp', u'Source/WebCore/rendering/RenderGrid.h', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayer.h', u'Source/WebCore/rendering/RenderNamedFlowThread.cpp', u'Source/WebCore/rendering/RenderNamedFlowThread.h', u'Source/WebCore/rendering/RenderRegion.cpp', u'Source/WebCore/rendering/RenderRegion.h', u'Source/WebCore/rendering/RenderView.cpp', u'Source/WebCore/rendering/RootInlineBox.h', u'Source/WebCore/rendering/shapes/PolygonShape.cpp', u'Source/WebCore/rendering/shapes/PolygonShape.h', u'Source/WebCore/rendering/shapes/Shape.cpp', u'Source/WebCore/rendering/shapes/ShapeInfo.h', u'Source/WebCore/rendering/shapes/ShapeInterval.h', u'Source/WebCore/rendering/style/QuotesData.cpp', u'Source/WebCore/rendering/style/QuotesData.h', u'Source/WebCore/rendering/style/RenderStyle.cpp', u'Source/WebCore/rendering/style/StyleGridData.h', u'Source/WebCore/rendering/svg/RenderSVGResourceGradient.h', u'Source/WebCore/rendering/svg/RenderSVGResourcePattern.h', u'Source/WebCore/rendering/svg/SVGResourcesCache.h', u'Source/WebCore/storage/StorageEventDispatcher.cpp', u'Source/WebCore/storage/StorageEventDispatcher.h', u'Source/WebCore/storage/StorageNamespaceImpl.h', u'Source/WebCore/storage/StorageThread.h', u'Source/WebCore/storage/StorageTracker.cpp', u'Source/WebCore/storage/StorageTracker.h', u'Source/WebCore/svg/SVGAnimatedPath.cpp', u'Source/WebCore/svg/SVGAnimatedTypeAnimator.cpp', u'Source/WebCore/svg/SVGAnimatedTypeAnimator.h', u'Source/WebCore/svg/SVGDocumentExtensions.cpp', u'Source/WebCore/svg/SVGDocumentExtensions.h', u'Source/WebCore/svg/SVGFontElement.h', u'Source/WebCore/svg/SVGGlyphMap.h', u'Source/WebCore/svg/SVGMarkerElement.cpp', u'Source/WebCore/svg/SVGMarkerElement.h', u'Source/WebCore/svg/SVGPathSegList.h', u'Source/WebCore/svg/animation/SMILTimeContainer.h', u'Source/WebCore/svg/graphics/SVGImageCache.h', u'Source/WebCore/svg/graphics/filters/SVGFilterBuilder.h', u'Source/WebCore/svg/properties/SVGAnimatedEnumerationPropertyTearOff.h', u'Source/WebCore/svg/properties/SVGAnimatedListPropertyTearOff.h', u'Source/WebCore/svg/properties/SVGAnimatedPropertyTearOff.h', u'Source/WebCore/svg/properties/SVGAnimatedStaticPropertyTearOff.h', u'Source/WebCore/svg/properties/SVGAttributeToPropertyMap.cpp', u'Source/WebCore/svg/properties/SVGAttributeToPropertyMap.h', u'Source/WebCore/svg/properties/SVGStaticListPropertyTearOff.h', u'Source/WebCore/svg/properties/SVGTransformListPropertyTearOff.h', u'Source/WebCore/workers/DefaultSharedWorkerRepository.h', u'Source/WebCore/workers/WorkerMessagingProxy.h', u'Source/WebCore/xml/XMLHttpRequestProgressEventThrottle.cpp', u'Source/WebCore/xml/XMLHttpRequestProgressEventThrottle.h', u'Source/WebCore/xml/XPathNodeSet.cpp', u'Source/WebCore/xml/XSLStyleSheet.h', u'Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/History/WebHistory.mm', u'Source/WebKit/mac/History/WebHistoryItem.mm', u'Source/WebKit/mac/Plugins/Hosted/NetscapePluginHostProxy.h', u'Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.h', u'Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm', u'Source/WebKit/mac/Plugins/WebNetscapePluginView.h', u'Source/WebKit/mac/Plugins/WebNetscapePluginView.mm', u'Source/WebKit/mac/Storage/WebDatabaseManager.mm', u'Source/WebKit/mac/Storage/WebStorageManager.mm', u'Source/WebKit/mac/WebCoreSupport/WebApplicationCache.mm', u'Source/WebKit/mac/WebCoreSupport/WebEditorClient.h', u'Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h', u'Source/WebKit/mac/WebCoreSupport/WebNotificationClient.h', u'Source/WebKit/mac/WebCoreSupport/WebNotificationClient.mm', u'Source/WebKit/mac/WebView/WebArchive.mm', u'Source/WebKit/mac/WebView/WebDataSource.mm', u'Source/WebKit/mac/WebView/WebViewData.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/mac/WebColorPickerMac.h', u'Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm', u'Source/WebKit2/WebProcess/WebProcess.cpp']" exit_code: 1
Source/WebCore/platform/graphics/gpu/Texture.h:57:  The parameter name "format" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/graphics/gpu/Texture.h:57:  Omit int when using unsigned  [runtime/unsigned] [1]
Source/WebCore/platform/graphics/gpu/Texture.h:61:  Omit int when using unsigned  [runtime/unsigned] [1]
Source/WebCore/loader/WorkerThreadableLoader.cpp:193:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/platform/graphics/gpu/Texture.cpp:49:  Omit int when using unsigned  [runtime/unsigned] [1]
Source/WebCore/platform/graphics/gpu/Texture.cpp:100:  Omit int when using unsigned  [runtime/unsigned] [1]
Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:622:  Omit int when using unsigned  [runtime/unsigned] [1]
Source/WebCore/inspector/InspectorProfilerAgent.h:110:  Omit int when using unsigned  [runtime/unsigned] [1]
Source/WebCore/inspector/InspectorProfilerAgent.h:111:  Omit int when using unsigned  [runtime/unsigned] [1]
Source/WTF/wtf/Functional.h:695:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WTF/wtf/Functional.h:713:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebCore/platform/CrossThreadCopier.cpp:78:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/CrossThreadCopier.cpp:83:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/CrossThreadCopier.cpp:104:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/CrossThreadCopier.cpp:110:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/CrossThreadCopier.cpp:123:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/CrossThreadCopier.cpp:130:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/network/HTTPHeaderMap.h:40:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/storage/StorageThread.h:65:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebCore/inspector/InspectorCSSAgent.h:116:  The parameter name "pseudoIdMatches" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WTF/wtf/HashFunctions.h:190:  More than one command on the same line  [whitespace/newline] [4]
Source/WTF/wtf/HashFunctions.h:194:  More than one command on the same line  [whitespace/newline] [4]
Source/WTF/wtf/HashFunctions.h:195:  More than one command on the same line  [whitespace/newline] [4]
Source/WTF/wtf/HashFunctions.h:196:  More than one command on the same line  [whitespace/newline] [4]
Source/WTF/wtf/HashFunctions.h:197:  More than one command on the same line  [whitespace/newline] [4]
Source/WTF/wtf/HashFunctions.h:198:  More than one command on the same line  [whitespace/newline] [4]
Source/WTF/wtf/HashFunctions.h:199:  More than one command on the same line  [whitespace/newline] [4]
Source/WTF/wtf/HashFunctions.h:200:  More than one command on the same line  [whitespace/newline] [4]
Source/WTF/wtf/HashFunctions.h:201:  More than one command on the same line  [whitespace/newline] [4]
Source/WTF/wtf/HashFunctions.h:202:  More than one command on the same line  [whitespace/newline] [4]
Source/WTF/wtf/HashFunctions.h:203:  More than one command on the same line  [whitespace/newline] [4]
Source/WTF/wtf/HashFunctions.h:204:  More than one command on the same line  [whitespace/newline] [4]
Source/WTF/wtf/HashFunctions.h:205:  More than one command on the same line  [whitespace/newline] [4]
Source/WTF/wtf/HashFunctions.h:206:  More than one command on the same line  [whitespace/newline] [4]
Source/WTF/wtf/HashFunctions.h:207:  More than one command on the same line  [whitespace/newline] [4]
Source/WTF/wtf/HashFunctions.h:208:  More than one command on the same line  [whitespace/newline] [4]
Source/WTF/wtf/HashFunctions.h:209:  More than one command on the same line  [whitespace/newline] [4]
Source/WTF/wtf/HashFunctions.h:213:  More than one command on the same line  [whitespace/newline] [4]
Source/WTF/wtf/RetainPtr.h:307:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 39 in 573 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2013-10-18 16:40:45 PDT
Committed r157653: <http://trac.webkit.org/changeset/157653>
Comment 4 Csaba Osztrogonác 2013-10-19 01:10:01 PDT
(In reply to comment #3)
> Committed r157653: <http://trac.webkit.org/changeset/157653>

FYI: It broke the build on the Lion bots.

/Volumes/Data/slave/lion-release/build/Source/WebCore/bindings/objc/ObjCNodeFilterCondition.h:55:36: error: expected '>'
        RetainPtr<id <DOMNodeFilter>> m_filter;
                                   ^
/Volumes/Data/slave/lion-release/build/Source/WebCore/bindings/objc/ObjCNodeFilterCondition.h:55:37: error: expected member name or ';' after declaration specifiers
        RetainPtr<id <DOMNodeFilter>> m_filter;
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
/Volumes/Data/slave/lion-release/build/Source/WebCore/bindings/objc/ObjCNodeFilterCondition.h:51:15: error: member initializer 'm_filter' does not name a non-static data member or base class
            : m_filter(filter)
              ^~~~~~~~~~~~~~~~
3 errors generated.