Bug 123021

Summary: Crash when requesting properties of sourcebuffer
Product: WebKit Reporter: Stephane Jadaud <sjadaud>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: UNCONFIRMED    
Severity: Normal CC: cdumez, commit-queue, david.corvoysier, eric.carlson, esprehn+autocc, glenn, jer.noble, kondapallykalyan, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch jer.noble: review+

Stephane Jadaud
Reported 2013-10-18 07:49:40 PDT
After activating media-source feature, a crash appears when requesting properties of source buffer list with Web Inspector. It looks to be caused by inheriting directly from EventTarget. It appears since integration of bug #118752.
Attachments
Patch (5.80 KB, patch)
2013-10-18 07:56 PDT, Stephane Jadaud 		jer.noble: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Stephane Jadaud
Comment 1 2013-10-18 07:56:14 PDT
Created attachment 214573 [details] Patch
Jer Noble
Comment 2 2013-10-18 12:47:58 PDT
Comment on attachment 214573 [details] Patch Yep, I've seen this too. I think there's a deeper problem in the generator, as other IDLs inherit from EventTarget, though not without also being ActiveDOMObjects. In the meantime, this is a good fix.
Alexey Proskuryakov
Comment 3 2013-10-23 10:50:26 PDT
Comment on attachment 214573 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=214573&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). Is this covered by existing regression tests? How will we know to not break this again in the future?
Stephane Jadaud
Comment 4 2013-10-24 00:49:05 PDT
(In reply to comment #3) > (From update of attachment 214573 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=214573&action=review > > > Source/WebCore/ChangeLog:8 > > + No new tests (OOPS!). > > Is this covered by existing regression tests? How will we know to not break this again in the future? It is covered by the media-source tests that are currently skipped. Media-source tests will be activated with bug #99065
Note You need to log in before you can comment on or make changes to this bug.