Bug 123021

Summary:

Crash when requesting properties of sourcebuffer

Product:

WebKit

Reporter:

Stephane Jadaud <sjadaud>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

UNCONFIRMED ---

Severity:

Normal

CC:

cdumez, commit-queue, david.corvoysier, eric.carlson, esprehn+autocc, glenn, jer.noble, kondapallykalyan, pnormand

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	jer.noble: review+

Description Stephane Jadaud 2013-10-18 07:49:40 PDT

After activating media-source feature, a crash appears when requesting properties of source buffer list with Web Inspector. It looks to be caused by inheriting directly from EventTarget. It appears since integration of bug #118752.

Comment 1 Stephane Jadaud 2013-10-18 07:56:14 PDT

Created attachment 214573 [details]
Patch

Comment 2 Jer Noble 2013-10-18 12:47:58 PDT

Comment on attachment 214573 [details]
Patch

Yep, I've seen this too.  I think there's a deeper problem in the generator, as other IDLs inherit from EventTarget, though not without also being ActiveDOMObjects.

In the meantime, this is a good fix.

Comment 3 Alexey Proskuryakov 2013-10-23 10:50:26 PDT

Comment on attachment 214573 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214573&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

Is this covered by existing regression tests? How will we know to not break this again in the future?

Comment 4 Stephane Jadaud 2013-10-24 00:49:05 PDT

(In reply to comment #3)
> (From update of attachment 214573 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=214573&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        No new tests (OOPS!).
> 
> Is this covered by existing regression tests? How will we know to not break this again in the future?

It is covered by the media-source tests that are currently skipped. Media-source tests will be activated with bug #99065