Bug 12299

Summary: REGRESSION: Page changes title when command-clicking on named anchor link
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Page LoadingAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar, Regression
Priority: P1    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
patch with change log mjs: review+

Description David Kilzer (:ddkilzer) 2007-01-17 07:17:21 PST 
Summary:

When command-clicking on an anchor link (<a href="#foo">link</a>), the title of the current page changes when a new tab is created.

Steps to reproduce:

1. Open Attachment 12006 [details] from Bug 11960.
2. Command-click on the link.

Expected Results:

Page title of current tab should not change from its URL.

Actual Results:

Page title of current page changes from its URL to: "unknown" failed to load

Regression:

This is a regression from shipping Safari 2.0.4 (419.3) on Mac OS X 10.4.8 (8L127).

Notes:

See Bug 11960 Comment #7 for original details.

Tested on locally-built debug build of WebKit r18906 with Safari 2.0.4 (419.3) on Mac OS X 10.4.8 (8L127).
Comment 1 Mark Rowe (bdash) 2007-01-17 14:23:31 PST 
<rdar://problem/4930503>
Comment 2 Darin Adler 2007-01-21 18:16:34 PST 
When I tried this I hit an assertion.

The problem seems to be that when the policy delegate set the policy to ignore, we keep doing way too much. Specifically, it looks like FrameLoader::continueFragmentScrollAfterNavigationPolicy doesn't look at the shouldContinute boolean at all.
Comment 3 Darin Adler 2007-01-21 18:25:56 PST 
Created attachment 12592 [details]
patch with change log
Comment 4 Maciej Stachowiak 2007-01-21 18:56:35 PST 
Comment on attachment 12592 [details]
patch with change log

r=me
Comment 5 Darin Adler 2007-01-21 19:04:23 PST 
Committed revision 19022.