Summary: | Fix three bugs in the equals() implementations for css gradients. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nico Weber <thakis> | ||||
Component: | New Bugs | Assignee: | Nico Weber <thakis> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, gyuyoung.kim, kling, macpherson, menard | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Nico Weber
2013-10-17 12:42:24 PDT
Created attachment 214492 [details]
Patch
Comment on attachment 214492 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=214492&action=review r=me, but.. > Source/WebCore/css/CSSGradientValue.cpp:737 > else > - equalXorY = !other.m_firstX || !other.m_firstY; > + equalXandY = !other.m_firstX && !other.m_firstY; Don't we already know that both firstX and firstY are null at this point? > Source/WebCore/css/CSSGradientValue.cpp:1149 > else > - equalXorY == !other.m_firstX || !other.m_firstY; > + equalXandY = !other.m_firstX && !other.m_firstY; And here? Comment on attachment 214492 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=214492&action=review Thanks! >> Source/WebCore/css/CSSGradientValue.cpp:737 >> + equalXandY = !other.m_firstX && !other.m_firstY; > > Don't we already know that both firstX and firstY are null at this point? Yes, but only for this, not for other (In reply to comment #3) > (From update of attachment 214492 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=214492&action=review > > Thanks! > > >> Source/WebCore/css/CSSGradientValue.cpp:737 > >> + equalXandY = !other.m_firstX && !other.m_firstY; > > > > Don't we already know that both firstX and firstY are null at this point? > > Yes, but only for this, not for other Durr. :| Comment on attachment 214492 [details] Patch Clearing flags on attachment: 214492 Committed r157598: <http://trac.webkit.org/changeset/157598> All reviewed patches have been landed. Closing bug. |