Bug 122971 – Add scaffolding for IDBDatabaseBackends in Web and Database processes

• Component: WebKit2
• Status: RESOLVED FIXED

[Brady Eidson]

Add scaffolding for IDBDatabaseBackends in Web and Database processes

This will set up a WebProcessIDBDatabaseBackend, DatabaseProcessIDBDatabaseBackend, the messaging between them, and a single message that can actually be sent as the result of JS on a page to show it's all hooked up correctly.

[Brady Eidson]

Created attachment 214469 [details]
Patch v1

[WebKit Commit Bot]

Attachment 214469 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/DatabaseProcess/DatabaseToWebProcessConnection.cpp', u'Source/WebKit2/DatabaseProcess/DatabaseToWebProcessConnection.h', u'Source/WebKit2/DatabaseProcess/DatabaseToWebProcessConnection.messages.in', u'Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBDatabaseBackend.cpp', u'Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBDatabaseBackend.h', u'Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBDatabaseBackend.messages.in', u'Source/WebKit2/DerivedSources.make', u'Source/WebKit2/Platform/Logging.h', u'Source/WebKit2/Shared/Databases/IndexedDB/IDBUtilities.cpp', u'Source/WebKit2/Shared/Databases/IndexedDB/IDBUtilities.h', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj', u'Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp', u'Source/WebKit2/WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.cpp', u'Source/WebKit2/WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.h', u'Source/WebKit2/WebProcess/Databases/WebToDatabaseProcessConnection.cpp', u'Source/WebKit2/WebProcess/Databases/WebToDatabaseProcessConnection.h']" exit_code: 1
Source/WebKit2/Shared/Databases/IndexedDB/IDBUtilities.h:47:  Could not find a newline character at the end of the file.  [whitespace/ending_newline] [5]
Source/WebKit2/WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.h:76:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 4 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brady Eidson]

(In reply to comment #2)
> Attachment 214469 [details] did not pass style-queue:
> 
> Source/WebKit2/Shared/Databases/IndexedDB/IDBUtilities.h:47:  Could not find a newline character at the end of the file.  [whitespace/ending_newline] [5]
> Source/WebKit2/WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.h:76:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
> Source/WebKit2/WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
> Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]

All fixed locally.

[Tim Horton]

Comment on attachment 214469 [details]
Patch v1 

View in context: https://bugs.webkit.org/attachment.cgi?id=214469&action=review

> Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:71
> +void WebIDBFactoryBackend::open(const String& databaseName, int64_t version, int64_t transactionId, PassRefPtr<IDBCallbacks> callbacks, PassRefPtr<IDBDatabaseCallbacks> databaseCallbacks, PassRefPtr<SecurityOrigin> prpSecurityOrigin, ScriptExecutionContext*, const String&)

prp :|

[Brady Eidson]

http://trac.webkit.org/changeset/157582

Will try to get gtk-wk2 building again, too.

[Brady Eidson]

(In reply to comment #5)
> http://trac.webkit.org/changeset/157582
> 
> Will try to get gtk-wk2 building again, too.

That attempt in http://trac.webkit.org/changeset/157583